All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/2] firewire: Kill unnecessary buf check in device_attribute.show
Date: Mon, 22 Jan 2024 17:56:04 +0900	[thread overview]
Message-ID: <20240122085604.GA254251@workstation.local> (raw)
In-Reply-To: <20240122053942.80648-1-lizhijian@fujitsu.com>

Hi,

On Mon, Jan 22, 2024 at 01:39:41PM +0800, Li Zhijian wrote:
> Per Documentation/filesystems/sysfs.rst:
> > sysfs allocates a buffer of size (PAGE_SIZE) and passes it to the
> > method.
> 
> So we can kill the unnecessary buf check safely.
> 
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
>  drivers/firewire/core-device.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)

Applied both patches to linux-next branch, since they are not so-urgent 
fixes.


Thanks

Takashi Sakamoto

  parent reply	other threads:[~2024-01-22  8:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22  5:39 [PATCH 1/2] firewire: Kill unnecessary buf check in device_attribute.show Li Zhijian
2024-01-22  5:39 ` [PATCH 2/2] firewire: Convert snprintf/sprintf to sysfs_emit Li Zhijian
2024-01-22  8:56 ` Takashi Sakamoto [this message]
2024-03-18  4:46   ` [PATCH 1/2] firewire: Kill unnecessary buf check in device_attribute.show Takashi Sakamoto
2024-03-18  6:24     ` Zhijian Li (Fujitsu)
2024-03-18  9:23       ` Takashi Sakamoto
2024-03-18  9:17     ` [PATCH] firewire: core: add memo about the caller of show functions for device attributes Takashi Sakamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240122085604.GA254251@workstation.local \
    --to=o-takashi@sakamocchi.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=lizhijian@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.