drivers/net/wireless/mediatek/mt76/mt7996/mcu.c:520 mt7996_mcu_rx_thermal_notify() warn: potential spectre issue 'dev->mt76.phys' [r] (local cap)

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Howard Hsu <howard-yh.hsu@mediatek.com>
CC: Felix Fietkau <nbd@nbd.name>
CC: Shayne Chen <shayne.chen@mediatek.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   6613476e225e090cc9aad49be7fa504e290dd33d
commit: 21f290884bc1c911aa9a0875c1d9a1e6fb9e0308 wifi: mt76: connac: add thermal protection support for mt7996
date:   7 weeks ago
:::::: branch date: 9 hours ago
:::::: commit date: 7 weeks ago
config: x86_64-randconfig-161-20240120 (https://download.01.org/0day-ci/archive/20240122/202401221402.HTdN0wtQ-lkp@intel.com/config)
compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202401221402.HTdN0wtQ-lkp@intel.com/

New smatch warnings:
drivers/net/wireless/mediatek/mt76/mt7996/mcu.c:520 mt7996_mcu_rx_thermal_notify() warn: potential spectre issue 'dev->mt76.phys' [r] (local cap)
drivers/net/wireless/mediatek/mt76/mt7996/mcu.c:521 mt7996_mcu_rx_thermal_notify() warn: possible spectre second half.  'mphy'

Old smatch warnings:
drivers/net/wireless/mediatek/mt76/mt7996/mcu.c:347 mt7996_mcu_rx_radar_detected() warn: potential spectre issue 'dev->mt76.phys' [r] (local cap)
drivers/net/wireless/mediatek/mt76/mt7996/mcu.c:349 mt7996_mcu_rx_radar_detected() warn: possible spectre second half.  'mphy'
drivers/net/wireless/mediatek/mt76/mt7996/mcu.c:429 mt7996_mcu_ie_countdown() warn: potential spectre issue 'dev->mt76.phys' [r] (local cap)
drivers/net/wireless/mediatek/mt76/mt7996/mcu.c:436 mt7996_mcu_ie_countdown() warn: possible spectre second half.  'mphy'
drivers/net/wireless/mediatek/mt76/mt7996/mcu.c:441 mt7996_mcu_ie_countdown() warn: possible spectre second half.  'mphy'
drivers/net/wireless/mediatek/mt76/mt7996/mcu.c:584 mt7996_mcu_wed_rro_event() warn: potential spectre issue 'dev->mt76.wcid' [w] (local cap)
drivers/net/wireless/mediatek/mt76/mt7996/mcu.c:591 mt7996_mcu_wed_rro_event() warn: potential spectre issue 'wcid->aggr' [w] (local cap)
drivers/net/wireless/mediatek/mt76/mt7996/mcu.c:2331 mt7996_mcu_beacon_mbss() warn: potential spectre issue 'sub_elem->data' [r] (local cap)
drivers/net/wireless/mediatek/mt76/mt7996/mcu.c:2323 mt7996_mcu_beacon_mbss() warn: potential spectre issue 'elem->data' [r] (local cap)

vim +520 drivers/net/wireless/mediatek/mt76/mt7996/mcu.c

adde3eed4a75fe Yi-Chia Hsieh 2023-09-21  499  
21f290884bc1c9 Howard Hsu    2023-10-23  500  static void
21f290884bc1c9 Howard Hsu    2023-10-23  501  mt7996_mcu_rx_thermal_notify(struct mt7996_dev *dev, struct sk_buff *skb)
21f290884bc1c9 Howard Hsu    2023-10-23  502  {
21f290884bc1c9 Howard Hsu    2023-10-23  503  #define THERMAL_NOTIFY_TAG 0x4
21f290884bc1c9 Howard Hsu    2023-10-23  504  #define THERMAL_NOTIFY 0x2
21f290884bc1c9 Howard Hsu    2023-10-23  505  	struct mt76_phy *mphy = &dev->mt76.phy;
21f290884bc1c9 Howard Hsu    2023-10-23  506  	struct mt7996_mcu_thermal_notify *n;
21f290884bc1c9 Howard Hsu    2023-10-23  507  	struct mt7996_phy *phy;
21f290884bc1c9 Howard Hsu    2023-10-23  508  
21f290884bc1c9 Howard Hsu    2023-10-23  509  	n = (struct mt7996_mcu_thermal_notify *)skb->data;
21f290884bc1c9 Howard Hsu    2023-10-23  510  
21f290884bc1c9 Howard Hsu    2023-10-23  511  	if (le16_to_cpu(n->tag) != THERMAL_NOTIFY_TAG)
21f290884bc1c9 Howard Hsu    2023-10-23  512  		return;
21f290884bc1c9 Howard Hsu    2023-10-23  513  
21f290884bc1c9 Howard Hsu    2023-10-23  514  	if (n->event_id != THERMAL_NOTIFY)
21f290884bc1c9 Howard Hsu    2023-10-23  515  		return;
21f290884bc1c9 Howard Hsu    2023-10-23  516  
21f290884bc1c9 Howard Hsu    2023-10-23  517  	if (n->band_idx > MT_BAND2)
21f290884bc1c9 Howard Hsu    2023-10-23  518  		return;
21f290884bc1c9 Howard Hsu    2023-10-23  519  
21f290884bc1c9 Howard Hsu    2023-10-23 @520  	mphy = dev->mt76.phys[n->band_idx];
21f290884bc1c9 Howard Hsu    2023-10-23 @521  	if (!mphy)
21f290884bc1c9 Howard Hsu    2023-10-23  522  		return;
21f290884bc1c9 Howard Hsu    2023-10-23  523  
21f290884bc1c9 Howard Hsu    2023-10-23  524  	phy = (struct mt7996_phy *)mphy->priv;
21f290884bc1c9 Howard Hsu    2023-10-23  525  	phy->throttle_state = n->duty_percent;
21f290884bc1c9 Howard Hsu    2023-10-23  526  }
21f290884bc1c9 Howard Hsu    2023-10-23  527  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki