From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 537F8C47DD9 for ; Mon, 22 Jan 2024 15:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qikxvj7VJAFLY5G8xALWt/D8WWY+f9MgCeBgSwBoF9w=; b=0JsBODqwmi7Grp kg690euRlyTgo7UubtJaQVO+6R/XeqaCjA155vOyxv5nUjS9aBzIIlJDEeCiqZgo+2nelA/qHYMyF hL3wAxDBuSVYwPDyT5JS2aqex0cpGkw2enNOWzVvc7QuUOmkxM2J4nIg6xzKFrMkKN+rlqy+ntkB9 H/yjffSLIvLaS/JDqiZEriEjZ02bVOw/7HlZ+gc/Mdc0CSUYhUJP6E2/Hs5SnD0QSjqJ1jogGnDbl hueLqprFr5iBhurpn/dAhNV+jNK6xg69vx2GJcI/0UFRHxynUw8y9WUNXP+oOpgejGO01gTyxhwPR fuZ6kJEeDjnTFI9H7Bxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rRvwx-00Cc9y-2O; Mon, 22 Jan 2024 15:10:59 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rRvwq-00Cc39-23; Mon, 22 Jan 2024 15:10:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 47ECBB80E87; Mon, 22 Jan 2024 15:10:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BD6EC433F1; Mon, 22 Jan 2024 15:10:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705936251; bh=5Dj8hag1O8UvRbU2sBKR41iqeOAf9gS1ldGtg4l3puI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qpdyXTZ6Ebdc7lFfLyt/UDMx0O5Wb202loKRM5DcfzV0mWImWBKwtBUEyPVlTNDHu lV67Jg/ad51Ds9RhbxgyCm1ntguzY8yLoL6gaDcTn97qETHtTK0/yOoYwQB9DQuP4r LjZBTthrHLtW9t30FKveklT9SGPIAc1o/FenF0gscErLChCbYDvXyVT/xhDa+LzeYU ULiurS8efeaMCONltMcjZVUGx3MLhf4CUasEpZV6RdgGoXq6EB+Bvvfo/URsj990VL dfK8FHY4igs/WDjZC+1JesTczWblRWYlG/bIJdIoq+gWc6U26/DfN83ozMQ3i+lF7Y HV1AW5QX6uRow== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tomi Valkeinen , Adam Ford , Laurent Pinchart , Mauro Carvalho Chehab , Sasha Levin , dafna@fastmail.com, heiko@sntech.de, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.1 23/53] media: rkisp1: Drop IRQF_SHARED Date: Mon, 22 Jan 2024 10:08:24 -0500 Message-ID: <20240122150949.994249-23-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122150949.994249-1-sashal@kernel.org> References: <20240122150949.994249-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.74 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240122_071052_817696_664CF8D9 X-CRM114-Status: GOOD ( 12.79 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: Tomi Valkeinen [ Upstream commit 85d2a31fe4d9be1555f621ead7a520d8791e0f74 ] In all known platforms the ISP has dedicated IRQ lines, but for some reason the driver uses IRQF_SHARED. Supporting IRQF_SHARED properly requires handling interrupts even when our device is disabled, and the driver does not handle this. To avoid adding such code, and to be sure the driver won't accidentally be used in a platform with shared interrupts, let's drop the IRQF_SHARED flag. Link: https://lore.kernel.org/r/20231207-rkisp-irq-fix-v3-1-358a2c871a3c@ideasonboard.com Tested-by: Adam Ford #imx8mp-beacon Signed-off-by: Tomi Valkeinen Signed-off-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c index f2475c6235ea..e2352a056098 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c @@ -542,7 +542,7 @@ static int rkisp1_probe(struct platform_device *pdev) if (irq < 0) return irq; - ret = devm_request_irq(dev, irq, info->isrs[i].isr, IRQF_SHARED, + ret = devm_request_irq(dev, irq, info->isrs[i].isr, 0, dev_driver_string(dev), dev); if (ret) { dev_err(dev, "request irq failed: %d\n", ret); -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D49C82D7B; Mon, 22 Jan 2024 15:10:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705936251; cv=none; b=RDNHsvimb8szBk60qZ7B1FgKFbhWmwu7vwggrCEVk8Zx4ifhrALzcLxx82ARnTU2j3TaX6YonyBBEU/vA4RYbGusyFlygQvtWA3aFcbfWq4gNTygwEr50cmeP+usEVxb5hYoHslcRAxhAMTRYNeXpTsJW8zK2/IvekDxmnfF04M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705936251; c=relaxed/simple; bh=5Dj8hag1O8UvRbU2sBKR41iqeOAf9gS1ldGtg4l3puI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=diqhlrUIB2nPs3hYz/VXKV9YD3Fj3ZdLcj76Xa/kxEbkITQWirSqMa6Cvbc1PEAdqPFnvrjIQ/qG7DJWpEqYsiunn+7QtR+foLdRgDFzIJ30pRN5y4xYIAXylft4wgO4A0UjA9qkCic3++zD+yB9ikycdhN/AF3rnV6Oiln/5Ek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qpdyXTZ6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qpdyXTZ6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BD6EC433F1; Mon, 22 Jan 2024 15:10:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705936251; bh=5Dj8hag1O8UvRbU2sBKR41iqeOAf9gS1ldGtg4l3puI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qpdyXTZ6Ebdc7lFfLyt/UDMx0O5Wb202loKRM5DcfzV0mWImWBKwtBUEyPVlTNDHu lV67Jg/ad51Ds9RhbxgyCm1ntguzY8yLoL6gaDcTn97qETHtTK0/yOoYwQB9DQuP4r LjZBTthrHLtW9t30FKveklT9SGPIAc1o/FenF0gscErLChCbYDvXyVT/xhDa+LzeYU ULiurS8efeaMCONltMcjZVUGx3MLhf4CUasEpZV6RdgGoXq6EB+Bvvfo/URsj990VL dfK8FHY4igs/WDjZC+1JesTczWblRWYlG/bIJdIoq+gWc6U26/DfN83ozMQ3i+lF7Y HV1AW5QX6uRow== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tomi Valkeinen , Adam Ford , Laurent Pinchart , Mauro Carvalho Chehab , Sasha Levin , dafna@fastmail.com, heiko@sntech.de, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.1 23/53] media: rkisp1: Drop IRQF_SHARED Date: Mon, 22 Jan 2024 10:08:24 -0500 Message-ID: <20240122150949.994249-23-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122150949.994249-1-sashal@kernel.org> References: <20240122150949.994249-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.74 Content-Transfer-Encoding: 8bit From: Tomi Valkeinen [ Upstream commit 85d2a31fe4d9be1555f621ead7a520d8791e0f74 ] In all known platforms the ISP has dedicated IRQ lines, but for some reason the driver uses IRQF_SHARED. Supporting IRQF_SHARED properly requires handling interrupts even when our device is disabled, and the driver does not handle this. To avoid adding such code, and to be sure the driver won't accidentally be used in a platform with shared interrupts, let's drop the IRQF_SHARED flag. Link: https://lore.kernel.org/r/20231207-rkisp-irq-fix-v3-1-358a2c871a3c@ideasonboard.com Tested-by: Adam Ford #imx8mp-beacon Signed-off-by: Tomi Valkeinen Signed-off-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c index f2475c6235ea..e2352a056098 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c @@ -542,7 +542,7 @@ static int rkisp1_probe(struct platform_device *pdev) if (irq < 0) return irq; - ret = devm_request_irq(dev, irq, info->isrs[i].isr, IRQF_SHARED, + ret = devm_request_irq(dev, irq, info->isrs[i].isr, 0, dev_driver_string(dev), dev); if (ret) { dev_err(dev, "request irq failed: %d\n", ret); -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 790BFC47DDB for ; Mon, 22 Jan 2024 15:11:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PvgACTfKYvBFeotfs4yHLanIYpPoKosFTgJD6+F5QvI=; b=TBjM4CsyuIOEzm AS31kxtwfZNUV1DHiXMajPTaTAgPHxUjm5jNCLKMRnaf766OfoISEIAY/QYblnKKNbSQbXPZBLRnB QE3rS7dv8Dsd3qS2o4YHQffodzTUKpPyqvh3DOoWoEPwjk/UBHcFlWQVk1CU4PT3EoU4W0YQ5zIUf P1xAzqYGu/qnoECiytBK2+61swT4G16tjvTD51b2CrBVCvYMw/SqhEwyKVSApbr51xfYu4WMk1vbR dax6gfOZ1uQy67itVxlHMuQ7lqnu9emQfclIimxGBzFvPlc+mpKn1ygGvOW17Sn1gK7eNnz2OpuvL QeFukmgsZPQW5PP0mC7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rRvwx-00Cc9U-08; Mon, 22 Jan 2024 15:10:59 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rRvwq-00Cc39-23; Mon, 22 Jan 2024 15:10:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 47ECBB80E87; Mon, 22 Jan 2024 15:10:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BD6EC433F1; Mon, 22 Jan 2024 15:10:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705936251; bh=5Dj8hag1O8UvRbU2sBKR41iqeOAf9gS1ldGtg4l3puI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qpdyXTZ6Ebdc7lFfLyt/UDMx0O5Wb202loKRM5DcfzV0mWImWBKwtBUEyPVlTNDHu lV67Jg/ad51Ds9RhbxgyCm1ntguzY8yLoL6gaDcTn97qETHtTK0/yOoYwQB9DQuP4r LjZBTthrHLtW9t30FKveklT9SGPIAc1o/FenF0gscErLChCbYDvXyVT/xhDa+LzeYU ULiurS8efeaMCONltMcjZVUGx3MLhf4CUasEpZV6RdgGoXq6EB+Bvvfo/URsj990VL dfK8FHY4igs/WDjZC+1JesTczWblRWYlG/bIJdIoq+gWc6U26/DfN83ozMQ3i+lF7Y HV1AW5QX6uRow== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tomi Valkeinen , Adam Ford , Laurent Pinchart , Mauro Carvalho Chehab , Sasha Levin , dafna@fastmail.com, heiko@sntech.de, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.1 23/53] media: rkisp1: Drop IRQF_SHARED Date: Mon, 22 Jan 2024 10:08:24 -0500 Message-ID: <20240122150949.994249-23-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122150949.994249-1-sashal@kernel.org> References: <20240122150949.994249-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.74 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240122_071052_817696_664CF8D9 X-CRM114-Status: GOOD ( 12.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Tomi Valkeinen [ Upstream commit 85d2a31fe4d9be1555f621ead7a520d8791e0f74 ] In all known platforms the ISP has dedicated IRQ lines, but for some reason the driver uses IRQF_SHARED. Supporting IRQF_SHARED properly requires handling interrupts even when our device is disabled, and the driver does not handle this. To avoid adding such code, and to be sure the driver won't accidentally be used in a platform with shared interrupts, let's drop the IRQF_SHARED flag. Link: https://lore.kernel.org/r/20231207-rkisp-irq-fix-v3-1-358a2c871a3c@ideasonboard.com Tested-by: Adam Ford #imx8mp-beacon Signed-off-by: Tomi Valkeinen Signed-off-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c index f2475c6235ea..e2352a056098 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c @@ -542,7 +542,7 @@ static int rkisp1_probe(struct platform_device *pdev) if (irq < 0) return irq; - ret = devm_request_irq(dev, irq, info->isrs[i].isr, IRQF_SHARED, + ret = devm_request_irq(dev, irq, info->isrs[i].isr, 0, dev_driver_string(dev), dev); if (ret) { dev_err(dev, "request irq failed: %d\n", ret); -- 2.43.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel