From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1BA24CB3F for ; Mon, 22 Jan 2024 17:50:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705945837; cv=none; b=MgyGuWh2WSmpnaCig6OYmpO744fgvHW2yypz4PTpCbX0KjR2HdWHtDfG3zOAiMP07Aa2wsBML4Dhf3dFwrfTldIg4dhTqcHI5GYnqsfrBbrVn/qKzRn1iXpP31fDBveYqOv+blhnNwgHfaZIgH8TfIDsk4KIaMZHFz4x3PLfdk0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705945837; c=relaxed/simple; bh=xLPMMOi9U5aA2QOUyNYRwdev7zD4A+KnUqD+T4+EA/Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K4B589bBKi5jJz4OnS0cpIayZ77SyGxsnL3D3MUkTWc1z7sXywTuR4MPyHnZzXO5nmweq/0+zC+S7QjOZQG6Ln/lmlocNAonEcsoJXcP6IP/otCopF3dHrnGSuGylOhH1i5VpO0KJ7pGEwb87PqZOinkpcfiARC9xMeXhOA9kWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=F3SK6Tjl; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F3SK6Tjl" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-339208f5105so3004913f8f.1 for ; Mon, 22 Jan 2024 09:50:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705945834; x=1706550634; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=sYGuiuUN/VCPpW9oWOQ4p73+grZOykVwihNpjjDuv0Q=; b=F3SK6TjlNfQnBS4iXAAc0b9u8u04WFz0BR17agbw8LPd7czINCOtAvlubBLCcdN8SN Iptkxj8v2kLA1hD8xExxhw//T+icNkTpoyiLV3tbzGANVQY8vtzflRJ4r49vQ/iL+d/C T2e6K3UOUeJl3D94hie4a2pHfJb0Lp+CWygjk7wPIWElGw2A0AZMOntSoFSLLEXc9IVc LPDmA5F2W5g9kOfjmr+DYpXc9hKbpTnEN5jQ649bqx64YApBYnLYKZBdI/3OFrstB2jA HJgRegE0xklM7YWjyHkSVYILVlofiME+Pzn1sqc4YipxIbM57oRgigJtixgInp/J21m4 vVnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705945834; x=1706550634; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sYGuiuUN/VCPpW9oWOQ4p73+grZOykVwihNpjjDuv0Q=; b=dnL9Rmo00hm9MvfOc5OS6oG4T64eCmKnN3vCfT2dLq9tp6EglwHEzr+zgTqgHv6x6m i6B0I1vnE7itXEPyfWlMLdfmEW+cQVn0DKQs/k6y2Jc+z3sqhGICcl+Dc87hnbNmoMwi WIm/NQZq/ZP3mBQEupXIQtwGcfZ0baf6wvKjJLE9WTJKXuNe8S5RKK/E9qVSzccWtHu/ +ypf3YgmziyJur4HcoPGoQG6QECxkgpFMxuOb1FIyO8NgWNaapBwmcf3Il6jTegeEyt4 7z0rBGZ7tgkr9/nNaQaRSTuXyU6QUJC66ux67s/dLgW3DvIajRjVxlP3CLcorozMPC2k oSbA== X-Gm-Message-State: AOJu0YyfYdgV4QMO87PsuPVUAVCtZFxupnlc6K1m5svfa7x7PGuCO/Y+ 4+cpSNgU6NU+FYYsm2e6fv5Mk+7dZhQZGyF43Es4mexJK+8YQ7haaB3X5ABdL94= X-Google-Smtp-Source: AGHT+IGMKjXfBPPqRjfBziR7QI5pQ0EzWnQZly3+fsLmJWUOsG/MDJPaYvuxqQs8u+NniIHlytAXNQ== X-Received: by 2002:adf:a199:0:b0:337:bdf2:26fe with SMTP id u25-20020adfa199000000b00337bdf226femr2086857wru.161.1705945834114; Mon, 22 Jan 2024 09:50:34 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id s15-20020a5d6a8f000000b00336898daceasm11996072wru.96.2024.01.22.09.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 09:50:33 -0800 (PST) Date: Mon, 22 Jan 2024 17:50:31 +0000 From: Daniel Thompson To: Duje =?utf-8?Q?Mihanovi=C4=87?= Cc: Lee Jones , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Linus Walleij , Karel Balej , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library Message-ID: <20240122175031.GC8815@aspen.lan> References: <20240120-ktd2801-v3-0-fe2cbafffb21@skole.hr> <20240122165011.GA8815@aspen.lan> <23373359.6Emhk5qWAg@radijator> <3603320.R56niFO833@radijator> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3603320.R56niFO833@radijator> On Mon, Jan 22, 2024 at 06:26:04PM +0100, Duje Mihanović wrote: > On Monday, January 22, 2024 5:57:53 PM CET Duje Mihanović wrote: > > On Monday, January 22, 2024 5:50:11 PM CET Daniel Thompson wrote: > > > AFAICT nothing will inhibit setting GPIOLIB so allyes- and allmodconfig > > > builds will always end up with GPIOLIB enabled. If we are happy to > > > select it then I think that is enough! > > > > In that case I guess I'll just make it select GPIOLIB. > > Nevermind that, it'll have to be 'depends on' after all: > > drivers/gpio/Kconfig:6:error: recursive dependency detected! > drivers/gpio/Kconfig:6: symbol GPIOLIB is selected by LEDS_EXPRESSWIRE > drivers/leds/Kconfig:184: symbol LEDS_EXPRESSWIRE depends on NEW_LEDS Can this dependency could be broken by declaring LEDS_EXPRESSWIRE at the top (or bottom) of the KConfig file (it's an option without a UI and does not need to be within the if NEW_LEDS block). I'm aware this kind of change could provoke an argument about which sub-system the expresswire code should live in... but I think it's a worthwhile change anyway! We shouldn't need NEW_LEDS for this. Daniel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C36BC47DAF for ; Mon, 22 Jan 2024 17:51:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D524810ED73; Mon, 22 Jan 2024 17:51:36 +0000 (UTC) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id A787310ED73 for ; Mon, 22 Jan 2024 17:51:35 +0000 (UTC) Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-337b8da1f49so3109364f8f.0 for ; Mon, 22 Jan 2024 09:51:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705945834; x=1706550634; darn=lists.freedesktop.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=sYGuiuUN/VCPpW9oWOQ4p73+grZOykVwihNpjjDuv0Q=; b=xofAnwLSgh3tw/yQOmzbQjWfTMLIgmeBlKUhAWIYqmt8CRPwY9OJUxUryBGVhGbkdg PQ8PwvGDz56VPYkuhF+K+ObLlWQQavNMTesgb4cGQnL3Z7vhdhWkHA7VzfpZoIgKfv4n oeXxBxjMHpK5Zova4LF66Yv1Kc+QStbtjs6+zGoCEAi3uhffMQbyr/HppzkAN0NYQbAD Qc0vBAEehwMVBYtIfNKVzq8mC4Kwrx6pveGKJXXCiqaLUj23Pce5Rahvyu2PsN/wtNoU Ay7HcLF+ZIljhoA/PFcsQ8CY/YPk7T1TlMyEp0I/oAAmME7c8MTwmB6GgFRD5aJtZpq5 +PjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705945834; x=1706550634; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sYGuiuUN/VCPpW9oWOQ4p73+grZOykVwihNpjjDuv0Q=; b=EIda+9PFP4tSin1UoTK4EhXqU773Ceitp2JJ3u0U8ld9D/vFEcIYNRFX2ViRZBchgQ 6Q6FZblGQ9sG2aUY6odf2efLdou0dk7lFADIjoSX5FAoo/hclf++lKyKW45tqsZ2f1mZ 123Ki0iQ63VVhK1D/vJ9S8ywlzRo30tfvkHDb/H/cSRqd21v7iabnL2C0c1lD+AHtO+o PaGQ9ord8YKVMQ7enHKS28QNrygdRUyA3Ahzm5iFvkuEwLWSJ2DvGjOBP8W0yjqZKYew 5eMnUlDrWN9hHhPNb0WG12h1D22x8w/xjkQ3QNkIXOidJCdRRiGm+AspJfPF6RpdN4ts 2/UA== X-Gm-Message-State: AOJu0Yypb9LRjjN8iLMb2PBZdtL0zjJjbFSWGTKvOptFJEDSX8AeJvZ8 B/H8WPn3vL/1AW2QSX8eLC06FtNVrGSEUEFFWWuq6fXzDVkmrKcwhczvK/IrFmc= X-Google-Smtp-Source: AGHT+IGMKjXfBPPqRjfBziR7QI5pQ0EzWnQZly3+fsLmJWUOsG/MDJPaYvuxqQs8u+NniIHlytAXNQ== X-Received: by 2002:adf:a199:0:b0:337:bdf2:26fe with SMTP id u25-20020adfa199000000b00337bdf226femr2086857wru.161.1705945834114; Mon, 22 Jan 2024 09:50:34 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id s15-20020a5d6a8f000000b00336898daceasm11996072wru.96.2024.01.22.09.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 09:50:33 -0800 (PST) Date: Mon, 22 Jan 2024 17:50:31 +0000 From: Daniel Thompson To: Duje =?utf-8?Q?Mihanovi=C4=87?= Subject: Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library Message-ID: <20240122175031.GC8815@aspen.lan> References: <20240120-ktd2801-v3-0-fe2cbafffb21@skole.hr> <20240122165011.GA8815@aspen.lan> <23373359.6Emhk5qWAg@radijator> <3603320.R56niFO833@radijator> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3603320.R56niFO833@radijator> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Conor Dooley , Pavel Machek , Jingoo Han , Helge Deller , Lee Jones , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Karel Balej , linux-fbdev@vger.kernel.org, Rob Herring , ~postmarketos/upstreaming@lists.sr.ht, Krzysztof Kozlowski , phone-devel@vger.kernel.org, linux-leds@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jan 22, 2024 at 06:26:04PM +0100, Duje Mihanović wrote: > On Monday, January 22, 2024 5:57:53 PM CET Duje Mihanović wrote: > > On Monday, January 22, 2024 5:50:11 PM CET Daniel Thompson wrote: > > > AFAICT nothing will inhibit setting GPIOLIB so allyes- and allmodconfig > > > builds will always end up with GPIOLIB enabled. If we are happy to > > > select it then I think that is enough! > > > > In that case I guess I'll just make it select GPIOLIB. > > Nevermind that, it'll have to be 'depends on' after all: > > drivers/gpio/Kconfig:6:error: recursive dependency detected! > drivers/gpio/Kconfig:6: symbol GPIOLIB is selected by LEDS_EXPRESSWIRE > drivers/leds/Kconfig:184: symbol LEDS_EXPRESSWIRE depends on NEW_LEDS Can this dependency could be broken by declaring LEDS_EXPRESSWIRE at the top (or bottom) of the KConfig file (it's an option without a UI and does not need to be within the if NEW_LEDS block). I'm aware this kind of change could provoke an argument about which sub-system the expresswire code should live in... but I think it's a worthwhile change anyway! We shouldn't need NEW_LEDS for this. Daniel.