From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07D445683; Tue, 23 Jan 2024 00:06:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705968401; cv=none; b=Cv3VWg6O12k4xkJAqVJ7y3jIgmuCrHKBtxdJpuRQuQzjcTWxYJ0NdjHs9DAuAcFlo0WRzlbMkcKPcy+veKj/xb3VGRKSGAO3lG0fPfT8BZco6Sfmp0b44mOfg58XXl58MY7SwFKkJuytuCVtF7FnDN9h3jPYogv2vqAsfvIJe0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705968401; c=relaxed/simple; bh=lK8RlYXVJdrIjT3u6bDIhlo/8OzCnG/rGme3cw331OU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RlPv8U775jBVsCWFbUsTYiHl5lZfjQLBz0LwKiyEYEca+MPhmqqqdA3qek2VACpIYXIEmKjr17+Fr9e3EDAFxq14dxT1+8SySEm42pk9UnvRabzhdLbUIQFjNbUhUfCqAOXhhiRIT8yJfU+dY6jJtAGXcsonEfG1G5er1rGdlAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IAd0307F; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IAd0307F" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D38BC433F1; Tue, 23 Jan 2024 00:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705968400; bh=lK8RlYXVJdrIjT3u6bDIhlo/8OzCnG/rGme3cw331OU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IAd0307FYco4H1U3y0KR7qiag3SwMA5ZUQoRJVTZrwzCNAX/73AiPbLSYnmVPqEfH 2yFQlkirqv/ZGAha3XDGXeKvvcInPtNR7Hh95OlmCJ64YHRG9DUtXJ3/bpSX5Zq5qG jz2d51nOcstr8cWQlSaeIh7GSDxFh+bgGrUJlvnw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+3eff5e51bf1db122a16e@syzkaller.appspotmail.com, Chengming Zhou , Barry Song , Herbert Xu , Sasha Levin Subject: [PATCH 4.19 061/148] crypto: scomp - fix req->dst buffer overflow Date: Mon, 22 Jan 2024 15:56:57 -0800 Message-ID: <20240122235714.878918816@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122235712.442097787@linuxfoundation.org> References: <20240122235712.442097787@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chengming Zhou [ Upstream commit 744e1885922a9943458954cfea917b31064b4131 ] The req->dst buffer size should be checked before copying from the scomp_scratch->dst to avoid req->dst buffer overflow problem. Fixes: 1ab53a77b772 ("crypto: acomp - add driver-side scomp interface") Reported-by: syzbot+3eff5e51bf1db122a16e@syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/0000000000000b05cd060d6b5511@google.com/ Signed-off-by: Chengming Zhou Reviewed-by: Barry Song Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- crypto/scompress.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/crypto/scompress.c b/crypto/scompress.c index 3702f1648ea8..34174f55a6d6 100644 --- a/crypto/scompress.c +++ b/crypto/scompress.c @@ -132,6 +132,7 @@ static int scomp_acomp_comp_decomp(struct acomp_req *req, int dir) struct crypto_scomp *scomp = *tfm_ctx; void **ctx = acomp_request_ctx(req); struct scomp_scratch *scratch; + unsigned int dlen; int ret; if (!req->src || !req->slen || req->slen > SCOMP_SCRATCH_SIZE) @@ -143,6 +144,8 @@ static int scomp_acomp_comp_decomp(struct acomp_req *req, int dir) if (!req->dlen || req->dlen > SCOMP_SCRATCH_SIZE) req->dlen = SCOMP_SCRATCH_SIZE; + dlen = req->dlen; + scratch = raw_cpu_ptr(&scomp_scratch); spin_lock(&scratch->lock); @@ -160,6 +163,9 @@ static int scomp_acomp_comp_decomp(struct acomp_req *req, int dir) ret = -ENOMEM; goto out; } + } else if (req->dlen > dlen) { + ret = -ENOSPC; + goto out; } scatterwalk_map_and_copy(scratch->dst, req->dst, 0, req->dlen, 1); -- 2.43.0