From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A26AF5A7B8; Tue, 23 Jan 2024 01:45:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705974335; cv=none; b=SBFe4eJGuzPaTehQ9IXuYOuUsIiF+chrRNSqmNS3qbCiG158Y4Vn0jsdKxoECCPSQtACJ3d+yoNO+XBF6CsXDVotnzR+8o77KNMyUsjccEN+K1kwS7NgA2MaQvI5tF0Z9u3gSSV8+pIbDF4BLPhuvzyynKs2Pn/NxOJlq79+W2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705974335; c=relaxed/simple; bh=zYeArFZBZ3bSCaMvuRu9P4VvKnEo+8DONmRGslT1YFA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EWIZipbCDWoyslFKL6LHrAXDGV2/ldhmdfMcxi7ZK2GBc83rUC1F9cvFLSGWWve0mtE5Lz2naf/wRoSJan+im0K7MAbKMQdvLPuFNP3P0yO7osZ8lpqB4NPkJhY/2dGWcBA+1WBRFKJjUO4uGkeZ2PUeZDmjHRjtpX6EWNKscWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=kdmIU3B/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kdmIU3B/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4690AC433C7; Tue, 23 Jan 2024 01:45:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705974335; bh=zYeArFZBZ3bSCaMvuRu9P4VvKnEo+8DONmRGslT1YFA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kdmIU3B/o6ZH8XfwWfgi8PzutzY1hRCSObB2GCUIfCw8+vLzkrxzF5x0AhQ5VYxan lULw7ohpQ3iKBsxpIxQp8lk9MIF/D+Y2rp9sohcvfHDBL2TPoaxZ0V+2e6HkuhzTyQ wC3VhI3HEUh6UawoBk6I+wyTzx6pW3kFUgF5mgZE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chris Morgan , Jessica Zhang , Neil Armstrong , Sasha Levin Subject: [PATCH 5.15 180/374] drm/panel-elida-kd35t133: hold panel in reset for unprepare Date: Mon, 22 Jan 2024 15:57:16 -0800 Message-ID: <20240122235750.899598763@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122235744.598274724@linuxfoundation.org> References: <20240122235744.598274724@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chris Morgan [ Upstream commit 03c5b2a5f6c39fe4e090346536cf1c14ee18b61e ] For devices like the Anbernic RG351M and RG351P the panel is wired to an always on regulator. When the device suspends and wakes up, there are some slight artifacts on the screen that go away over time. If instead we hold the panel in reset status after it is unprepared, this does not happen. Fixes: 5b6603360c12 ("drm/panel: add panel driver for Elida KD35T133 panels") Signed-off-by: Chris Morgan Reviewed-by: Jessica Zhang Link: https://lore.kernel.org/r/20231117194405.1386265-3-macroalpha82@gmail.com Signed-off-by: Neil Armstrong Link: https://patchwork.freedesktop.org/patch/msgid/20231117194405.1386265-3-macroalpha82@gmail.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/panel/panel-elida-kd35t133.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-elida-kd35t133.c b/drivers/gpu/drm/panel/panel-elida-kd35t133.c index 80227617a4d6..ccb7d521f30a 100644 --- a/drivers/gpu/drm/panel/panel-elida-kd35t133.c +++ b/drivers/gpu/drm/panel/panel-elida-kd35t133.c @@ -112,6 +112,8 @@ static int kd35t133_unprepare(struct drm_panel *panel) return ret; } + gpiod_set_value_cansleep(ctx->reset_gpio, 1); + regulator_disable(ctx->iovcc); regulator_disable(ctx->vdd); -- 2.43.0