From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18E5662800; Tue, 23 Jan 2024 00:51:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705971110; cv=none; b=AtH8d8jt62vC/xrwkApQSqdUQi89pkAW9wzboRrTqVDgG4x6iMfxaUMF+HplAxZYQ6EtI8x0Jr5f+9FKq/OF0hEy+P2QjvkxEQVVDrNcdHOS8nRCtaav7Vdb1JHysOPCWeYb0R/ObYOZsw8/qbJaT6fxvV9A8pfLZK45Q7Xk0Gs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705971110; c=relaxed/simple; bh=C6Wmht93B6zvxvZlVLhW6jaimtIrVuq2sSiOBaG9P7U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QvVm1Rwxqouyv08CMtJPlxy3753el7ovKHFtkOmw/tyUZ2JOEIbQZ2m7RYonDgR6JYPp1v3MEE5tqdYiNqdMNDMqARaiLRT2dwlYmBXhxHDxStktp8nY2wkjokPkCONrD3AAnc65NgIjI0yZsIjlJtxwxAiJkmJWCh9xgE6bbsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=qFAknlBl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="qFAknlBl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE78AC43390; Tue, 23 Jan 2024 00:51:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705971109; bh=C6Wmht93B6zvxvZlVLhW6jaimtIrVuq2sSiOBaG9P7U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qFAknlBlpDCk2q+wgNdEkj8aL0TTEqPZFwXQHsyxN4CceCIvIA9R0qRhEiacxEaW5 agbGFJiLykRYIf4HUuB8ikUrDDttDCImX4Bh1otGmlXycuMjoL80FfB0wtmCdxduex JaE5JZNb8PlC9Op9Y801pED6niroL25Hryns4QIw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Konrad Dybcio , Dmitry Baryshkov , Sasha Levin Subject: [PATCH 6.1 182/417] drm/msm/dsi: Use pm_runtime_resume_and_get to prevent refcnt leaks Date: Mon, 22 Jan 2024 15:55:50 -0800 Message-ID: <20240122235758.177336268@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122235751.480367507@linuxfoundation.org> References: <20240122235751.480367507@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Konrad Dybcio [ Upstream commit 3d07a411b4faaf2b498760ccf12888f8de529de0 ] This helper has been introduced to avoid programmer errors (missing _put calls leading to dangling refcnt) when using pm_runtime_get, use it. While at it, start checking the return value. Signed-off-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov Fixes: 5c8290284402 ("drm/msm/dsi: Split PHY drivers to separate files") Patchwork: https://patchwork.freedesktop.org/patch/543350/ Link: https://lore.kernel.org/r/20230620-topic-dsiphy_rpm-v2-1-a11a751f34f0@linaro.org Signed-off-by: Dmitry Baryshkov Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c index 7fc0975cb869..62bc3756f2e2 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c @@ -512,7 +512,9 @@ static int dsi_phy_enable_resource(struct msm_dsi_phy *phy) struct device *dev = &phy->pdev->dev; int ret; - pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); + if (ret) + return ret; ret = clk_prepare_enable(phy->ahb_clk); if (ret) { -- 2.43.0