From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF45E12CDB7; Tue, 23 Jan 2024 00:58:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705971485; cv=none; b=JnubScalgK/+tbq/KM9gB3k5vGcuXOEssqV5WTzWGEVXiK5ryWD//y14lTbgjQpU5+mrUQZBhSTt3uRuXZe/jmEFr526mRLa5LsF5ZeUi5i7bMTih9KCsK9ZwMxBRNuhvyYk1w+cN15qduWRK86k7J8qLcjpAgl2HJdu7ackCZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705971485; c=relaxed/simple; bh=IXZat+ICceP8js8QlRcXyIRc5P48P3xXZt9V1q2Sh5A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=an2v9crForUkNGslvIcwxiWukaiOnFbVMv/iiB0V6MXU5oYms6NNN1pZ6jMqSHvUAY/txrZDe8tRXOgreez232Wcc6qtJWMhlfvForqDxO1jOVUnVvKGMGHRWviXkspej3gKxavC0lrFSSrpR26dAr7YQBh8hQJvYzHD+n0mlwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AfA9MD77; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AfA9MD77" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBE59C433C7; Tue, 23 Jan 2024 00:58:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705971484; bh=IXZat+ICceP8js8QlRcXyIRc5P48P3xXZt9V1q2Sh5A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AfA9MD77ArGqTxkofL0rBAN9WcctFv8pV3523JS4aybT0KXxpY5wF7zc2xvI7HcsD wPM8sMHSbO3v6qGC+h5r3uh4npneCuLvAcPom2qxqPOtghufCn6GEv44L2mh7/5T0p UspCWefqJklq6g4wTaZmDLZQhytQmwAszp2LSjTI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alice Ryhl , Carlos Llamas Subject: [PATCH 6.1 250/417] binder: fix async space check for 0-sized buffers Date: Mon, 22 Jan 2024 15:56:58 -0800 Message-ID: <20240122235800.535725245@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122235751.480367507@linuxfoundation.org> References: <20240122235751.480367507@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Carlos Llamas commit 3091c21d3e9322428691ce0b7a0cfa9c0b239eeb upstream. Move the padding of 0-sized buffers to an earlier stage to account for this round up during the alloc->free_async_space check. Fixes: 74310e06be4d ("android: binder: Move buffer out of area shared with user space") Reviewed-by: Alice Ryhl Signed-off-by: Carlos Llamas Link: https://lore.kernel.org/r/20231201172212.1813387-5-cmllamas@google.com Signed-off-by: Greg Kroah-Hartman --- drivers/android/binder_alloc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/drivers/android/binder_alloc.c +++ b/drivers/android/binder_alloc.c @@ -407,6 +407,10 @@ static struct binder_buffer *binder_allo alloc->pid, extra_buffers_size); return ERR_PTR(-EINVAL); } + + /* Pad 0-size buffers so they get assigned unique addresses */ + size = max(size, sizeof(void *)); + if (is_async && alloc->free_async_space < size + sizeof(struct binder_buffer)) { binder_alloc_debug(BINDER_DEBUG_BUFFER_ALLOC, @@ -415,9 +419,6 @@ static struct binder_buffer *binder_allo return ERR_PTR(-ENOSPC); } - /* Pad 0-size buffers so they get assigned unique addresses */ - size = max(size, sizeof(void *)); - while (n) { buffer = rb_entry(n, struct binder_buffer, rb_node); BUG_ON(!buffer->free);