From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0E23380; Tue, 23 Jan 2024 02:09:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705975748; cv=none; b=g5wfhUJix6xZK39zeJE6HZE8g3UajgJCrRQn1yUKos+I7rr0FfB7bKC+tFf+ghnEwOSH4PEX8whiMkoosK4Aw5Bt1JF1WhIAaBSvlF0gsRfCMOoT5O91MFyVJ1Gi27mRfwIhlPi6MlfRCyotZfH2Yu1HosQm051VAt6us8m9fvY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705975748; c=relaxed/simple; bh=ZtiaL2c9VafxhUDBIT9RH57t6VA1FhD4RfgmGarQE0U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bFsm2OGHWxTTvbFvSpuAaIUMapvETk0EmLXIEv8mN10lZs09e13oBd6ev7km0+JF6YYzOJf0zuEZ2dFDuV74UFUNoKXHuj8/NLKSod51Cs63obvNsyCPT56CVVAzLjbDizJvQykOwKb6UOGYeYnGyWDVEbaov/7706sO5RfA5vM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=latd46+m; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="latd46+m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 615F1C43399; Tue, 23 Jan 2024 02:09:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705975748; bh=ZtiaL2c9VafxhUDBIT9RH57t6VA1FhD4RfgmGarQE0U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=latd46+mCHhzgHI62VeqvlygYxXGxOApA+0Qm4himIW6LloxQ8Ls8d8qqX1gSLztw 3nOs0DNPW1eFPxO/jWZ8kv7TPwUeSviUGqdd0PaNVEulpf8pSy/7kg7OckulD6zYu/ WJCUT3I8AZJmdz9LjL+4XRmZ4dbAlMJ2t1XYQEmA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Eric Dumazet , Florian Westphal , Peter Krystad , Matthieu Baerts , Mat Martineau , Geliang Tang , Simon Horman , Paolo Abeni , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.6 533/583] mptcp: strict validation before using mp_opt->hmac Date: Mon, 22 Jan 2024 15:59:44 -0800 Message-ID: <20240122235828.423970382@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122235812.238724226@linuxfoundation.org> References: <20240122235812.238724226@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit c1665273bdc7c201766c65e561c06711f2e050dc ] mp_opt->hmac contains uninitialized data unless OPTION_MPTCP_MPJ_ACK was set in mptcp_parse_option(). We must refine the condition before we call subflow_hmac_valid(). Fixes: f296234c98a8 ("mptcp: Add handling of incoming MP_JOIN requests") Signed-off-by: Eric Dumazet Cc: Florian Westphal Cc: Peter Krystad Cc: Matthieu Baerts Cc: Mat Martineau Cc: Geliang Tang Reviewed-by: Simon Horman Acked-by: Paolo Abeni Reviewed-by: Mat Martineau Link: https://lore.kernel.org/r/20240111194917.4044654-3-edumazet@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/mptcp/subflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c index 45b8115b363b..d6ee0e52ea41 100644 --- a/net/mptcp/subflow.c +++ b/net/mptcp/subflow.c @@ -788,7 +788,7 @@ static struct sock *subflow_syn_recv_sock(const struct sock *sk, } else if (subflow_req->mp_join) { mptcp_get_options(skb, &mp_opt); - if (!(mp_opt.suboptions & OPTIONS_MPTCP_MPJ) || + if (!(mp_opt.suboptions & OPTION_MPTCP_MPJ_ACK) || !subflow_hmac_valid(req, &mp_opt) || !mptcp_can_accept_new_subflow(subflow_req->msk)) { SUBFLOW_REQ_INC_STATS(req, MPTCP_MIB_JOINACKMAC); -- 2.43.0