From: Conor Dooley <conor@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Seven Lee <wtli@nuvoton.com>,
lgirdwood@gmail.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, conor+dt@kernel.org, YHCHuang@nuvoton.com,
KCHSU0@nuvoton.com, CTLIN0@nuvoton.com, SJLIN0@nuvoton.com,
scott6986@gmail.com, supercraig0719@gmail.com,
dardar923@gmail.com
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: Added schema for "nuvoton,nau8325"
Date: Tue, 23 Jan 2024 08:34:03 +0000 [thread overview]
Message-ID: <20240123-bottle-elevating-9fbba5424014@spud> (raw)
In-Reply-To: <04945799-eded-42f9-b8fa-8907be44c400@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
On Mon, Jan 22, 2024 at 07:40:51PM +0000, Mark Brown wrote:
> On Mon, Jan 22, 2024 at 06:00:14PM +0000, Conor Dooley wrote:
> > On Mon, Jan 22, 2024 at 05:56:49PM +0800, Seven Lee wrote:
>
> > > + enum:
> > > + - 0 # VDDA
> > > + - 1 # VDDA*1.5/1.8V
> > > + - 2 # VDDA*1.6/1.8V
> > > + - 3 # VDDA*1.7/1.8V
>
> > I would also rather than this enum was used to have sensible values for
> > the enum itself (which I suppose means strings here), rather than the
> > register values. Seeing "nuvoton,dac-vref = <2>" in a devicetree is not
> > very meaningful IMO.
>
> Do you have a concrete suggestion for how to more clearly write these
> directly?
I would use what's been given as the explanation comments for each of
the current enum values in the patch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-01-23 8:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 9:56 [PATCH 1/2] ASoC: dt-bindings: Added schema for "nuvoton,nau8325" Seven Lee
2024-01-22 9:56 ` [PATCH 2/2] ASoC: nau8325: new driver Seven Lee
2024-01-22 20:28 ` Mark Brown
2024-02-02 9:50 ` AS50 WTLi
2024-01-22 18:00 ` [PATCH 1/2] ASoC: dt-bindings: Added schema for "nuvoton,nau8325" Conor Dooley
2024-01-22 19:40 ` Mark Brown
2024-01-23 8:34 ` Conor Dooley [this message]
2024-01-23 13:06 ` Mark Brown
2024-01-23 16:02 ` Conor Dooley
2024-02-02 10:04 ` AS50 WTLi
2024-02-02 16:34 ` Conor Dooley
2024-02-02 16:36 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240123-bottle-elevating-9fbba5424014@spud \
--to=conor@kernel.org \
--cc=CTLIN0@nuvoton.com \
--cc=KCHSU0@nuvoton.com \
--cc=SJLIN0@nuvoton.com \
--cc=YHCHuang@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dardar923@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=scott6986@gmail.com \
--cc=supercraig0719@gmail.com \
--cc=wtli@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.