Re: + crash-remove-dependency-of-fa_dump-on-crash_dump.patch added to mm-unstable branch

[SeongJae Park <sj@kernel.org>]

Hi Andrew,

On Mon, 22 Jan 2024 16:44:00 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:

> 
> The patch titled
>      Subject: crash: remove dependency of FA_DUMP on CRASH_DUMP
> has been added to the -mm mm-unstable branch.  Its filename is
>      crash-remove-dependency-of-fa_dump-on-crash_dump.patch
[...]
> 
> ------------------------------------------------------
> From: Baoquan He <bhe@redhat.com>
> Subject: crash: remove dependency of FA_DUMP on CRASH_DUMP
> Date: Fri, 19 Jan 2024 22:52:30 +0800
> 
[...]
> To remove the dependency of FA_DUMP on CRASH_DUMP to avoid confusion,
> rename kernel/crash_dump.c to kernel/elfcorehdr.c,
[...]
> 
> Link: https://lkml.kernel.org/r/20240119145241.769622-4-bhe@redhat.com

I confirmed the original patch is making the above mentioned file renaming.

> Signed-off-by: Baoquan He <bhe@redhat.com>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Eric W. Biederman <ebiederm@xmission.com>
> Cc: Hari Bathini <hbathini@linux.ibm.com>
> Cc: Pingfan Liu <piliu@redhat.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  arch/powerpc/Kconfig    |    1 -
>  kernel/Makefile         |    3 +--
>  kernel/kexec_internal.h |    2 ++
>  3 files changed, 3 insertions(+), 3 deletions(-)

However, seems the renaming change has mistakenly not took here.  Apparently
for the reason, I'm getting below build warning on mm-unstable tree after this
patch.

    make[4]: *** No rule to make target 'kernel/elfcorehdr.o', needed by 'kernel/built-in.a'.  Stop.

I confirmed the build error is disappeared after I manually rename the source
file.


Thanks,
SJ

[...]