From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E174F5A788 for ; Tue, 23 Jan 2024 10:29:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.136 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706005775; cv=none; b=tpviInudahgK9SjlvO+f2wfldBm1w4J0HzUX+jUjtXAvCyRM65wkhuNAwqSM9FAM8waBrhUoi8cHmHdMMnWDcWF7U31I6HhxaeET4e5yKT61G376js50FGPEdL4vN5iPbb/A9RJQT6PCbzfQIoGLHhHt/RC3GNoBJDQWeEw9A0Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706005775; c=relaxed/simple; bh=1z304UMB9iwNDgxznbQ/na098G6JM2egcJawzjYAgFU=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rHXwFSMYalV0U8o7lv20/86Y977SQVX8vkncj2QStzRO6q9dCwOaiyeZaDrEi1yjHM8CbJPrMJuFrhrQCUL/TITQTAsquYwHB3tg+q5H1yHaVveps7AlmllikOUYRAMWNRMTocN2vHqWZXv5mP/39j7abwiHYIUlIYiZC6k/Klc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.136 Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5B34B6106A for ; Tue, 23 Jan 2024 10:29:33 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5B34B6106A X-Virus-Scanned: amavisd-new at osuosl.org X-Spam-Flag: NO X-Spam-Score: -4.198 X-Spam-Level: Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EDpLHwL_U2Kc for ; Tue, 23 Jan 2024 10:29:32 +0000 (UTC) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 7363F60EFB for ; Tue, 23 Jan 2024 10:29:32 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 7363F60EFB Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TK3Ct523Lz6K91D; Tue, 23 Jan 2024 18:26:34 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id B7F05140A90; Tue, 23 Jan 2024 18:29:29 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Jan 2024 10:29:29 +0000 Date: Tue, 23 Jan 2024 10:29:28 +0000 From: Jonathan Cameron To: "Russell King (Oracle)" CC: , , , , , , , , , , , , , , Salil Mehta , Jean-Philippe Brucker , , , James Morse Subject: Re: [PATCH RFC v3 18/21] ACPI: processor: Only call arch_unregister_cpu() if HOTPLUG_CPU is selected Message-ID: <20240123102928.0000270c@Huawei.com> In-Reply-To: References: <20231215165009.000035f2@Huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: acpica-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) On Mon, 18 Dec 2023 12:58:07 +0000 "Russell King (Oracle)" wrote: > On Fri, Dec 15, 2023 at 04:50:09PM +0000, Jonathan Cameron wrote: > > On Wed, 13 Dec 2023 12:50:43 +0000 > > Russell King (Oracle) wrote: > > > > > From: James Morse > > > > > > The kbuild robot points out that configurations without HOTPLUG_CPU > > > selected can try to build acpi_processor_post_eject() without success > > > as arch_unregister_cpu() is not defined. > > > > > > Check this explicitly. This will be merged into: > > > | ACPI: Add post_eject to struct acpi_scan_handler for cpu hotplug > > > for any subsequent posting. > > > > > > Reported-by: kbuild test robot > > > Signed-off-by: James Morse > > > Tested-by: Miguel Luis > > > Tested-by: Vishnu Pajjuri > > > Tested-by: Jianyong Wu > > > --- > > > This should probably be squashed into an earlier patch. > > > > Agreed. If not > > Reviewed-by: Jonathan Cameron > > I'm not convinced that "ACPI: Add post_eject to struct acpi_scan_handler > for cpu hotplug" is the correct commit to squash this into. > > As far as acpi_processor.c is concerned, This commit merely renames > acpi_processor_remove() to be acpi_processor_post_eject(). The function > references arch_unregister_cpu() before and after this change, and its > build is dependent on CONFIG_ACPI_HOTPLUG_PRESENT_CPU being defined. > > Commit "ACPI: convert acpi_processor_post_eject() to use IS_ENABLED()" > removed the ifdef CONFIG_ACPI_HOTPLUG_PRESENT_CPU surrounding > acpi_processor_post_eject, and that symbol depends on > CONFIG_HOTPLUG_CPU, so I think this commit is also fine. > > Commit "ACPI: Check _STA present bit before making CPUs not present" > rewrites the function - the original body gets called > acpi_processor_make_not_present() and a new acpi_processor_post_eject() > is created. At this point, it doesn't reference arch_unregister_cpu(). > > Commit "ACPI: add support to register CPUs based on the _STA enabled > bit" adds a reference to arch_unregister_cpu() in this new > acpi_processor_post_eject() - so I think this is the correct commit > this change should be merged into. That or where that change ends up given your earlier suggestion to move that change as well. I find it hard to care as long as the bisection issue is squashed by the change. If we make the code drop out before the build issue is introduced that's fine because we are arguing we shouldn't be running it anyway so such protection is fine if not necessary for build fix purposes. J > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45CDEC47DDB for ; Tue, 23 Jan 2024 10:29:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NdjEwp3ba9vuTh7eD0nVTtnFCyGZWolMJjPTjq8vAfE=; b=mXjJlBFvYzI1A7 i5FuUrKjlfiriVo1XxfMhQ/T70tw0N9UXuF+KwveBB3qSq8BVK7cyRGIuLe84Nm78cC7wpXs6yDTw elR4dUBGgxCo61wnLnQbfn1fg98tFOBAQaQfx9/o9QyQTDtBltMjyp76JpOWkldxDMmFrwXfVEZ5b Hi1CmMVIxf934xlxHZD1xZSeGgYiRxfzFC7+FtcTcIx26eydYqeYzZTdOOBCXUQRh8E7KC6KBVstz M6MQ/ttguNDJD3/r+IQlOkHNcESuySoRuu27eVBxNOZgOMKS3zhdtjmRhF7z5cLBdAxAC467E/Iuj 21ONEof+NQPdRDvijqYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSE2H-00Fvzh-29; Tue, 23 Jan 2024 10:29:41 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSE2D-00FvxY-2r; Tue, 23 Jan 2024 10:29:39 +0000 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TK3Ct523Lz6K91D; Tue, 23 Jan 2024 18:26:34 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id B7F05140A90; Tue, 23 Jan 2024 18:29:29 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Jan 2024 10:29:29 +0000 Date: Tue, 23 Jan 2024 10:29:28 +0000 From: Jonathan Cameron To: "Russell King (Oracle)" CC: , , , , , , , , , , , , , , Salil Mehta , Jean-Philippe Brucker , , , James Morse Subject: Re: [PATCH RFC v3 18/21] ACPI: processor: Only call arch_unregister_cpu() if HOTPLUG_CPU is selected Message-ID: <20240123102928.0000270c@Huawei.com> In-Reply-To: References: <20231215165009.000035f2@Huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_022938_203503_8E7539C0 X-CRM114-Status: GOOD ( 26.21 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, 18 Dec 2023 12:58:07 +0000 "Russell King (Oracle)" wrote: > On Fri, Dec 15, 2023 at 04:50:09PM +0000, Jonathan Cameron wrote: > > On Wed, 13 Dec 2023 12:50:43 +0000 > > Russell King (Oracle) wrote: > > > > > From: James Morse > > > > > > The kbuild robot points out that configurations without HOTPLUG_CPU > > > selected can try to build acpi_processor_post_eject() without success > > > as arch_unregister_cpu() is not defined. > > > > > > Check this explicitly. This will be merged into: > > > | ACPI: Add post_eject to struct acpi_scan_handler for cpu hotplug > > > for any subsequent posting. > > > > > > Reported-by: kbuild test robot > > > Signed-off-by: James Morse > > > Tested-by: Miguel Luis > > > Tested-by: Vishnu Pajjuri > > > Tested-by: Jianyong Wu > > > --- > > > This should probably be squashed into an earlier patch. > > > > Agreed. If not > > Reviewed-by: Jonathan Cameron > > I'm not convinced that "ACPI: Add post_eject to struct acpi_scan_handler > for cpu hotplug" is the correct commit to squash this into. > > As far as acpi_processor.c is concerned, This commit merely renames > acpi_processor_remove() to be acpi_processor_post_eject(). The function > references arch_unregister_cpu() before and after this change, and its > build is dependent on CONFIG_ACPI_HOTPLUG_PRESENT_CPU being defined. > > Commit "ACPI: convert acpi_processor_post_eject() to use IS_ENABLED()" > removed the ifdef CONFIG_ACPI_HOTPLUG_PRESENT_CPU surrounding > acpi_processor_post_eject, and that symbol depends on > CONFIG_HOTPLUG_CPU, so I think this commit is also fine. > > Commit "ACPI: Check _STA present bit before making CPUs not present" > rewrites the function - the original body gets called > acpi_processor_make_not_present() and a new acpi_processor_post_eject() > is created. At this point, it doesn't reference arch_unregister_cpu(). > > Commit "ACPI: add support to register CPUs based on the _STA enabled > bit" adds a reference to arch_unregister_cpu() in this new > acpi_processor_post_eject() - so I think this is the correct commit > this change should be merged into. That or where that change ends up given your earlier suggestion to move that change as well. I find it hard to care as long as the bisection issue is squashed by the change. If we make the code drop out before the build issue is introduced that's fine because we are arguing we shouldn't be running it anyway so such protection is fine if not necessary for build fix purposes. J > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8026C47E49 for ; Tue, 23 Jan 2024 10:30:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pdLjLru0SkMUH4jDRfV8din7teRasL94agPCkLU9TMU=; b=yKHwznSpZbcRlD VDM/VWswHIBeH7A2wONTd9jRPSUnkxl7H9MynUapIsnPZP0W4/HJCczrMV1dp0j5YCEoX0uCug5Z8 y7nv+QPtZYgy9lDLJHpFu3aAa+OGBxDzjWOe2yjvs9WG2KFlPR1pC71OVfwId35vExxouIkxICqdJ QSLZOZt8OaPrWPZZezT0nZLWr/hAtkbKF/qyEm0Im/ALiSQaE78X03+vLQ5iPwplqSMxAYmuTNh6S tZMbn+63Vwv238vuL0pGfd4gi2pPgVp3nF/EKv3JxFN9fLNGX1S640x8AkVLhUhYrHKhm6gCcbE2K muDktsTXsQC1H9+qVLPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSE2H-00FvzE-0E; Tue, 23 Jan 2024 10:29:41 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSE2D-00FvxY-2r; Tue, 23 Jan 2024 10:29:39 +0000 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TK3Ct523Lz6K91D; Tue, 23 Jan 2024 18:26:34 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id B7F05140A90; Tue, 23 Jan 2024 18:29:29 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Jan 2024 10:29:29 +0000 Date: Tue, 23 Jan 2024 10:29:28 +0000 From: Jonathan Cameron To: "Russell King (Oracle)" CC: , , , , , , , , , , , , , , Salil Mehta , Jean-Philippe Brucker , , , James Morse Subject: Re: [PATCH RFC v3 18/21] ACPI: processor: Only call arch_unregister_cpu() if HOTPLUG_CPU is selected Message-ID: <20240123102928.0000270c@Huawei.com> In-Reply-To: References: <20231215165009.000035f2@Huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_022938_203503_8E7539C0 X-CRM114-Status: GOOD ( 26.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 18 Dec 2023 12:58:07 +0000 "Russell King (Oracle)" wrote: > On Fri, Dec 15, 2023 at 04:50:09PM +0000, Jonathan Cameron wrote: > > On Wed, 13 Dec 2023 12:50:43 +0000 > > Russell King (Oracle) wrote: > > > > > From: James Morse > > > > > > The kbuild robot points out that configurations without HOTPLUG_CPU > > > selected can try to build acpi_processor_post_eject() without success > > > as arch_unregister_cpu() is not defined. > > > > > > Check this explicitly. This will be merged into: > > > | ACPI: Add post_eject to struct acpi_scan_handler for cpu hotplug > > > for any subsequent posting. > > > > > > Reported-by: kbuild test robot > > > Signed-off-by: James Morse > > > Tested-by: Miguel Luis > > > Tested-by: Vishnu Pajjuri > > > Tested-by: Jianyong Wu > > > --- > > > This should probably be squashed into an earlier patch. > > > > Agreed. If not > > Reviewed-by: Jonathan Cameron > > I'm not convinced that "ACPI: Add post_eject to struct acpi_scan_handler > for cpu hotplug" is the correct commit to squash this into. > > As far as acpi_processor.c is concerned, This commit merely renames > acpi_processor_remove() to be acpi_processor_post_eject(). The function > references arch_unregister_cpu() before and after this change, and its > build is dependent on CONFIG_ACPI_HOTPLUG_PRESENT_CPU being defined. > > Commit "ACPI: convert acpi_processor_post_eject() to use IS_ENABLED()" > removed the ifdef CONFIG_ACPI_HOTPLUG_PRESENT_CPU surrounding > acpi_processor_post_eject, and that symbol depends on > CONFIG_HOTPLUG_CPU, so I think this commit is also fine. > > Commit "ACPI: Check _STA present bit before making CPUs not present" > rewrites the function - the original body gets called > acpi_processor_make_not_present() and a new acpi_processor_post_eject() > is created. At this point, it doesn't reference arch_unregister_cpu(). > > Commit "ACPI: add support to register CPUs based on the _STA enabled > bit" adds a reference to arch_unregister_cpu() in this new > acpi_processor_post_eject() - so I think this is the correct commit > this change should be merged into. That or where that change ends up given your earlier suggestion to move that change as well. I find it hard to care as long as the bisection issue is squashed by the change. If we make the code drop out before the build issue is introduced that's fine because we are arguing we shouldn't be running it anyway so such protection is fine if not necessary for build fix purposes. J > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel