All of lore.kernel.org
 help / color / mirror / Atom feed
From: deller@kernel.org
To: linux-parisc@vger.kernel.org
Subject: [PATCH 3/7] parisc: Check for valid stride size for cache flushes
Date: Tue, 23 Jan 2024 16:59:00 +0100	[thread overview]
Message-ID: <20240123155904.6220-3-deller@kernel.org> (raw)
In-Reply-To: <20240123155904.6220-1-deller@kernel.org>

From: Helge Deller <deller@gmx.de>

Report if the calculated cache stride size is zero, otherwise the cache
flushing routine will never finish and hang the machine.
This can be reproduced with a testcase in qemu, where the firmware reports
wrong cache values.

Signed-off-by: Helge Deller <deller@gmx.de>
---
 arch/parisc/kernel/cache.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/parisc/kernel/cache.c b/arch/parisc/kernel/cache.c
index 268d90a9325b..0c015487e5db 100644
--- a/arch/parisc/kernel/cache.c
+++ b/arch/parisc/kernel/cache.c
@@ -264,6 +264,10 @@ parisc_cache_init(void)
 	icache_stride = CAFL_STRIDE(cache_info.ic_conf);
 #undef CAFL_STRIDE
 
+	/* stride needs to be non-zero, otherwise cache flushes will not work */
+	WARN_ON(cache_info.dc_size && dcache_stride == 0);
+	WARN_ON(cache_info.ic_size && icache_stride == 0);
+
 	if ((boot_cpu_data.pdc.capabilities & PDC_MODEL_NVA_MASK) ==
 						PDC_MODEL_NVA_UNSUPPORTED) {
 		printk(KERN_WARNING "parisc_cache_init: Only equivalent aliasing supported!\n");
-- 
2.43.0


  parent reply	other threads:[~2024-01-23 15:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23 15:58 [PATCH 1/7] parisc: Use irq_enter_rcu() to fix warning at kernel/context_tracking.c:367 deller
2024-01-23 15:58 ` [PATCH 2/7] parisc: Make RO_DATA page aligned in vmlinux.lds.S deller
2024-01-23 15:59 ` deller [this message]
2024-01-23 15:59 ` [PATCH 4/7] parisc: Prevent hung tasks when printing inventory on serial console deller
2024-01-23 15:59 ` [PATCH 5/7] parisc: Drop unneeded semicolon in parse_tree_node() deller
2024-01-23 15:59 ` [PATCH 6/7] parisc: Fix random data corruption from exception handler deller
2024-01-23 15:59 ` [PATCH 7/7] parisc: Show kernel unaligned memory accesses deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240123155904.6220-3-deller@kernel.org \
    --to=deller@kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.