From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3-of-simple: Stop using of_reset_control_array_get() directly
Date: Wed, 24 Jan 2024 04:39:33 -0800 [thread overview]
Message-ID: <2024012400-subtitle-magnitude-45ff@gregkh> (raw)
In-Reply-To: <20240124-dwc3-of-simple-reset-control-array-fix-v1-1-808182cc3f0e@pengutronix.de>
On Wed, Jan 24, 2024 at 12:26:20PM +0100, Philipp Zabel wrote:
> Use of_reset_control_array_get_optional_exclusive() instead, it is
> implemented as:
>
> static inline struct reset_control *
> of_reset_control_array_get_optional_exclusive(struct device_node *node)
> {
> return of_reset_control_array_get(node, false, true, true);
> }
>
> This makes the code easier to understand and removes the last remaining
> direct use of of_reset_control_array_get(). No functional changes.
>
> Fixes: f4cc91ddd856 ("usb: dwc3: of-simple: remove Amlogic GXL and AXG compatibles")
No functional change, but a Fixes: tag? That doesn't make sense to me,
sorry.
thanks,
greg k-h
next prev parent reply other threads:[~2024-01-24 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 11:26 [PATCH] usb: dwc3-of-simple: Stop using of_reset_control_array_get() directly Philipp Zabel
2024-01-24 12:39 ` Greg Kroah-Hartman [this message]
2024-01-24 12:56 ` Philipp Zabel
2024-01-28 0:34 ` Greg Kroah-Hartman
2024-01-28 0:38 ` Greg Kroah-Hartman
2024-01-24 12:39 ` Greg Kroah-Hartman
2024-01-24 12:57 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024012400-subtitle-magnitude-45ff@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.