All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Yi Sun <yi.sun@unisoc.com>,
	axboe@kernel.dk, mst@redhat.com, jasowang@redhat.com
Cc: oe-kbuild-all@lists.linux.dev, xuanzhuo@linux.alibaba.com,
	pbonzini@redhat.com, stefanha@redhat.com,
	virtualization@lists.linux.dev, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, yi.sun@unisoc.com,
	zhiguo.niu@unisoc.com, hongyu.jin@unisoc.com,
	sunyibuaa@gmail.com
Subject: Re: [PATCH 1/2] blk-mq: introduce blk_mq_tagset_wait_request_completed()
Date: Wed, 24 Jan 2024 02:45:29 +0800	[thread overview]
Message-ID: <202401240242.k3K7SkiZ-lkp@intel.com> (raw)
In-Reply-To: <20240122110722.690223-2-yi.sun@unisoc.com>

Hi Yi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on axboe-block/for-next]
[also build test WARNING on linus/master v6.8-rc1 next-20240123]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yi-Sun/blk-mq-introduce-blk_mq_tagset_wait_request_completed/20240122-192222
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link:    https://lore.kernel.org/r/20240122110722.690223-2-yi.sun%40unisoc.com
patch subject: [PATCH 1/2] blk-mq: introduce blk_mq_tagset_wait_request_completed()
config: i386-buildonly-randconfig-002-20240123 (https://download.01.org/0day-ci/archive/20240124/202401240242.k3K7SkiZ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240124/202401240242.k3K7SkiZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401240242.k3K7SkiZ-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> block/blk-mq-tag.c:498: warning: Function parameter or struct member 'tagset' not described in 'blk_mq_tagset_wait_request_completed'


vim +498 block/blk-mq-tag.c

   490	
   491	/**
   492	 * blk_mq_tagset_wait_request_completed - Wait for all inflight requests
   493	 * to become completed.
   494	 *
   495	 * Note: This function has to be run after all IO queues are shutdown.
   496	 */
   497	void blk_mq_tagset_wait_request_completed(struct blk_mq_tag_set *tagset)
 > 498	{
   499		while (true) {
   500			unsigned int count = 0;
   501	
   502			blk_mq_tagset_busy_iter(tagset,
   503					blk_mq_tagset_count_inflight_rqs, &count);
   504			if (!count)
   505				break;
   506			msleep(20);
   507		}
   508	}
   509	EXPORT_SYMBOL(blk_mq_tagset_wait_request_completed);
   510	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2024-01-23 18:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 11:07 [PATCH 0/2] Fix requests loss during virtio-blk device suspend Yi Sun
2024-01-22 11:07 ` [PATCH 1/2] blk-mq: introduce blk_mq_tagset_wait_request_completed() Yi Sun
2024-01-23 18:45   ` kernel test robot [this message]
2024-01-23 19:14   ` Keith Busch
2024-01-24 11:22     ` yi sun
2024-01-24 17:17       ` Keith Busch
2024-01-22 11:07 ` [PATCH 2/2] virtio-blk: Ensure no requests in virtqueues before deleting vqs Yi Sun
2024-01-22 15:42   ` Stefan Hajnoczi
2024-01-23  3:27     ` yi sun
2024-01-23 15:09       ` Stefan Hajnoczi
2024-01-24  7:38         ` yi sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202401240242.k3K7SkiZ-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=axboe@kernel.dk \
    --cc=hongyu.jin@unisoc.com \
    --cc=jasowang@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=sunyibuaa@gmail.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    --cc=yi.sun@unisoc.com \
    --cc=zhiguo.niu@unisoc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.