From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF64F129A65 for ; Wed, 24 Jan 2024 17:25:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706117113; cv=none; b=Wow27xIYh37DboMTd+6KNRjwAFsgHkkc7QNuTToxcN9ptBnzwS4hwTMF9lEyfWRhiZnBu7OETBteOWRgQVjeFlpeFbv3kB88CON4dpV7sPRRvOafaA9aYgRmRv3xAWBiP8Fg3AQ6SV04b9Fmqau4RTypvNGivaVN3Y0u4tGdKSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706117113; c=relaxed/simple; bh=fQP8/M1QomdvhevshrbbyC+G3774Cm3toGMmsbZ5S08=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JX/QidxeGXY49ZVMb1eJU6Te/p8d28iAo1E+Vk+z19rRggLN1oq/4evagyzO7d1QB9kyCwEa6qNcgWqpep+S/wK1JzDwI1PvuKjllAUHv2xIJVUMVjza0o+TVzyKRGJJ17VzUpTauT7d4H+d479DytOX5tYCn4OdrBNnPOi15F8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tDV3VfTQ; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tDV3VfTQ" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-40ec34160baso13765785e9.1 for ; Wed, 24 Jan 2024 09:25:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706117110; x=1706721910; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fQP8/M1QomdvhevshrbbyC+G3774Cm3toGMmsbZ5S08=; b=tDV3VfTQGdHxj52YrYBAslccY5mFWvnpoB4Q7nePNtX0TVq/1W/oVVM//AoHQSjhnS bEo/ja2Via7LQEVi3qjTrJXHY3sqooJr8JodFFMBxnWchgtZpSeU7J5Y+Q4f/LBxlPNS Slf96OL70rJcwk2oP8O4k6SlKfv1LWIRSYwWCdeAZ7TCTbIvg8xJOwjcfOk0Q7rFTKsD zpZrs1zcSVyDG18K4IIF9X/ajLuwt6/mDfu+AzWPbSXswMILMdzH46bs+U2jdVWQo8i2 xc1HVKgrQhtSV1AYpeFzCvXqHROoPMRnniBAVIQtYvr3yCxzFPZoZ5LsnzmJJwAFx4Hx tGJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706117110; x=1706721910; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fQP8/M1QomdvhevshrbbyC+G3774Cm3toGMmsbZ5S08=; b=FGYk+CLcMEf1z/DTAsQJX6HpWCpgN2tAlBcRzqNyjL9LAd0JJwc12i5yiMDmyRAHcP yZbT7CTP3h5aatlGQOLpnCbJTZyQZPWDFfRtZXow3Bsv2gxpFLd3Xg4ovAVCmKyEKRyy X6J0dtjF7dR3dyKAYNvg7HvJvHxGAVO+abRQw1DNIVuxqWFgcUUIAbUtnrXqZxZ9jIMH vbm8npgVfmDM+ypwZKMyb8RSIZR5NhkyS5CpQJGBLAfMDWgeV13LZZu6fIw43KWKUC8g qmmLZeHedHfTE/DSlvin4mJPOT0tlIwGr68qrX72DqWlcE/Fzqjww40od4o4zNPSVxGj 8LaQ== X-Gm-Message-State: AOJu0YwzrYmUXeXKEfvP82e/WyRhFTXWpAgJF0AHazcg3oU4ZhhsdZTB 4XzDVa15iBTkVtO6W0HiAqjqeflpAbws6kCyfJWMU7TQdLU+KJIyOL6FLsap2VY= X-Google-Smtp-Source: AGHT+IHtZmUsImHUN6vx4IajyMpk1NjS/10baW8IunEC4zx4kdLeWpbSforzB18JvfYxa35SxlP9Hw== X-Received: by 2002:a05:600c:470a:b0:40e:7516:2c7b with SMTP id v10-20020a05600c470a00b0040e75162c7bmr1904703wmo.38.1706117109977; Wed, 24 Jan 2024 09:25:09 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id fc6-20020a05600c524600b0040d53588d94sm285281wmb.46.2024.01.24.09.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 09:25:09 -0800 (PST) Date: Wed, 24 Jan 2024 17:25:07 +0000 From: Daniel Thompson To: Andy Shevchenko Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Jingoo Han , Helge Deller Subject: Re: [PATCH v1 4/4] backlight: hx8357: Utilise temporary variable for struct device Message-ID: <20240124172507.GA16024@aspen.lan> References: <20240114152759.1040563-1-andriy.shevchenko@linux.intel.com> <20240114152759.1040563-5-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240114152759.1040563-5-andriy.shevchenko@linux.intel.com> On Sun, Jan 14, 2024 at 05:25:11PM +0200, Andy Shevchenko wrote: > We have a temporary variable to keep pointer to struct device. > Utilise it inside the ->probe() implementation. > > Signed-off-by: Andy Shevchenko Reviewed-by: Daniel Thompson Daniel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1199DC46CD2 for ; Wed, 24 Jan 2024 17:26:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3F49510F78D; Wed, 24 Jan 2024 17:26:13 +0000 (UTC) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7EF0610F78D for ; Wed, 24 Jan 2024 17:26:11 +0000 (UTC) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-40ec048e0c1so16647535e9.2 for ; Wed, 24 Jan 2024 09:26:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706117110; x=1706721910; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fQP8/M1QomdvhevshrbbyC+G3774Cm3toGMmsbZ5S08=; b=vV/+hzymvOx8Xzn0bQn/uQ/yMVQaLghfCOC1DAevcF2XIraLf5HF2exohU+5rvSXP3 fyOrM+A4SoFkZ638pva0CgBVpgkAjllWyGsNN52EQH+E1ht76Q4YaxJWNAJEMHMstYul c9Pd9AJiDcLGvn6ygILf+C8MLGytE0e69Cw61SHWiFGrlBFczq3gizmtQ6fR9Y8VdI1L M9sPYn2WOFuTjieAyEgmle+miG4Ab+UEd8ssntOz3+IdFZFL6leAl161+QKycx6fdVte plS2mrgAtqkhk7XNsoPPsVQRD/0aSt+zCCRsPAcSokohnm1HDZX97GdSiGySbGtqCJPA XqZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706117110; x=1706721910; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fQP8/M1QomdvhevshrbbyC+G3774Cm3toGMmsbZ5S08=; b=ksyEiOUxexHDyBXAbevgaycGKJ8Xs+aOxqzw25PgjHCkjOiD/U/ipwNzz6z7Wr44N6 29J7A9cUo1qXTB9zTR5q3u32xbVaChViNWe9I8Y4zdmCW7BAxpp2fIbD3ZZAcuyeGPir P10bEzi8XEsO83wIKJpb1hxtseiU2MMQX4B2jw9WlC/kU8FaevaG83n8+vx+JigP+zP0 4Kkyfx7oyU2A33wZejO0Grb18lc3oHqWys/QsTNq9l/poqO/35q0fE2qfV1Rp+KGHbap wB7sPCz4epkMxDYJikpi6tGIUgP5SaIZNE7x+wagpas7heMeZjP6ENJT202J9C4iHIS4 BaMA== X-Gm-Message-State: AOJu0YzVyHvz5pQovN9ptTdaeXDxXtYGBcj8WDbhobU+HcThvdavuKot 6UOqTako9s7QWnsyIfgTd27F/wYjZp2zAF4mE6uQH3Ospt8zGPGQfgq+fgiwk4k= X-Google-Smtp-Source: AGHT+IHtZmUsImHUN6vx4IajyMpk1NjS/10baW8IunEC4zx4kdLeWpbSforzB18JvfYxa35SxlP9Hw== X-Received: by 2002:a05:600c:470a:b0:40e:7516:2c7b with SMTP id v10-20020a05600c470a00b0040e75162c7bmr1904703wmo.38.1706117109977; Wed, 24 Jan 2024 09:25:09 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id fc6-20020a05600c524600b0040d53588d94sm285281wmb.46.2024.01.24.09.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 09:25:09 -0800 (PST) Date: Wed, 24 Jan 2024 17:25:07 +0000 From: Daniel Thompson To: Andy Shevchenko Subject: Re: [PATCH v1 4/4] backlight: hx8357: Utilise temporary variable for struct device Message-ID: <20240124172507.GA16024@aspen.lan> References: <20240114152759.1040563-1-andriy.shevchenko@linux.intel.com> <20240114152759.1040563-5-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240114152759.1040563-5-andriy.shevchenko@linux.intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Jingoo Han , Helge Deller , Lee Jones , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Jan 14, 2024 at 05:25:11PM +0200, Andy Shevchenko wrote: > We have a temporary variable to keep pointer to struct device. > Utilise it inside the ->probe() implementation. > > Signed-off-by: Andy Shevchenko Reviewed-by: Daniel Thompson Daniel.