Re: [PATCH] ip/bond: add coupled_control support

[Stephen Hemminger <stephen@networkplumber.org>]

On Thu, 25 Jan 2024 00:38:16 +0000
Aahil Awatramani <aahila@google.com> wrote:

> coupled_control specifies whether the LACP state machine's MUX in the
> 802.3ad mode should have separate Collecting and Distributing states per
> IEEE 802.1AX-2008 5.4.15 for coupled and independent control state.
> 
> By default this setting is on and does not separate the Collecting and
> Distributing states, maintaining the bond in coupled control. If set off,
> will toggle independent control state machine which will seperate
> Collecting and Distributing states.
> 
> Signed-off-by: Aahil Awatramani <aahila@google.com>
> ---
>  include/uapi/linux/if_link.h |  1 +
>  ip/iplink_bond.c             | 26 +++++++++++++++++++++++++-
>  2 files changed, 26 insertions(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> index d17271fb..ff4ceeaf 100644
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -1503,6 +1503,7 @@ enum {
>  	IFLA_BOND_AD_LACP_ACTIVE,
>  	IFLA_BOND_MISSED_MAX,
>  	IFLA_BOND_NS_IP6_TARGET,
> +	IFLA_BOND_COUPLED_CONTROL,
>  	__IFLA_BOND_MAX,
>  };

This patch needs to be targeted at iproute2-next 
Subject should be:
 [PATCH iproute2-next] ip/bond: add coupled_control_support

David will pick up the uapi header once the kernel part is merged.

Since it is a boolean option there is on need for on/off style here.
Just use presence of flag to indicate on state.

And use print_null() to indicate presence of  flag rather than using print_string.