From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH] gpio: cdev: remove leftover function pointer typedefs
Date: Thu, 25 Jan 2024 07:43:16 +0800 [thread overview]
Message-ID: <20240124234316.GA6255@rigel> (raw)
In-Reply-To: <20240124161725.79582-1-brgl@bgdev.pl>
On Wed, Jan 24, 2024 at 05:17:25PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The locking wrappers were replaces with lock guards. These typedefs are
> no longer needed.
>
replaced
Given that,
Reviewed-by: Kent Gibson <warthog618@gmail.com>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> drivers/gpio/gpiolib-cdev.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index 2a88736629ef..34d6712fa07c 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -61,11 +61,6 @@ static_assert(IS_ALIGNED(sizeof(struct gpio_v2_line_values), 8));
> * interface to gpiolib GPIOs via ioctl()s.
> */
>
> -typedef __poll_t (*poll_fn)(struct file *, struct poll_table_struct *);
> -typedef long (*ioctl_fn)(struct file *, unsigned int, unsigned long);
> -typedef ssize_t (*read_fn)(struct file *, char __user *,
> - size_t count, loff_t *);
> -
> /*
> * GPIO line handle management
> */
> --
> 2.40.1
>
next prev parent reply other threads:[~2024-01-24 23:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 16:17 [PATCH] gpio: cdev: remove leftover function pointer typedefs Bartosz Golaszewski
2024-01-24 23:43 ` Kent Gibson [this message]
2024-01-31 8:12 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240124234316.GA6255@rigel \
--to=warthog618@gmail.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.