From: Jason Gunthorpe <jgg@nvidia.com>
To: Joel Granados <j.granados@samsung.com>
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Kevin Tian <kevin.tian@intel.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Nicolin Chen <nicolinc@nvidia.com>, Yi Liu <yi.l.liu@intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Longfang Liu <liulongfang@huawei.com>,
Yan Zhao <yan.y.zhao@intel.com>,
iommu@lists.linux.dev, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 01/16] iommu: Move iommu fault data to linux/iommu.h
Date: Thu, 25 Jan 2024 09:43:37 -0400 [thread overview]
Message-ID: <20240125134337.GN1455070@nvidia.com> (raw)
In-Reply-To: <20240125091734.chekvxgof2d5zpcg@localhost>
On Thu, Jan 25, 2024 at 10:17:34AM +0100, Joel Granados wrote:
> On Mon, Jan 22, 2024 at 01:42:53PM +0800, Lu Baolu wrote:
> > The iommu fault data is currently defined in uapi/linux/iommu.h, but is
> > only used inside the iommu subsystem. Move it to linux/iommu.h, where it
> > will be more accessible to kernel drivers.
> >
> > With this done, uapi/linux/iommu.h becomes empty and can be removed from
> > the tree.
>
> The reason for removing this [1] is that it is only being used by
> internal code in the kernel. What happens with usespace code that have
> used these definitions? Should we deprecate instead of just removing?
There was never an in-tree kernel implementation. Any userspace that
implemented this needs to decide on its own if it will continue to
support the non-mainline kernel and provide a copy of the definitions
itself..
(it was a process mistake to merge a uapi header without a
corresponding uapi implementation, sorry)
Jason
next prev parent reply other threads:[~2024-01-25 13:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 5:42 [PATCH v10 00/16] iommu: Prepare to deliver page faults to user space Lu Baolu
2024-01-22 5:42 ` [PATCH v10 01/16] iommu: Move iommu fault data to linux/iommu.h Lu Baolu
2024-01-25 9:17 ` Joel Granados
2024-01-25 11:21 ` Baolu Lu
2024-01-26 14:26 ` Joel Granados
2024-01-25 13:43 ` Jason Gunthorpe [this message]
2024-01-26 14:25 ` Joel Granados
2024-01-22 5:42 ` [PATCH v10 02/16] iommu/arm-smmu-v3: Remove unrecoverable faults reporting Lu Baolu
2024-01-22 5:42 ` [PATCH v10 03/16] iommu: Remove unrecoverable fault data Lu Baolu
2024-01-22 5:42 ` [PATCH v10 04/16] iommu: Cleanup iopf data structure definitions Lu Baolu
2024-01-25 10:23 ` Joel Granados
2024-01-25 11:33 ` Baolu Lu
2024-01-25 13:44 ` Jason Gunthorpe
2024-01-22 5:42 ` [PATCH v10 05/16] iommu: Merge iopf_device_param into iommu_fault_param Lu Baolu
2024-01-22 5:42 ` [PATCH v10 06/16] iommu: Remove iommu_[un]register_device_fault_handler() Lu Baolu
2024-01-22 5:42 ` [PATCH v10 07/16] iommu: Merge iommu_fault_event and iopf_fault Lu Baolu
2024-01-22 5:43 ` [PATCH v10 08/16] iommu: Prepare for separating SVA and IOPF Lu Baolu
2024-01-22 5:43 ` [PATCH v10 09/16] iommu: Make iommu_queue_iopf() more generic Lu Baolu
2024-01-22 5:43 ` [PATCH v10 10/16] iommu: Separate SVA and IOPF Lu Baolu
2024-01-22 5:43 ` [PATCH v10 11/16] iommu: Refine locking for per-device fault data management Lu Baolu
2024-01-22 5:43 ` [PATCH v10 12/16] iommu: Use refcount for fault data access Lu Baolu
2024-01-22 5:43 ` [PATCH v10 13/16] iommu: Improve iopf_queue_remove_device() Lu Baolu
2024-01-22 5:43 ` [PATCH v10 14/16] iommu: Track iopf group instead of last fault Lu Baolu
2024-01-22 5:43 ` [PATCH v10 15/16] iommu: Make iopf_group_response() return void Lu Baolu
2024-01-25 16:27 ` Joel Granados
2024-01-26 6:43 ` Baolu Lu
2024-02-02 15:36 ` Jason Gunthorpe
2024-01-22 5:43 ` [PATCH v10 16/16] iommu: Make iommu_report_device_fault() reutrn void Lu Baolu
2024-01-25 16:26 ` Joel Granados
2024-01-26 6:42 ` Baolu Lu
2024-02-02 15:39 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125134337.GN1455070@nvidia.com \
--to=jgg@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=j.granados@samsung.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liulongfang@huawei.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yan.y.zhao@intel.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.