From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: hare@kernel.org, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>,
Martin George <marting@netapp.com>
Subject: Re: [PATCH] nvme: enable retries for authentication commands
Date: Thu, 25 Jan 2024 16:48:14 +0100 [thread overview]
Message-ID: <20240125154814.GA23800@lst.de> (raw)
In-Reply-To: <13922738-7cdb-457d-9ba6-4a3a9a064a8b@kernel.dk>
On Thu, Jan 25, 2024 at 08:42:10AM -0700, Jens Axboe wrote:
> On 1/25/24 6:09 AM, hare@kernel.org wrote:
> > From: Hannes Reinecke <hare@suse.de>
> >
> > Authentication commands are normal NVMe commands, and as such
> > can return a status where NVME_SC_DNR is not set, indicating
> > that the command should be retried.
> > Rather than checking NVME_SC_DNR manually for each command completion
> > this patch adds a flag 'retry' to __nvme_submit_sync_cmd(), causing
> > the REQ_FAILFAST_DRIVER option to be cleared and the command to
> > be retried via the normal mechanism.
>
> Can we please do this without adding Yet Another parameter to that
> function?
Heh, I wrote about the same reply a few minutes ago. I'll try to think
what we can do instead.
next prev parent reply other threads:[~2024-01-25 15:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 13:09 [PATCH] nvme: enable retries for authentication commands hare
2024-01-25 15:42 ` Jens Axboe
2024-01-25 15:48 ` Christoph Hellwig [this message]
2024-01-25 16:20 ` Hannes Reinecke
2024-01-25 16:50 ` Jens Axboe
2024-01-25 17:09 ` Hannes Reinecke
2024-01-25 17:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125154814.GA23800@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hare@kernel.org \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marting@netapp.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.