From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C21CEC47422 for ; Fri, 26 Jan 2024 07:00:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D8946B00A0; Fri, 26 Jan 2024 02:00:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 485D96B00A2; Fri, 26 Jan 2024 02:00:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3288B6B00A5; Fri, 26 Jan 2024 02:00:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1B2A26B00A0 for ; Fri, 26 Jan 2024 02:00:25 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AE05B1402AE for ; Fri, 26 Jan 2024 07:00:24 +0000 (UTC) X-FDA: 81720563568.03.8C5710F Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) by imf26.hostedemail.com (Postfix) with ESMTP id D3E38140021 for ; Fri, 26 Jan 2024 07:00:22 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OJ9WZGOT; spf=pass (imf26.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.161.41 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706252422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xb6T+Rm32ycbDoAgSUxsRyhNv4ZvA5Ga3kFWEo8h53w=; b=nLrGQlcrYueacY8a7zbdmpCDk0H4KQiODffITcpcOgusF1cbhL1emLv9LPAZZ9kRzC9A0/ 8DpRethtzWvcOB8H5Uy8Bps3nKIW7aYRPNLZC/dgCKL42dJtj+1bzayKLO8VhZ5EHac3a4 4oxmFW7kbpTXvnpMJhxSMO9f++nfQZE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706252422; a=rsa-sha256; cv=none; b=tMCW2PhDiwu8KZY8K3IZzuPZxGDGVfOHtLk0o14xJ1NepJ2cideXcLePuapC+/EIrthuje 46p9cEVIs1dzP3jLMLrgiEYYpFMu+OWmaWCcwIBbnEz1xOVQkwLQDxeK3ZH+KXfIH+2Dep 4r/NyBZWrRi2ywpx+sEB4moq5pwDiLE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OJ9WZGOT; spf=pass (imf26.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.161.41 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-5999ec531dcso55881eaf.3 for ; Thu, 25 Jan 2024 23:00:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1706252422; x=1706857222; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Xb6T+Rm32ycbDoAgSUxsRyhNv4ZvA5Ga3kFWEo8h53w=; b=OJ9WZGOTSsWipk/NQH3Wbqec3xWevHDS/ERaUQ9qXTCX2n4fKA+8IxvNr5l0L5UJcs cf2I+vjgUuxZLEaeW1hPkFCbNjQXfPlhBgq2rbJxp51R3gN4agwUmPpbBXaGqbLvppTC N6IjYSodEfjMyvWtrAgZ1N60iTqauR36OV2kk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706252422; x=1706857222; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xb6T+Rm32ycbDoAgSUxsRyhNv4ZvA5Ga3kFWEo8h53w=; b=ir6lVtxcBZL13XZj3u8To52aUOrPYeSEBjyS7I3sXienn1fBF5J7M6YU/849aMt5EH msS8TdKa5vQ9CGtV8rKOEne6AG/Ig/pnLQoUV6VHuS8cSNrBcE96oG0mR8wwoGynLtqU 1nqf5dgJJUgajnNVYpTo0JsEXxSEGlaH01Il9Tq+y5f69+Gg082RSubNbh/Yc7u5OrqF h4vm8ZQvQfFM8vxOdPIx54/hnJeqYjL6z/c9Fqbba4r5tcQfdNqFvZ5fYBHi//inog49 RcpAEPkWuGiGi/2wXWlSf1/OB0jUp6iiPpzPpjioNfU6W5Yu7ftxJ2h6AzFpm5hFdKBw gzjQ== X-Gm-Message-State: AOJu0YyQTF0k3zkfe5wRdXwjMqN1mX8KUUBPVDZ+WsetyH1pcAxCqYZe sCSsV6tiZw0VQxEyDo3rNOunPxtn8jXDAkwxPXMgWG5IMtIHaXSOp3c8US7f7A== X-Google-Smtp-Source: AGHT+IF0SU5MN9q62FrP08/sHSCs3EbXGIsFyPvbbrN21ihOqKQEiRDoUPp5SBGlZhdmxVq04X2vpA== X-Received: by 2002:a05:6358:7253:b0:176:91cd:1a94 with SMTP id i19-20020a056358725300b0017691cd1a94mr1356572rwa.33.1706252421480; Thu, 25 Jan 2024 23:00:21 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:c4a9:6453:1d67:60e8]) by smtp.gmail.com with ESMTPSA id e12-20020aa78c4c000000b006dde0df3a7esm531772pfd.101.2024.01.25.23.00.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 23:00:21 -0800 (PST) Date: Fri, 26 Jan 2024 16:00:17 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Sergey Senozhatsky , Jiexun Wang , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/madvise: don't forget to leave lazy MMU mode in madvise_cold_or_pageout_pte_range() Message-ID: <20240126070017.GB329333@google.com> References: <20230921174101.8e6271422a857af5414ce0a0@linux-foundation.org> <20240126032608.355899-1-senozhatsky@chromium.org> <20240125225336.6a444c01d9d9812a23a6890b@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240125225336.6a444c01d9d9812a23a6890b@linux-foundation.org> X-Rspamd-Queue-Id: D3E38140021 X-Rspam-User: X-Stat-Signature: m67q61hphqijwusxtody8hjrddaxpu9p X-Rspamd-Server: rspam03 X-HE-Tag: 1706252422-978882 X-HE-Meta: U2FsdGVkX18soqczNA2HsS1mzpLTAmrnF0aLR53976HHMYyq1YzEACcXfzDWkx0F/POaNBE9M8y51LJZWzabjFxxQAl460+MS4lSZMdDYIJdBiCMiCUQeHl1ynioe3DC+MfUUBX5ikhqZYfzzsHHeOBOrbU8mJdD3lFmoze9ZiLIoZv1qCeq9wNBlYB3osrpStH8Cy9k7RjfBKVrGyNuPPKDT1bz/g6mwmx3o58P1F2oGqi5q1slS3FxQnQEmAaPXaNhlPyDmuvm50Zszi2RI6/m2xwXQFs67dpO41obyd+aDg9K5ZAaoLvE0swzN45RnbDGMGR7C/5ptJJqYwTd/MsxG0ARGsck4KLvdIGGU3hNWJ0Hr/qMpMg+kzypmFcyxpsDqpwFdp2pwTDVoJKA7zeaJg6F1//PXdQb7GmeX3lW4p8/sETtmMQucZ10WAqNJ0NYsA8tGkD4oUgNGzP1h1se39ZCqI4COKGdOfoiwJWNHyDbqhku+4yxJKJZX5+MspzxgtRMH8nawvCuzUlvS8zlU6dyhgKBkKLLT7u+u7rOn3O5NPWjiCDjRJDsRY7v/q53tiXrlEJMfT7TwPK6aRv/IyrqfCCdGXdZ5ium8CUpt+E+zbz39n+KNmqjjedIH9akKZFTWVUkFyXmPM0chAt+GeYwOSYOj8BbhsSY4xmq87W/67t6/TEZfbT5IjAOPWQc5i3G8FqsHD9+5KnesZKKUjO3Zx5Rp6YCyrd6YASEg1f+RndofQ2Z1+wEDgJDYl/IZUappZTmgRXJWcHlXE1RNoOHFEldBwZxoLLs/HyL6g4iiGzf0Dq1Vyipk8ZLRF1YH/eDe/biBIMABZt6yMzfh9MI8E4uGF75qZGqrFMHZ8nSao+m3TGHteLNtQNySi6EeEw1WglG8pJiM6GNFfja6bBRnYV5jERiowJhsLnypCHKI9ZoKnQoZNhZo3lTZBwd5xSgqzegTGn3xSg 3XoDvGmi FF+le/z9//58BTJuLisShg5rx5zXYHSglTGNFUDl48FvtFVJy4p6pnCb8lwhvt9lqCRJ8Xg162fLZBgHiik1Dx647m1jvnAS85p6TKMQ/IDq8jD1d6VgoruVO5JU9RxmJtfrYKcGjjmyrOn/un3OSio0T8Io0Z+rSBKIXvSWUQLbA4norxR8wJEL6H3xfSO4QhkYkhMvhuqenrCQkE0w8C31aGi8vOVoz7M3buJStUcj0/xVO5vzx0+ZUcCH2zQ375PC2CSSQbPnYiFdSCf6BOeYNhLdGuSbVmf4yZZH20vbttkcyiKP0G9Fau8Sw8/dA6l8r9dQ14w4Y9dGRa2W3y0BZUTq2PPVMbhG52eHknQx7R4YjtEWzMUqZxniozI2iIcgpdDsuH37DjVSnCNLTp6UrwjmxGFN0CKONRJcz4VWnOHMrJLbQG+v7YFqQBYAVULmnbjXjazVrjiHABbxmLchk+iI19meXrTZm2ucQkWdcPnFJvvauuaynjPLJtdiGc6u1xRLsbn9U2wRfpMRjkhAeNoWNK/Fxk60VNJhSs1UAE8yVCkRhJSa2JbWzjWnVcsJ3+o1L8wVV+t5zmOtFQ4+e3BIaowIX3RNbohJrhEyY4XOgZLeO0re66GvsveIrGAO8WYdSEMzYZEkzmHITfr+DeZa3HqM6VOOyhrztSeJ+7xFGu1v2RXTqA5RCvShPE/gs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000018, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/01/25 22:53), Andrew Morton wrote: > Date: Thu, 25 Jan 2024 22:53:36 -0800 > From: Andrew Morton > To: Sergey Senozhatsky > Cc: Jiexun Wang , linux-kernel@vger.kernel.org, > linux-mm@kvack.org > Subject: Re: [PATCH] mm/madvise: don't forget to leave lazy MMU mode in > madvise_cold_or_pageout_pte_range() > Message-Id: <20240125225336.6a444c01d9d9812a23a6890b@linux-foundation.org> > X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) > > On Fri, 26 Jan 2024 12:25:48 +0900 Sergey Senozhatsky wrote: > > > We need to leave lazy MMU mode before unlocking. It depends on the arch, as far as I understand it. We can enter lazy MMU mode (on each goto restart) more times than leave it, and, for isntance, on powerpc that means that we can preempt_disable() more times than preempt_enable(). That's how enter/leave lazy MMU mode is implemented there: static inline void arch_enter_lazy_mmu_mode(void) { struct ppc64_tlb_batch *batch; if (radix_enabled()) return; /* * apply_to_page_range can call us this preempt enabled when * operating on kernel page tables. */ preempt_disable(); batch = this_cpu_ptr(&ppc64_tlb_batch); batch->active = 1; } static inline void arch_leave_lazy_mmu_mode(void) { struct ppc64_tlb_batch *batch; if (radix_enabled()) return; batch = this_cpu_ptr(&ppc64_tlb_batch); if (batch->index) __flush_tlb_pending(batch); batch->active = 0; preempt_enable(); } > What might be the userspace-visible effects of this? > > > Fixes: b2f557a21bc8 ("mm/madvise: add cond_resched() in madvise_cold_or_pageout_pte_range()" > > Signed-off-by: Sergey Senozhatsky > > I'll add a cc:stable. Thanks.