From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59CFD1C2A6; Fri, 26 Jan 2024 08:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706258598; cv=none; b=dSk9Fv7LhUeoc2RJHxxBzt+ZLSQ/SZSGW44M9vTiJu7GBz6qjcwZre+nStUDATttwo6KbnfatzP+ell4saA5/Dt+rfvn6QFzBXD44a9Q+XTjSSJi7nkZEV4hhzOSSJeQtMWyo8Xime9xstHmnQRzcrp0vQ0NV6f7w6jKhr/UnAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706258598; c=relaxed/simple; bh=oF5B98tG35oUypgTR8kLKZMFEniob38hECdwFh7l1QQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hJv+h7TZWTqtEc8qeuJx/LH7O6nHRkjLx5sONVj+btuhUSHlKupaFwO+Rh4Lk6eOnQ3KDFitcca7jEJNnZMWdRav+1lnpsdmmfV4CI7n32jTARC2c1K7L/euTnyc9YuYnNcq5YuHNrgxnuR7Gj770TB4w8RqiSbDjztyVbPWraM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H3GHN50V; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H3GHN50V" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 602D4C43390; Fri, 26 Jan 2024 08:43:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706258597; bh=oF5B98tG35oUypgTR8kLKZMFEniob38hECdwFh7l1QQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H3GHN50VuE1DHNfCijXJC7+XCojgFCv2Nw+68NOngbB7oeLYFAyR/QpNPDD6Opuiu lhdOSkh7lOsjYGr+aI3qY6V671pKlUvyIGsOuGGzyYUVJqxsqBPeUEM1Fn0q/6ZB74 7X9xC/3zvNK0i84Y+C1CnBLXYC5GbkCuPOHd4GYBTQvZEqICAAIw4X5Usf3A9CjHbZ KIajHUBfH1QnMC1fYx7trdyBOcQDIC4d/NSP/WgI2yRE5A0APmazNjcdXny6AjnTJn pVjdwC8U3nFwSpLEpfJ5qRo1bZ79o43izJldYZNv0wpeH3EORSUq45F1b2H2zPSddc SyhrXixVM0K/Q== Date: Fri, 26 Jan 2024 08:43:09 +0000 From: Lee Jones To: Saravana Kannan Cc: Krzysztof Kozlowski , Peter Griffin , arnd@arndb.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux@roeck-us.net, wim@linux-watchdog.org, conor+dt@kernel.org, alim.akhtar@samsung.com, jaewon02.kim@samsung.com, chanho61.park@samsung.com, semen.protsenko@linaro.org, kernel-team@android.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, willmcvicker@google.com, linux-fsd@tesla.com, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH 3/9] watchdog: s3c2410_wdt: update to use new exynos_pmu_*() apis Message-ID: <20240126084309.GM74950@google.com> References: <20240122225710.1952066-4-peter.griffin@linaro.org> <6c72a521-1048-42eb-ac74-d8f718a90723@linaro.org> <04411aaf-6f2c-4f43-83b4-aa0741ccd25f@linaro.org> <20240125114606.GA1327902@google.com> Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, 25 Jan 2024, Saravana Kannan wrote: > On Thu, Jan 25, 2024 at 3:46 AM Lee Jones wrote: > > > > On Thu, 25 Jan 2024, Krzysztof Kozlowski wrote: > > > > > On 24/01/2024 22:27, Saravana Kannan wrote: > > > > On Tue, Jan 23, 2024 at 10:27 PM Krzysztof Kozlowski > > > > wrote: > > > >> > > > >> On 24/01/2024 04:37, Saravana Kannan wrote: > > > >>> On Tue, Jan 23, 2024 at 10:12 AM Krzysztof Kozlowski > > > >>> wrote: > > > >>>> > > > >>>> On 23/01/2024 18:30, Peter Griffin wrote: > > > >>>>>>> dev_warn(wdt->dev, "Couldn't get RST_STAT register\n"); > > > >>>>>>> else if (rst_stat & BIT(wdt->drv_data->rst_stat_bit)) > > > >>>>>>> @@ -698,14 +699,6 @@ static int s3c2410wdt_probe(struct platform_device *pdev) > > > >>>>>>> if (ret) > > > >>>>>>> return ret; > > > >>>>>>> > > > >>>>>>> - if (wdt->drv_data->quirks & QUIRKS_HAVE_PMUREG) { > > > >>>>>>> - wdt->pmureg = syscon_regmap_lookup_by_phandle(dev->of_node, > > > >>>>>>> - "samsung,syscon-phandle"); > > > >>>>>>> - if (IS_ERR(wdt->pmureg)) > > > >>>>>>> - return dev_err_probe(dev, PTR_ERR(wdt->pmureg), > > > >>>>>>> - "syscon regmap lookup failed.\n"); > > > >>>>>> > > > >>>>>> > > > >>>>>> Continuing topic from the binding: I don't see how you handle probe > > > >>>>>> deferral, suspend ordering. > > > >>>>> > > > >>>>> The current implementation is simply relying on exynos-pmu being > > > >>>>> postcore_initcall level. > > > >>>>> > > > >>>>> I was just looking around for any existing Linux APIs that could be a > > > >>>>> more robust solution. It looks like > > > >>>>> > > > >>>>> of_parse_phandle() > > > >>>>> and > > > >>>>> of_find_device_by_node(); > > > >>>>> > > > >>>>> Are often used to solve this type of probe deferral issue between > > > >>>>> devices. Is that what you would recommend using? Or is there something > > > >>>>> even better? > > > >>>> > > > >>>> I think you should keep the phandle and then set device link based on > > > >>>> of_find_device_by_node(). This would actually improve the code, because > > > >>>> syscon_regmap_lookup_by_phandle() does not create device links. > > > >>> > > > >>> I kinda agree with this. Just because we no longer use a syscon API to > > > >>> find the PMU register address doesn't mean the WDT doesn't depend on > > > >>> the PMU. > > > >>> > > > >>> However, I think we should move to a generic "syscon" property. Then I > > > >>> can add support for "syscon" property to fw_devlink and then things > > > >>> will just work in terms of probe ordering, suspend/resume and also > > > >>> showing the dependency in DT even if you don't use the syscon APIs. > > > >>> > > > >>> Side note 1: > > > >>> > > > >>> I think we really should officially document a generic syscon DT > > > >>> property similar to how we have a generic "clocks" or "dmas" property. > > > >>> Then we can have a syscon_get_regmap() that's like so: > > > >>> > > > >>> struct regmap *syscon_get_regmap(struct device *dev) > > > >>> { > > > >>> return syscon_regmap_lookup_by_phandle(dev->of_node, "syscon"); > > > >>> } > > > >>> > > > >>> Instead of every device defining its own bespoke DT property to do the > > > >>> exact same thing. I did a quick "back of the envelope" grep on this > > > >>> and I get about 143 unique properties just to get the syscon regmap. > > > >>> $ git grep -A1 syscon_regmap_lookup_by_phandle | grep '"' | sed -e > > > >>> 's/^[^"]*//' -e 's/"[^"]*$/"/' | sort | uniq | wc -l > > > >>> 143 > > > >> > > > >> Sorry, generic "syscon" property won't fly with DT maintainers, because > > > >> there is no such thing as syscon in any of hardware. > > > > > > > > Then why do we allow a "syscon" compatible string and nodes? If the > > > > > > To bind Linux drivers. > > > > > > > "syscon" property isn't clear enough, we can make it something like > > > > gpios and have it be -syscon or have syscon-names property > > > > if you want to give it a name. > > > > > > This could work. > > > > I'm not opposed to this idea. The issue you'll have is keeping the > > kernel backwards compatible with older DTBs, thus this solution may only > > be possible for newly created bindings. More than happy to be proven > > wrong here though. > > You are right about backwards compatibility. Technically, we might be > able to fix up the DT at runtime (by keeping a list of those 143 > property names) to maintain backward compatibility, but I'm not > suggesting that. > > We can leave the existing ones as is, but we can at least use the new > property going forward to make dependencies easier to track and handle Automatic tracking and device linking sounds like a worthwhile endeavour. > -Saravana I nearly stopped reading here. > > > >>> How are we making sure that it's the exynos-pmu driver that ends up > > > >>> probing the PMU and not the generic syscon driver? Both of these are > > > >>> platform drivers. And the exynos PMU device lists both the exynos > > > >>> compatible string and the syscon property. Is it purely a link order > > > >>> coincidence? > > > >> > > > >> initcall ordering > > > > > > > > Both these drivers usr postcore_initcall(). So it's purely because > > > > soc/ is listed earlier in drivers/Makefile than mfd/. And as soon as > > > > > > Oh... great :/. > > > > Agree. > > > > Even using initcalls for ordering is fragile. Relying on the > > lexicographical order of a directory / filename structure is akin to > > rolling a dice. It would be far nicer if you are able to find a more > > robust method of ensuring load order e.g. dynamically poking at > > hardware and / or utilising -EPROBE_DEFER. > > Let me dig in to see if all the existing examples of listing syscon in > compatible AND have a different driver that needs to probe it always > list syscon as a secondary compatible string. In that case, we might > be able to make the syscon driver only match with the device it it's > the first entry in the compatible string. If using clever or non-obvious means by which to ensure correct ordering, I would suggest putting in place very obvious documentation/commentary verbosely describing the aim and method. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29684C47DDB for ; Fri, 26 Jan 2024 08:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PH3h5C0CJHcmlbiwzvd0DXY+VKuBtXx51msENdOaWDw=; b=DfGVwrMoBTN8En NUoQOI8HGdKJZwLvFaar/yDhXAF1mIos7mXp+meY17wLxffUucf4FWrHKpbMHhwDQqJ3E2/8rq+J+ d32ROlxVDozeqnxeUa3WibY2hV4F3Q3mciEGWhr8dDd4xoY8n4jFL/TH3gkYJUBTUGOGHkrTJlG7G v0DZBx+Kv7apNhHUy2mbE8AqsBbs4SzFTkhnzi65Re6c0SfduwfUhmchfPfS8NhXIFMWecqlC9lh5 JzCB2AKRndyHjDpSraTWEyoyC1k7h1e1v37cNY4G4LBm8BymePBd9v6xefdPsJcaLay1nOnveL9NP mT7/nc1VbE+B6rXF2zBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTHoo-00000003Twn-43Up; Fri, 26 Jan 2024 08:44:10 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTHoS-00000003Ttc-3uTI for linux-arm-kernel@lists.infradead.org; Fri, 26 Jan 2024 08:43:50 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 36DCF6242B; Fri, 26 Jan 2024 08:43:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 602D4C43390; Fri, 26 Jan 2024 08:43:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706258597; bh=oF5B98tG35oUypgTR8kLKZMFEniob38hECdwFh7l1QQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H3GHN50VuE1DHNfCijXJC7+XCojgFCv2Nw+68NOngbB7oeLYFAyR/QpNPDD6Opuiu lhdOSkh7lOsjYGr+aI3qY6V671pKlUvyIGsOuGGzyYUVJqxsqBPeUEM1Fn0q/6ZB74 7X9xC/3zvNK0i84Y+C1CnBLXYC5GbkCuPOHd4GYBTQvZEqICAAIw4X5Usf3A9CjHbZ KIajHUBfH1QnMC1fYx7trdyBOcQDIC4d/NSP/WgI2yRE5A0APmazNjcdXny6AjnTJn pVjdwC8U3nFwSpLEpfJ5qRo1bZ79o43izJldYZNv0wpeH3EORSUq45F1b2H2zPSddc SyhrXixVM0K/Q== Date: Fri, 26 Jan 2024 08:43:09 +0000 From: Lee Jones To: Saravana Kannan Cc: Krzysztof Kozlowski , Peter Griffin , arnd@arndb.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux@roeck-us.net, wim@linux-watchdog.org, conor+dt@kernel.org, alim.akhtar@samsung.com, jaewon02.kim@samsung.com, chanho61.park@samsung.com, semen.protsenko@linaro.org, kernel-team@android.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, willmcvicker@google.com, linux-fsd@tesla.com, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH 3/9] watchdog: s3c2410_wdt: update to use new exynos_pmu_*() apis Message-ID: <20240126084309.GM74950@google.com> References: <20240122225710.1952066-4-peter.griffin@linaro.org> <6c72a521-1048-42eb-ac74-d8f718a90723@linaro.org> <04411aaf-6f2c-4f43-83b4-aa0741ccd25f@linaro.org> <20240125114606.GA1327902@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240126_004349_133216_7F363516 X-CRM114-Status: GOOD ( 53.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyNSBKYW4gMjAyNCwgU2FyYXZhbmEgS2FubmFuIHdyb3RlOgoKPiBPbiBUaHUsIEph biAyNSwgMjAyNCBhdCAzOjQ24oCvQU0gTGVlIEpvbmVzIDxsZWVAa2VybmVsLm9yZz4gd3JvdGU6 Cj4gPgo+ID4gT24gVGh1LCAyNSBKYW4gMjAyNCwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToK PiA+Cj4gPiA+IE9uIDI0LzAxLzIwMjQgMjI6MjcsIFNhcmF2YW5hIEthbm5hbiB3cm90ZToKPiA+ ID4gPiBPbiBUdWUsIEphbiAyMywgMjAyNCBhdCAxMDoyN+KAr1BNIEtyenlzenRvZiBLb3psb3dz a2kKPiA+ID4gPiA8a3J6eXN6dG9mLmtvemxvd3NraUBsaW5hcm8ub3JnPiB3cm90ZToKPiA+ID4g Pj4KPiA+ID4gPj4gT24gMjQvMDEvMjAyNCAwNDozNywgU2FyYXZhbmEgS2FubmFuIHdyb3RlOgo+ ID4gPiA+Pj4gT24gVHVlLCBKYW4gMjMsIDIwMjQgYXQgMTA6MTLigK9BTSBLcnp5c3p0b2YgS296 bG93c2tpCj4gPiA+ID4+PiA8a3J6eXN6dG9mLmtvemxvd3NraUBsaW5hcm8ub3JnPiB3cm90ZToK PiA+ID4gPj4+Pgo+ID4gPiA+Pj4+IE9uIDIzLzAxLzIwMjQgMTg6MzAsIFBldGVyIEdyaWZmaW4g d3JvdGU6Cj4gPiA+ID4+Pj4+Pj4gICAgICAgICAgICAgICBkZXZfd2Fybih3ZHQtPmRldiwgIkNv dWxkbid0IGdldCBSU1RfU1RBVCByZWdpc3RlclxuIik7Cj4gPiA+ID4+Pj4+Pj4gICAgICAgZWxz ZSBpZiAocnN0X3N0YXQgJiBCSVQod2R0LT5kcnZfZGF0YS0+cnN0X3N0YXRfYml0KSkKPiA+ID4g Pj4+Pj4+PiBAQCAtNjk4LDE0ICs2OTksNiBAQCBzdGF0aWMgaW50IHMzYzI0MTB3ZHRfcHJvYmUo c3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiA+ID4gPj4+Pj4+PiAgICAgICBpZiAocmV0 KQo+ID4gPiA+Pj4+Pj4+ICAgICAgICAgICAgICAgcmV0dXJuIHJldDsKPiA+ID4gPj4+Pj4+Pgo+ ID4gPiA+Pj4+Pj4+IC0gICAgIGlmICh3ZHQtPmRydl9kYXRhLT5xdWlya3MgJiBRVUlSS1NfSEFW RV9QTVVSRUcpIHsKPiA+ID4gPj4+Pj4+PiAtICAgICAgICAgICAgIHdkdC0+cG11cmVnID0gc3lz Y29uX3JlZ21hcF9sb29rdXBfYnlfcGhhbmRsZShkZXYtPm9mX25vZGUsCj4gPiA+ID4+Pj4+Pj4g LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJzYW1zdW5nLHN5 c2Nvbi1waGFuZGxlIik7Cj4gPiA+ID4+Pj4+Pj4gLSAgICAgICAgICAgICBpZiAoSVNfRVJSKHdk dC0+cG11cmVnKSkKPiA+ID4gPj4+Pj4+PiAtICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGRl dl9lcnJfcHJvYmUoZGV2LCBQVFJfRVJSKHdkdC0+cG11cmVnKSwKPiA+ID4gPj4+Pj4+PiAtICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgInN5c2NvbiByZWdtYXAgbG9v a3VwIGZhaWxlZC5cbiIpOwo+ID4gPiA+Pj4+Pj4KPiA+ID4gPj4+Pj4+Cj4gPiA+ID4+Pj4+PiBD b250aW51aW5nIHRvcGljIGZyb20gdGhlIGJpbmRpbmc6IEkgZG9uJ3Qgc2VlIGhvdyB5b3UgaGFu ZGxlIHByb2JlCj4gPiA+ID4+Pj4+PiBkZWZlcnJhbCwgc3VzcGVuZCBvcmRlcmluZy4KPiA+ID4g Pj4+Pj4KPiA+ID4gPj4+Pj4gVGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gaXMgc2ltcGx5IHJl bHlpbmcgb24gZXh5bm9zLXBtdSBiZWluZwo+ID4gPiA+Pj4+PiBwb3N0Y29yZV9pbml0Y2FsbCBs ZXZlbC4KPiA+ID4gPj4+Pj4KPiA+ID4gPj4+Pj4gSSB3YXMganVzdCBsb29raW5nIGFyb3VuZCBm b3IgYW55IGV4aXN0aW5nIExpbnV4IEFQSXMgdGhhdCBjb3VsZCBiZSBhCj4gPiA+ID4+Pj4+IG1v cmUgcm9idXN0IHNvbHV0aW9uLiBJdCBsb29rcyBsaWtlCj4gPiA+ID4+Pj4+Cj4gPiA+ID4+Pj4+ IG9mX3BhcnNlX3BoYW5kbGUoKQo+ID4gPiA+Pj4+PiBhbmQKPiA+ID4gPj4+Pj4gb2ZfZmluZF9k ZXZpY2VfYnlfbm9kZSgpOwo+ID4gPiA+Pj4+Pgo+ID4gPiA+Pj4+PiBBcmUgb2Z0ZW4gdXNlZCB0 byBzb2x2ZSB0aGlzIHR5cGUgb2YgcHJvYmUgZGVmZXJyYWwgaXNzdWUgYmV0d2Vlbgo+ID4gPiA+ Pj4+PiBkZXZpY2VzLiBJcyB0aGF0IHdoYXQgeW91IHdvdWxkIHJlY29tbWVuZCB1c2luZz8gT3Ig aXMgdGhlcmUgc29tZXRoaW5nCj4gPiA+ID4+Pj4+IGV2ZW4gYmV0dGVyPwo+ID4gPiA+Pj4+Cj4g PiA+ID4+Pj4gSSB0aGluayB5b3Ugc2hvdWxkIGtlZXAgdGhlIHBoYW5kbGUgYW5kIHRoZW4gc2V0 IGRldmljZSBsaW5rIGJhc2VkIG9uCj4gPiA+ID4+Pj4gb2ZfZmluZF9kZXZpY2VfYnlfbm9kZSgp LiBUaGlzIHdvdWxkIGFjdHVhbGx5IGltcHJvdmUgdGhlIGNvZGUsIGJlY2F1c2UKPiA+ID4gPj4+ PiBzeXNjb25fcmVnbWFwX2xvb2t1cF9ieV9waGFuZGxlKCkgZG9lcyBub3QgY3JlYXRlIGRldmlj ZSBsaW5rcy4KPiA+ID4gPj4+Cj4gPiA+ID4+PiBJIGtpbmRhIGFncmVlIHdpdGggdGhpcy4gSnVz dCBiZWNhdXNlIHdlIG5vIGxvbmdlciB1c2UgYSBzeXNjb24gQVBJIHRvCj4gPiA+ID4+PiBmaW5k IHRoZSBQTVUgcmVnaXN0ZXIgYWRkcmVzcyBkb2Vzbid0IG1lYW4gdGhlIFdEVCBkb2Vzbid0IGRl cGVuZCBvbgo+ID4gPiA+Pj4gdGhlIFBNVS4KPiA+ID4gPj4+Cj4gPiA+ID4+PiBIb3dldmVyLCBJ IHRoaW5rIHdlIHNob3VsZCBtb3ZlIHRvIGEgZ2VuZXJpYyAic3lzY29uIiBwcm9wZXJ0eS4gVGhl biBJCj4gPiA+ID4+PiBjYW4gYWRkIHN1cHBvcnQgZm9yICJzeXNjb24iIHByb3BlcnR5IHRvIGZ3 X2RldmxpbmsgYW5kIHRoZW4gdGhpbmdzCj4gPiA+ID4+PiB3aWxsIGp1c3Qgd29yayBpbiB0ZXJt cyBvZiBwcm9iZSBvcmRlcmluZywgc3VzcGVuZC9yZXN1bWUgYW5kIGFsc28KPiA+ID4gPj4+IHNo b3dpbmcgdGhlIGRlcGVuZGVuY3kgaW4gRFQgZXZlbiBpZiB5b3UgZG9uJ3QgdXNlIHRoZSBzeXNj b24gQVBJcy4KPiA+ID4gPj4+Cj4gPiA+ID4+PiBTaWRlIG5vdGUgMToKPiA+ID4gPj4+Cj4gPiA+ ID4+PiBJIHRoaW5rIHdlIHJlYWxseSBzaG91bGQgb2ZmaWNpYWxseSBkb2N1bWVudCBhIGdlbmVy aWMgc3lzY29uIERUCj4gPiA+ID4+PiBwcm9wZXJ0eSBzaW1pbGFyIHRvIGhvdyB3ZSBoYXZlIGEg Z2VuZXJpYyAiY2xvY2tzIiBvciAiZG1hcyIgcHJvcGVydHkuCj4gPiA+ID4+PiBUaGVuIHdlIGNh biBoYXZlIGEgc3lzY29uX2dldF9yZWdtYXAoKSB0aGF0J3MgbGlrZSBzbzoKPiA+ID4gPj4+Cj4g PiA+ID4+PiBzdHJ1Y3QgcmVnbWFwICpzeXNjb25fZ2V0X3JlZ21hcChzdHJ1Y3QgZGV2aWNlICpk ZXYpCj4gPiA+ID4+PiB7Cj4gPiA+ID4+PiAgICAgICAgIHJldHVybiBzeXNjb25fcmVnbWFwX2xv b2t1cF9ieV9waGFuZGxlKGRldi0+b2Zfbm9kZSwgInN5c2NvbiIpOwo+ID4gPiA+Pj4gfQo+ID4g PiA+Pj4KPiA+ID4gPj4+IEluc3RlYWQgb2YgZXZlcnkgZGV2aWNlIGRlZmluaW5nIGl0cyBvd24g YmVzcG9rZSBEVCBwcm9wZXJ0eSB0byBkbyB0aGUKPiA+ID4gPj4+IGV4YWN0IHNhbWUgdGhpbmcu IEkgZGlkIGEgcXVpY2sgImJhY2sgb2YgdGhlIGVudmVsb3BlIiBncmVwIG9uIHRoaXMKPiA+ID4g Pj4+IGFuZCBJIGdldCBhYm91dCAxNDMgdW5pcXVlIHByb3BlcnRpZXMganVzdCB0byBnZXQgdGhl IHN5c2NvbiByZWdtYXAuCj4gPiA+ID4+PiAkIGdpdCBncmVwIC1BMSBzeXNjb25fcmVnbWFwX2xv b2t1cF9ieV9waGFuZGxlIHwgZ3JlcCAnIicgfCBzZWQgLWUKPiA+ID4gPj4+ICdzL15bXiJdKi8v JyAtZSAncy8iW14iXSokLyIvJyB8IHNvcnQgfCB1bmlxIHwgd2MgLWwKPiA+ID4gPj4+IDE0Mwo+ ID4gPiA+Pgo+ID4gPiA+PiBTb3JyeSwgZ2VuZXJpYyAic3lzY29uIiBwcm9wZXJ0eSB3b24ndCBm bHkgd2l0aCBEVCBtYWludGFpbmVycywgYmVjYXVzZQo+ID4gPiA+PiB0aGVyZSBpcyBubyBzdWNo IHRoaW5nIGFzIHN5c2NvbiBpbiBhbnkgb2YgaGFyZHdhcmUuCj4gPiA+ID4KPiA+ID4gPiBUaGVu IHdoeSBkbyB3ZSBhbGxvdyBhICJzeXNjb24iIGNvbXBhdGlibGUgc3RyaW5nIGFuZCBub2Rlcz8g SWYgdGhlCj4gPiA+Cj4gPiA+IFRvIGJpbmQgTGludXggZHJpdmVycy4KPiA+ID4KPiA+ID4gPiAi c3lzY29uIiBwcm9wZXJ0eSBpc24ndCBjbGVhciBlbm91Z2gsIHdlIGNhbiBtYWtlIGl0IHNvbWV0 aGluZyBsaWtlCj4gPiA+ID4gZ3Bpb3MgYW5kIGhhdmUgaXQgYmUgPHdoYXRldmVyPi1zeXNjb24g b3IgaGF2ZSBzeXNjb24tbmFtZXMgcHJvcGVydHkKPiA+ID4gPiBpZiB5b3Ugd2FudCB0byBnaXZl IGl0IGEgbmFtZS4KPiA+ID4KPiA+ID4gVGhpcyBjb3VsZCB3b3JrLgo+ID4KPiA+IEknbSBub3Qg b3Bwb3NlZCB0byB0aGlzIGlkZWEuICBUaGUgaXNzdWUgeW91J2xsIGhhdmUgaXMga2VlcGluZyB0 aGUKPiA+IGtlcm5lbCBiYWNrd2FyZHMgY29tcGF0aWJsZSB3aXRoIG9sZGVyIERUQnMsIHRodXMg dGhpcyBzb2x1dGlvbiBtYXkgb25seQo+ID4gYmUgcG9zc2libGUgZm9yIG5ld2x5IGNyZWF0ZWQg YmluZGluZ3MuICBNb3JlIHRoYW4gaGFwcHkgdG8gYmUgcHJvdmVuCj4gPiB3cm9uZyBoZXJlIHRo b3VnaC4KPiAKPiBZb3UgYXJlIHJpZ2h0IGFib3V0IGJhY2t3YXJkcyBjb21wYXRpYmlsaXR5LiBU ZWNobmljYWxseSwgd2UgbWlnaHQgYmUKPiBhYmxlIHRvIGZpeCB1cCB0aGUgRFQgYXQgcnVudGlt ZSAoYnkga2VlcGluZyBhIGxpc3Qgb2YgdGhvc2UgMTQzCj4gcHJvcGVydHkgbmFtZXMpIHRvIG1h aW50YWluIGJhY2t3YXJkIGNvbXBhdGliaWxpdHksIGJ1dCBJJ20gbm90Cj4gc3VnZ2VzdGluZyB0 aGF0Lgo+IAo+IFdlIGNhbiBsZWF2ZSB0aGUgZXhpc3Rpbmcgb25lcyBhcyBpcywgYnV0IHdlIGNh biBhdCBsZWFzdCB1c2UgdGhlIG5ldwo+IHByb3BlcnR5IGdvaW5nIGZvcndhcmQgdG8gbWFrZSBk ZXBlbmRlbmNpZXMgZWFzaWVyIHRvIHRyYWNrIGFuZCBoYW5kbGUKCkF1dG9tYXRpYyB0cmFja2lu ZyBhbmQgZGV2aWNlIGxpbmtpbmcgc291bmRzIGxpa2UgYSB3b3J0aHdoaWxlIGVuZGVhdm91ci4K Cj4gLVNhcmF2YW5hCgpJIG5lYXJseSBzdG9wcGVkIHJlYWRpbmcgaGVyZS4KCj4gPiA+ID4+PiBI b3cgYXJlIHdlIG1ha2luZyBzdXJlIHRoYXQgaXQncyB0aGUgZXh5bm9zLXBtdSBkcml2ZXIgdGhh dCBlbmRzIHVwCj4gPiA+ID4+PiBwcm9iaW5nIHRoZSBQTVUgYW5kIG5vdCB0aGUgZ2VuZXJpYyBz eXNjb24gZHJpdmVyPyBCb3RoIG9mIHRoZXNlIGFyZQo+ID4gPiA+Pj4gcGxhdGZvcm0gZHJpdmVy cy4gQW5kIHRoZSBleHlub3MgUE1VIGRldmljZSBsaXN0cyBib3RoIHRoZSBleHlub3MKPiA+ID4g Pj4+IGNvbXBhdGlibGUgc3RyaW5nIGFuZCB0aGUgc3lzY29uIHByb3BlcnR5LiBJcyBpdCBwdXJl bHkgYSBsaW5rIG9yZGVyCj4gPiA+ID4+PiBjb2luY2lkZW5jZT8KPiA+ID4gPj4KPiA+ID4gPj4g aW5pdGNhbGwgb3JkZXJpbmcKPiA+ID4gPgo+ID4gPiA+IEJvdGggdGhlc2UgZHJpdmVycyB1c3Ig cG9zdGNvcmVfaW5pdGNhbGwoKS4gU28gaXQncyBwdXJlbHkgYmVjYXVzZQo+ID4gPiA+IHNvYy8g aXMgbGlzdGVkIGVhcmxpZXIgaW4gZHJpdmVycy9NYWtlZmlsZSB0aGFuIG1mZC8uIEFuZCBhcyBz b29uIGFzCj4gPiA+Cj4gPiA+IE9oLi4uIGdyZWF0IDovLgo+ID4KPiA+IEFncmVlLgo+ID4KPiA+ IEV2ZW4gdXNpbmcgaW5pdGNhbGxzIGZvciBvcmRlcmluZyBpcyBmcmFnaWxlLiAgUmVseWluZyBv biB0aGUKPiA+IGxleGljb2dyYXBoaWNhbCBvcmRlciBvZiBhIGRpcmVjdG9yeSAvIGZpbGVuYW1l IHN0cnVjdHVyZSBpcyBha2luIHRvCj4gPiByb2xsaW5nIGEgZGljZS4gIEl0IHdvdWxkIGJlIGZh ciBuaWNlciBpZiB5b3UgYXJlIGFibGUgdG8gZmluZCBhIG1vcmUKPiA+IHJvYnVzdCBtZXRob2Qg b2YgZW5zdXJpbmcgbG9hZCBvcmRlciBlLmcuIGR5bmFtaWNhbGx5IHBva2luZyBhdAo+ID4gaGFy ZHdhcmUgYW5kIC8gb3IgdXRpbGlzaW5nIC1FUFJPQkVfREVGRVIuCj4gCj4gTGV0IG1lIGRpZyBp biB0byBzZWUgaWYgYWxsIHRoZSBleGlzdGluZyBleGFtcGxlcyBvZiBsaXN0aW5nIHN5c2NvbiBp bgo+IGNvbXBhdGlibGUgQU5EIGhhdmUgYSBkaWZmZXJlbnQgZHJpdmVyIHRoYXQgbmVlZHMgdG8g cHJvYmUgaXQgYWx3YXlzCj4gbGlzdCBzeXNjb24gYXMgYSBzZWNvbmRhcnkgY29tcGF0aWJsZSBz dHJpbmcuIEluIHRoYXQgY2FzZSwgd2UgbWlnaHQKPiBiZSBhYmxlIHRvIG1ha2UgdGhlIHN5c2Nv biBkcml2ZXIgb25seSBtYXRjaCB3aXRoIHRoZSBkZXZpY2UgaXQgaXQncwo+IHRoZSBmaXJzdCBl bnRyeSBpbiB0aGUgY29tcGF0aWJsZSBzdHJpbmcuCgpJZiB1c2luZyBjbGV2ZXIgb3Igbm9uLW9i dmlvdXMgbWVhbnMgYnkgd2hpY2ggdG8gZW5zdXJlIGNvcnJlY3QKb3JkZXJpbmcsIEkgd291bGQg c3VnZ2VzdCBwdXR0aW5nIGluIHBsYWNlIHZlcnkgb2J2aW91cwpkb2N1bWVudGF0aW9uL2NvbW1l bnRhcnkgdmVyYm9zZWx5IGRlc2NyaWJpbmcgdGhlIGFpbSBhbmQgbWV0aG9kLgoKLS0gCkxlZSBK b25lcyBb5p2O55C85pavXQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=