From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, tj@kernel.org,
jiangshanlai@gmail.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH, RFC] block: set noio context in submit_bio_noacct_nocheck
Date: Fri, 26 Jan 2024 14:52:24 +0100 [thread overview]
Message-ID: <20240126135224.GA3368@lst.de> (raw)
In-Reply-To: <6c4a4cf3-c5ed-4236-a6b2-9d53e927f979@kernel.dk>
On Thu, Jan 25, 2024 at 09:13:37AM -0700, Jens Axboe wrote:
> > Nono, you don't understand. The plan is to remove GFP_NOIO
> > entirely. Allocations should be done with GFP_KERNEL while under a
> > memalloc_noio_save().
>
> I do understand, but thanks for the vote of confidence. Place the
> save/restore higher up, most likely actual IO submission isn't going to
> be the only (or even major) allocation potentially needed for the IO.
NOIO is defined as allocations that will not recurse into the I/O stack.
So for anything block based, entering the block layer is literally
the defined boundary where it should be used below. So no, wrapping
every submit_bio into a context annotation doesn't make much sense.
prev parent reply other threads:[~2024-01-26 13:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 9:39 [PATCH, RFC] block: set noio context in submit_bio_noacct_nocheck Christoph Hellwig
2024-01-24 15:40 ` Jens Axboe
2024-01-25 8:10 ` Christoph Hellwig
2024-01-25 16:09 ` Jens Axboe
2024-01-25 16:11 ` Matthew Wilcox
2024-01-25 16:13 ` Jens Axboe
2024-01-26 13:52 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240126135224.GA3368@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jiangshanlai@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.