From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAE821DA37 for ; Fri, 26 Jan 2024 15:44:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706283871; cv=none; b=U7VyjdM55kpmpqdhnxw6ZAvSNWPv0evktaFA1H7U2wFoUb1VdyldG7Gl35oqe3JNGEoZoq1NufUkwF9vOQXaCNUUf4g9doHFo0hGN3z5jcgvg263rWXSEnf8CD/fEBVPy6uL9n3vmTFCV7emv+/1wEd0v4Im52qafecrSNmNQjs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706283871; c=relaxed/simple; bh=UiLdiIVvMb83SWw7AGXvISH8OI0rahijuASgroB/Hlk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cFCRr3jWYBrrZUFc2pqRnXIjotSqRdomAdwtfRUSwCqScOLIhOXBXyf0G30QSS4bFNgvtMgf+Xy492mIldp+yBO7UTMxGeuQy1ruep9abT55EkGpE8Y3/IfrtOvojjYY2YOQwIL5C6xKzykD2fVP8pnNUg1o/FfVcCVVRrbJsk4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=gPPgMTm7; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="gPPgMTm7" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-6de424cef01so273285a34.2 for ; Fri, 26 Jan 2024 07:44:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1706283869; x=1706888669; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ifj3vKt8QC0k+Lvrl/eE4vaSsPq+S4SksoQKXsBRSXc=; b=gPPgMTm75K2cseziOW46cLpianvr7AsSyyg27B9FiNIL8x8T9U/Gv4H9G9/CVPFJ8E qTZs1Jdv1Z9GaSlPYI0gIgD/ZA/e2cKJs7AaHIa3RyBQ6BVsDibfWn1UFv+0g6G7ufIY MEppKtrsgkCRS+ldYzhSWgMbscKKwDzn88YU2hlBpV+CFNMWSOpVHXQRmZ36ZMRwQ3xd kcSddFZX4ug3+8Z7RjTExBbvRDvusKr4t/8cYWLYi+AOZFFFSVrI/Z0cTvKGbtGeKIkv GSOFf++txJqx9xClAbjrRIbsag7fKPTdJEr4gwQsyJa/i/SCL6QbF8sPpntQK/qbkC+/ JNtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706283869; x=1706888669; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ifj3vKt8QC0k+Lvrl/eE4vaSsPq+S4SksoQKXsBRSXc=; b=YosnihBB/LO9f2jE0rw4ZFiweozG9SckQ2YviFbIO2C2FZdo5DUIXIMdIg0+oQY7vH Ddn4PbLLTwAGpuYCJjNml9Q4z06QK34S5P7VICaao/9rN+u5eXyNxVx0srs9LOCwwTd1 /KQXNEWm/flRtQvsIXQLeiHxbBXjwPPeuH9mc+QI4WQFq1GorSccM3NeTixwhMwJxnt0 5hvq7BAUn0ww8QmS2Fn0Lgvd5692u/420d3QSDumDbgdueSE70AKL/eO6nMC7vwyQe+l 645E6qviuvGA8xFk7KMOFpUbAuGaM7hNCgyIoOsMjTycY7e8t2dQ2TFU9VjRdOiMz0qY WSLg== X-Gm-Message-State: AOJu0Yy2RZ1q5NsgFC3D7oVjnlzsnb369Hvb107KB+oCGC+sglz/CEjq 5ait1oOqa2pO2gwZHG6mQu1WsrNktrqlZS+TdnItKW23m3aztxdiYi2EyZIDNew= X-Google-Smtp-Source: AGHT+IHvXs9zt8rzQimULCxVKWRw2gBSkFT+WcT7r0xChxJT011B7UN6s63xs55ItZMqKHL08VvUaA== X-Received: by 2002:a05:6871:2787:b0:214:2544:bfd9 with SMTP id zd7-20020a056871278700b002142544bfd9mr955769oab.43.1706283869008; Fri, 26 Jan 2024 07:44:29 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-80-239.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.80.239]) by smtp.gmail.com with ESMTPSA id pl10-20020a0568704e0a00b0021837cadf53sm200549oab.39.2024.01.26.07.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 07:44:28 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1rTONX-009SCu-NX; Fri, 26 Jan 2024 11:44:27 -0400 Date: Fri, 26 Jan 2024 11:44:27 -0400 From: Jason Gunthorpe To: Timothy Pearson Cc: Shivaprasad G Bhat , iommu , linuxppc-dev , linux-kernel , Michael Ellerman , npiggin , christophe leroy , aneesh kumar , naveen n rao , jroedel , aik , bgray , Greg Kroah-Hartman , gbatra , vaibhav Subject: Re: [PATCH 1/2] powerpc: iommu: Bring back table group release_ownership() call Message-ID: <20240126154427.GB50608@ziepe.ca> References: <170618450592.3805.8216395093813382208.stgit@ltcd48-lp2.aus.stglab.ibm.com> <170618451433.3805.9015493852395837391.stgit@ltcd48-lp2.aus.stglab.ibm.com> <20240125155017.GW50608@ziepe.ca> <20240126151701.GZ50608@ziepe.ca> <392247278.10124607.1706282995795.JavaMail.zimbra@raptorengineeringinc.com> <20240126153806.GA50608@ziepe.ca> <1453449220.10126352.1706283596477.JavaMail.zimbra@raptorengineeringinc.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453449220.10126352.1706283596477.JavaMail.zimbra@raptorengineeringinc.com> On Fri, Jan 26, 2024 at 09:39:56AM -0600, Timothy Pearson wrote: > > Just forget about the weird KVM and SPAPR stuff, leave it under the > > kconfig of the old code and nobody will run it. Almost nobody already > > runs it, apparently. > > We actually use QEMU/KVM/VFIO extensively at Raptor, so need the > support and need it to be performant... I wonder if you alone are the "almost" :) The KVM entanglement was hairy and scary. I never did figure out what was really going on there. Maybe you don't need all of it and can be successful with a more typical iommu working model? Suggest to tackle it after getting the first parts done. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DDC1C47422 for ; Fri, 26 Jan 2024 15:45:53 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=AAPetc1G; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TM28v6cxGz3dV1 for ; Sat, 27 Jan 2024 02:45:51 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=AAPetc1G; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ziepe.ca (client-ip=2001:4860:4864:20::34; helo=mail-oa1-x34.google.com; envelope-from=jgg@ziepe.ca; receiver=lists.ozlabs.org) Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TM27S0Yyrz3cXP for ; Sat, 27 Jan 2024 02:44:35 +1100 (AEDT) Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-206689895bfso328274fac.1 for ; Fri, 26 Jan 2024 07:44:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1706283869; x=1706888669; darn=lists.ozlabs.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ifj3vKt8QC0k+Lvrl/eE4vaSsPq+S4SksoQKXsBRSXc=; b=AAPetc1GAC9XSjJZKHobGSQKkBYEKoe1dedT3WSNipzVEb7zofeo3xqpIgz7BEiDOY i5wz2d0lW76880x6ugp6mtSVV/nXmdkEnkvK6YmUCGxDSBJ627S6NthW3Z2UaCL98hDR xSRjs4PXqczMAEvUOoLCRNSrV2bb5O/xejUxDsuNyN86jSRaa6B9ApjCnZ5kFCY3KgYt p0uFz1G3+YziJZSZrlVTh+89wGXgoXjdX4VrviTQiW/lIPDfznsoD7CD0Eo6T2fIIA1z H6ztnvXv4QV/igezUjMreucBmSK6XEXRDg/eVkksnnNEGxlroxx5HMbHX+aNPzbF4Vch BFvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706283869; x=1706888669; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ifj3vKt8QC0k+Lvrl/eE4vaSsPq+S4SksoQKXsBRSXc=; b=C1w4olEMYG8O1lcOaSBPxHG+hmNApokqOVXQFCCxJqxG5B1nUk870OsaKwPXxMCBlm DoE+yZmGfwOCLoRvhew4pCB2sdMmW1LraYd/ApaZOAJraYxkSgzNBlZwJI35QmcpyOl8 /wdWwy4Nvv6YmecMzIkQYewYf6odiWUsSx/w7mc1IU6LsFAw5AgH99iCWv+XvZ6lAAlB F5XJT7wN12cMJz9YD0xPjJDgraSRQYyq87zqp76iD/TyqQLST4oSIwZwcMPZvejeXZ28 0nhoaP1kUHnhyi0A5mpTS/JLojzqRC89lMitjiUzcKEkYIT9pG3zMEidQTMd7ln9qpxS 720w== X-Gm-Message-State: AOJu0Yxbqlrzr1fLI54tOJm88P2jojHgw6bjr+/+n5yfT6KPCrUCqgy7 xvL1OD0rrRKpFheit26DzNyeFBMb2qxtY5NKPUnCrzk+5rC+qID59F3TT/IISfc= X-Google-Smtp-Source: AGHT+IHvXs9zt8rzQimULCxVKWRw2gBSkFT+WcT7r0xChxJT011B7UN6s63xs55ItZMqKHL08VvUaA== X-Received: by 2002:a05:6871:2787:b0:214:2544:bfd9 with SMTP id zd7-20020a056871278700b002142544bfd9mr955769oab.43.1706283869008; Fri, 26 Jan 2024 07:44:29 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-80-239.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.80.239]) by smtp.gmail.com with ESMTPSA id pl10-20020a0568704e0a00b0021837cadf53sm200549oab.39.2024.01.26.07.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 07:44:28 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1rTONX-009SCu-NX; Fri, 26 Jan 2024 11:44:27 -0400 Date: Fri, 26 Jan 2024 11:44:27 -0400 From: Jason Gunthorpe To: Timothy Pearson Subject: Re: [PATCH 1/2] powerpc: iommu: Bring back table group release_ownership() call Message-ID: <20240126154427.GB50608@ziepe.ca> References: <170618450592.3805.8216395093813382208.stgit@ltcd48-lp2.aus.stglab.ibm.com> <170618451433.3805.9015493852395837391.stgit@ltcd48-lp2.aus.stglab.ibm.com> <20240125155017.GW50608@ziepe.ca> <20240126151701.GZ50608@ziepe.ca> <392247278.10124607.1706282995795.JavaMail.zimbra@raptorengineeringinc.com> <20240126153806.GA50608@ziepe.ca> <1453449220.10126352.1706283596477.JavaMail.zimbra@raptorengineeringinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453449220.10126352.1706283596477.JavaMail.zimbra@raptorengineeringinc.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jroedel , gbatra , Shivaprasad G Bhat , Greg Kroah-Hartman , linux-kernel , npiggin , aneesh kumar , iommu , bgray , naveen n rao , vaibhav , linuxppc-dev , aik Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Jan 26, 2024 at 09:39:56AM -0600, Timothy Pearson wrote: > > Just forget about the weird KVM and SPAPR stuff, leave it under the > > kconfig of the old code and nobody will run it. Almost nobody already > > runs it, apparently. > > We actually use QEMU/KVM/VFIO extensively at Raptor, so need the > support and need it to be performant... I wonder if you alone are the "almost" :) The KVM entanglement was hairy and scary. I never did figure out what was really going on there. Maybe you don't need all of it and can be successful with a more typical iommu working model? Suggest to tackle it after getting the first parts done. Jason