From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FDDD1B279 for ; Sat, 27 Jan 2024 21:58:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706392684; cv=none; b=SMAHwwaahvTclwSavNmY8SNFBqaoXT9oGc1VcYFytgqG11wy1UbIH9zPv8I4TDVV3eTE6l3a/cCIKfyHGYuS+jiZK6ZF7OeiaypDXYU8xKFB709P0flOvC8dVJl5J9Rh9QbSPH51+U2iEFxSe6+kdsh4NkjtPqKXu1J4pCr/sf8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706392684; c=relaxed/simple; bh=hjWlbt71ooor4mjgLsSRedYuAK4SZMB9oA22OV34zgQ=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=nT/8EkZAd+XQhunkPpifXt5bwpfG31QTk6iqPztXDpgUks5A3vRKe/jiIEkBaMc87uGJfnTCK/e22v6V4eImErNoMpbLbJAaGQlU0ojrN6DGUaUAPq9KwvTz4bpkmgWFFLTDne9RW/l3/Uj2GUyWOKUKcJzVmG66gOMW0OvG2Ao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DIkCgyXO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DIkCgyXO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8744C433C7; Sat, 27 Jan 2024 21:58:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706392684; bh=hjWlbt71ooor4mjgLsSRedYuAK4SZMB9oA22OV34zgQ=; h=Subject:To:Cc:From:Date:From; b=DIkCgyXOK+pDZjBFOrqm/YaAURpnRbPLr+hwjppvE/Rp+OWBKSl8mR36s91zs9Tir oSk6uid3dVutkrY+ExnLNKvy8Dn7rOv32Hfp6RkGIkYzYQo9FrzCOplNYVGWSRfaeM 3E5Y4p0Qrayl5ICqT5GJZLDXCiJgw3MCWeNeEAdc= Subject: FAILED: patch "[PATCH] btrfs: zoned: optimize hint byte for zoned allocator" failed to apply to 6.7-stable tree To: naohiro.aota@wdc.com,dsterba@suse.com,johannes.thumshirn@wdc.com Cc: From: Date: Sat, 27 Jan 2024 13:58:03 -0800 Message-ID: <2024012702-algorithm-mongoose-277c@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.7-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.7.y git checkout FETCH_HEAD git cherry-pick -x 02444f2ac26eae6385a65fcd66915084d15dffba # git commit -s git send-email --to '' --in-reply-to '2024012702-algorithm-mongoose-277c@gregkh' --subject-prefix 'PATCH 6.7.y' HEAD^.. Possible dependencies: 02444f2ac26e ("btrfs: zoned: optimize hint byte for zoned allocator") b271fee9a41c ("btrfs: zoned: factor out prepare_allocation_zoned()") thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 02444f2ac26eae6385a65fcd66915084d15dffba Mon Sep 17 00:00:00 2001 From: Naohiro Aota Date: Tue, 19 Dec 2023 01:02:29 +0900 Subject: [PATCH] btrfs: zoned: optimize hint byte for zoned allocator Writing sequentially to a huge file on btrfs on a SMR HDD revealed a decline of the performance (220 MiB/s to 30 MiB/s after 500 minutes). The performance goes down because of increased latency of the extent allocation, which is induced by a traversing of a lot of full block groups. So, this patch optimizes the ffe_ctl->hint_byte by choosing a block group with sufficient size from the active block group list, which does not contain full block groups. After applying the patch, the performance is maintained well. Fixes: 2eda57089ea3 ("btrfs: zoned: implement sequential extent allocation") CC: stable@vger.kernel.org # 5.15+ Reviewed-by: Johannes Thumshirn Signed-off-by: Naohiro Aota Signed-off-by: David Sterba diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index d260b970bec7..6d680031211a 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -4311,6 +4311,24 @@ static int prepare_allocation_zoned(struct btrfs_fs_info *fs_info, if (fs_info->data_reloc_bg) ffe_ctl->hint_byte = fs_info->data_reloc_bg; spin_unlock(&fs_info->relocation_bg_lock); + } else if (ffe_ctl->flags & BTRFS_BLOCK_GROUP_DATA) { + struct btrfs_block_group *block_group; + + spin_lock(&fs_info->zone_active_bgs_lock); + list_for_each_entry(block_group, &fs_info->zone_active_bgs, active_bg_list) { + /* + * No lock is OK here because avail is monotinically + * decreasing, and this is just a hint. + */ + u64 avail = block_group->zone_capacity - block_group->alloc_offset; + + if (block_group_bits(block_group, ffe_ctl->flags) && + avail >= ffe_ctl->num_bytes) { + ffe_ctl->hint_byte = block_group->start; + break; + } + } + spin_unlock(&fs_info->zone_active_bgs_lock); } return 0;