From: Oleg Nesterov <oleg@redhat.com>
To: Tycho Andersen <tycho@tycho.pizza>
Cc: Christian Brauner <brauner@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Tycho Andersen <tandersen@netflix.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] pidfd: don't do_notify_pidfd() if !thread_group_empty()
Date: Sat, 27 Jan 2024 20:32:05 +0100 [thread overview]
Message-ID: <20240127193204.GD13787@redhat.com> (raw)
In-Reply-To: <ZbU72/83nv2UdcCK@tycho.pizza>
On 01/27, Tycho Andersen wrote:
>
> On Sat, Jan 27, 2024 at 02:21:05PM +0100, Oleg Nesterov wrote:
> > do_notify_pidfd() makes no sense until the whole thread group exits, change
> > do_notify_parent() to check thread_group_empty().
> >
> > This avoids the unnecessary do_notify_pidfd() when tsk is not a leader, or
> > it exits before other threads, or it has a ptraced EXIT_ZOMBIE sub-thread.
> >
> > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
>
> Looks good to me, thanks.
>
> Reviewed-by: Tycho Andersen <tandersen@netflix.com>
Thanks Tycho,
Oleg.
next prev parent reply other threads:[~2024-01-27 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 13:20 [PATCH 0/1] pidfd: don't do_notify_pidfd() if !thread_group_empty() Oleg Nesterov
2024-01-27 13:21 ` [PATCH 1/1] " Oleg Nesterov
2024-01-27 17:22 ` Tycho Andersen
2024-01-27 19:32 ` Oleg Nesterov [this message]
2024-01-27 13:24 ` Oleg Nesterov
2024-01-29 13:55 ` [PATCH 0/1] " Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240127193204.GD13787@redhat.com \
--to=oleg@redhat.com \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tandersen@netflix.com \
--cc=tycho@tycho.pizza \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.