From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org
Cc: David Lechner <dlechner@baylibre.com>,
Peter Zijlstra <peterz@infradead.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: [PATCH 00/10] IIO: Use the new cleanup.h magic
Date: Sun, 28 Jan 2024 15:05:27 +0000 [thread overview]
Message-ID: <20240128150537.44592-1-jic23@kernel.org> (raw)
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
The prerequisites are now in place upstream, so this series can now
introduce the infrastructure and apply it to a few drivers.
Changes since RFC v2: Thanks to David Lechner for review
- Use unreachable() instead of misleading returns in paths we can't reach.
- Various minor tweaks and local variable scope reduction.
A lot of the advantages of the automated cleanup added for locks and similar
are not that useful in IIO unless we also deal with the
iio_device_claim_direct_mode() / iio_device_release_direct_mode()
calls that prevent IIO device drivers from transitioning into buffered
mode whilst calls are in flight + prevent sysfs reads and writes from
interfering with buffered capture if it is enabled.
This can now be neatly done using new scoped_cond_guard() to elegantly
return if the attempt to claim direct mode fails.
The need to always handle what happens after
iio_device_claim_direct_scoped() {} is a little irritating but the
compiler will warn if you don't do it and it's not obvious how to
let the compiler know the magic loop (hidden in the cleanup.h macros)
always runs once. Example:
iio_device_claim_direct_scoped(return -EBUSY, indio_dev) {
return 42;
}
/* Can't get here, but compiler about no return val without this */
unreachable();
}
Jonathan Cameron (10):
iio: locking: introduce __cleanup() based direct mode claiming
infrastructure
iio: dummy: Use automatic lock and direct mode cleanup.
iio: accel: adxl367: Use automated cleanup for locks and iio direct
mode.
iio: imu: bmi323: Use cleanup handling for
iio_device_claim_direct_mode()
iio: adc: max1363: Use automatic cleanup for locks and iio mode
claiming.
iio: proximity: sx9360: Use automated cleanup for locks and IIO mode
claiming.
iio: proximity: sx9324: Use automated cleanup for locks and IIO mode
claiming.
iio: proximity: sx9310: Use automated cleanup for locks and IIO mode
claiming.
iio: adc: ad4130: Use automatic cleanup of locks and direct mode.
iio: adc: ad7091r-base: Use auto cleanup of locks.
drivers/iio/accel/adxl367.c | 297 +++++++++++----------------
drivers/iio/adc/ad4130.c | 131 +++++-------
drivers/iio/adc/ad7091r-base.c | 25 +--
drivers/iio/adc/max1363.c | 171 +++++++--------
drivers/iio/dummy/iio_simple_dummy.c | 182 ++++++++--------
drivers/iio/imu/bmi323/bmi323_core.c | 78 +++----
drivers/iio/proximity/sx9310.c | 114 ++++------
drivers/iio/proximity/sx9324.c | 109 ++++------
drivers/iio/proximity/sx9360.c | 115 ++++-------
include/linux/iio/iio.h | 25 +++
10 files changed, 518 insertions(+), 729 deletions(-)
--
2.43.0
next reply other threads:[~2024-01-28 15:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 15:05 Jonathan Cameron [this message]
2024-01-28 15:05 ` [PATCH 01/10] iio: locking: introduce __cleanup() based direct mode claiming infrastructure Jonathan Cameron
2024-02-04 16:26 ` andy.shevchenko
2024-02-04 17:42 ` Jonathan Cameron
2024-01-28 15:05 ` [PATCH 02/10] iio: dummy: Use automatic lock and direct mode cleanup Jonathan Cameron
2024-01-28 21:52 ` David Lechner
2024-01-29 11:46 ` Jonathan Cameron
2024-01-29 19:58 ` Jonathan Cameron
2024-01-29 20:05 ` David Lechner
2024-02-04 16:29 ` andy.shevchenko
2024-02-04 17:41 ` Jonathan Cameron
2024-01-28 15:05 ` [PATCH 03/10] iio: accel: adxl367: Use automated cleanup for locks and iio direct mode Jonathan Cameron
2024-01-30 12:53 ` Nuno Sá
2024-02-04 13:48 ` Jonathan Cameron
2024-02-05 8:27 ` Nuno Sá
2024-01-28 15:05 ` [PATCH 04/10] iio: imu: bmi323: Use cleanup handling for iio_device_claim_direct_mode() Jonathan Cameron
2024-01-28 15:05 ` [PATCH 05/10] iio: adc: max1363: Use automatic cleanup for locks and iio mode claiming Jonathan Cameron
2024-01-28 15:05 ` [PATCH 06/10] iio: proximity: sx9360: Use automated cleanup for locks and IIO " Jonathan Cameron
2024-01-28 15:05 ` [PATCH 07/10] iio: proximity: sx9324: " Jonathan Cameron
2024-01-28 15:05 ` [PATCH 08/10] iio: proximity: sx9310: " Jonathan Cameron
2024-01-28 15:05 ` [PATCH 09/10] iio: adc: ad4130: Use automatic cleanup of locks and direct mode Jonathan Cameron
2024-01-28 15:05 ` [PATCH 10/10] iio: adc: ad7091r-base: Use auto cleanup of locks Jonathan Cameron
2024-01-30 14:08 ` [PATCH 00/10] IIO: Use the new cleanup.h magic Nuno Sá
2024-02-04 16:06 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240128150537.44592-1-jic23@kernel.org \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.