From: Christoph Hellwig <hch@lst.de>
To: hare@kernel.org
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>,
Martin George <marting@netapp.com>
Subject: Re: [PATCH 3/3] nvme: enable retries for authentication commands
Date: Mon, 29 Jan 2024 07:00:05 +0100 [thread overview]
Message-ID: <20240129060005.GC19136@lst.de> (raw)
In-Reply-To: <20240127093746.40246-4-hare@kernel.org>
On Sat, Jan 27, 2024 at 10:37:46AM +0100, hare@kernel.org wrote:
> From: Hannes Reinecke <hare@suse.de>
>
> Authentication commands are normal NVMe commands, and as such
> can return a status where NVME_SC_DNR is not set, indicating
> that the command should be retried.
What command is not normal?
> This patch enables retries by setting NVME_SUBMIT_RETRY for
> __nvme_submit_sync_cmd().
I think what should go into the commit log is why the retries are
desirable here, and not for other admin commands.
Otherwise this looks good to me.
next prev parent reply other threads:[~2024-01-29 6:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 9:37 [PATCHv3 0/3] nvme: enable retries for authentication commands hare
2024-01-27 9:37 ` [PATCH 1/3] nvme-auth: open-code single-use macros hare
2024-01-29 5:58 ` Christoph Hellwig
2024-01-29 14:19 ` Sagi Grimberg
2024-01-29 15:13 ` Keith Busch
2024-01-27 9:37 ` [PATCH 2/3] nvme: simplify __nvme_submit_sync_cmd() calling conventions hare
2024-01-27 18:00 ` Nicky Chorley
2024-01-29 5:59 ` Christoph Hellwig
2024-01-27 9:37 ` [PATCH 3/3] nvme: enable retries for authentication commands hare
2024-01-29 6:00 ` Christoph Hellwig [this message]
2024-01-29 6:24 ` Hannes Reinecke
2024-01-29 11:12 ` [PATCHv3 0/3] " Chaitanya Kulkarni
-- strict thread matches above, loose matches on Subject: below --
2024-01-29 6:39 [PATCHv4 " hare
2024-01-29 6:39 ` [PATCH 3/3] " hare
2024-01-29 7:10 ` Christoph Hellwig
2024-01-29 20:01 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240129060005.GC19136@lst.de \
--to=hch@lst.de \
--cc=hare@kernel.org \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marting@netapp.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.