From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Ajay Agarwal <ajayagarwal@google.com>
Cc: "Jingoo Han" <jingoohan1@gmail.com>,
"Johan Hovold" <johan+linaro@kernel.org>,
"Jon Hunter" <jonathanh@nvidia.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Manu Gautam" <manugautam@google.com>,
"Doug Zobel" <zobel@google.com>,
"William McVicker" <willmcvicker@google.com>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Robin Murphy" <robin.murphy@arm.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v1 0/2] PCI: dwc: Remove the delay from PCIe probe path
Date: Mon, 29 Jan 2024 11:53:31 +0530 [thread overview]
Message-ID: <20240129062331.GA2971@thinkpad> (raw)
In-Reply-To: <20240124092533.1267836-1-ajayagarwal@google.com>
On Wed, Jan 24, 2024 at 02:55:31PM +0530, Ajay Agarwal wrote:
> dw_pcie_host_init() waits for the link to come up regardless of
> whether there has been an attempt to start the link. The 1 second
> wait time is wasteful. Get rid of it if .start_link() is not
> defined.
>
Where is the changelog? Reviewers will first take a look at the cover letter to
understand the series. And this doesn't convey full information (history).
- Mani
> Ajay Agarwal (2):
> PCI: dwc: Add helper function to print link status
> PCI: dwc: Wait for link up only if link is started
>
> .../pci/controller/dwc/pcie-designware-host.c | 12 +++++++----
> drivers/pci/controller/dwc/pcie-designware.c | 20 ++++++++++++-------
> drivers/pci/controller/dwc/pcie-designware.h | 1 +
> 3 files changed, 22 insertions(+), 11 deletions(-)
>
> --
> 2.43.0.429.g432eaa2c6b-goog
>
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2024-01-29 6:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 9:25 [PATCH v1 0/2] PCI: dwc: Remove the delay from PCIe probe path Ajay Agarwal
2024-01-24 9:25 ` [PATCH v1 1/2] PCI: dwc: Add helper function to print link status Ajay Agarwal
2024-01-24 9:25 ` [PATCH v1 2/2] PCI: dwc: Wait for link up only if link is started Ajay Agarwal
2024-01-29 6:26 ` Manivannan Sadhasivam
2024-01-29 6:23 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240129062331.GA2971@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=ajayagarwal@google.com \
--cc=bhelgaas@google.com \
--cc=fancer.lancer@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=johan+linaro@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manugautam@google.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=willmcvicker@google.com \
--cc=zobel@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.