From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0DDA4EB35 for ; Mon, 29 Jan 2024 06:55:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706511303; cv=none; b=DWeY56ZNaJVFn4dZwiO/708n/CGA2sl10Ljhcv7Q564hn+sUhF9cMUTGCcMWkDUmDGiQjIWabicJrIZlqd3k1umxkwO6gGxUS66W00fLQb1/XO+4EPEzz2lV0fyFmeT2Xt/tbCuSZ28INCzEB8Iwv6EPBUVFsKEhAu+CCPRU4xg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706511303; c=relaxed/simple; bh=2EPa0U+VukGXPRNbsZYJGUNCbNggov8QmdEi5cf3Kko=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qUXn0oomT5oEROwi1XA9h5O/6REez8w0WHEHggQQlcFJUTrU4cyAvaxHpEY3jL+gG2bOxHhs+Dc4F9F7RaweSDpyROGcmZX+61IEVPqnTNOBkvuXBpue01TbxoL/tzZIGaSSNQulk8oOkd9Kzg7SYe5KAum4WtLDKSYVQtMbiG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yXCeIgja; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yXCeIgja" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-42a446cb1baso21383761cf.0 for ; Sun, 28 Jan 2024 22:55:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706511300; x=1707116100; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=s1hxnPoh6daX0WjU31FuHTB7nYnSeoBVwHLBpFGzZZE=; b=yXCeIgja1BeZkXGrCxSjIQFQTKha3rrK7ldC39PtRrQfCWas1NYafGEkgQ6VaLhZrT ncXNQRL/9U4QNTYdBzsbBSyrKH6IkB1/FPn0JUuKNAe4mtHwnj4fgyw8fvD6ICUuVohP JhTvrUoPVXOUCK+GH8GTv1cmA8npbkz6TcRMIeEq+MewxcStyRMHW6AuYBqY3IrM1kBE pGFi8wckNS7jMO4FPFY9jhO3Kj3l2UMVe7FJsg5tjByPIj+AD3eS8altVt3cZHVcQyOF L3/x9/OEHoFskp6aNg7Q5C5wc7DKLrMGlFdYEoVApo4nlMtWYgQuA8e48EywXFyq1cjO 1l9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706511300; x=1707116100; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s1hxnPoh6daX0WjU31FuHTB7nYnSeoBVwHLBpFGzZZE=; b=WzG2NuNI3s4jpG+aH0YM+2znSN76sZxH53tAzVl39kuR8mgk9IJ/4V7NZ7Sqb2A8Zb 13PHy9rTSY3kZCTOcKOooLBOjZPMIAFRk4HKXgwGRkwcPn+FzA9qZMuQSocdkwnUgAtw rD7UlXxLXGYz5wOfW5ge4p18YBzpkQkojo37laTlM07s4mgJUXXpUyYAo7nGfCxUmjkt Fs3DGGvjLPCZyF0qP3B5lappoDRZ+vDKiXQmF2NmTsaouKfPhUcBWT5GDIzo94p8768V wZuwGPv6s9vNsEN0ChKvXK9Kx3UoDHErAvVebJOBIqb/7a8AVCK8UHCUWsWrPCn46Amo 1gcw== X-Gm-Message-State: AOJu0YzltwxQ9u2E58pq25YE2Noc6cLA7sHdCvm9EHbaycG9d1SLlczH ge8bZe0XZucTjIx3rOwS6lQHze6SF++xGgOBhv3fbQwDZllTkeGUNJKAhqGdXQ== X-Google-Smtp-Source: AGHT+IHwfQa7OVYQ7eqwRmxrB+cXFuJ+tQWWagggVHZdoSqnHID39moNiRd92Sd4lXHtYQce6W0czA== X-Received: by 2002:ac8:7f4c:0:b0:42a:9b63:7828 with SMTP id g12-20020ac87f4c000000b0042a9b637828mr2844845qtk.68.1706511299804; Sun, 28 Jan 2024 22:54:59 -0800 (PST) Received: from thinkpad ([117.193.214.109]) by smtp.gmail.com with ESMTPSA id cb27-20020a05622a1f9b00b004283695a39bsm1356146qtb.94.2024.01.28.22.54.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 22:54:59 -0800 (PST) Date: Mon, 29 Jan 2024 12:24:48 +0530 From: Manivannan Sadhasivam To: Shradha Todi Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, jingoohan1@gmail.com, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux@armlinux.org.uk, m.szyprowski@samsung.com, pankaj.dubey@samsung.com Subject: Re: [PATCH v4 1/2] clk: Provide managed helper to get and enable bulk clocks Message-ID: <20240129065448.GC2971@thinkpad> References: <20240124103838.32478-1-shradha.t@samsung.com> <20240124103838.32478-2-shradha.t@samsung.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240124103838.32478-2-shradha.t@samsung.com> On Wed, Jan 24, 2024 at 04:08:37PM +0530, Shradha Todi wrote: > Provide a managed devm_clk_bulk* wrapper to get and enable all > bulk clocks in order to simplify drivers that keeps all clocks > enabled for the time of driver operation. > > Suggested-by: Marek Szyprowski > Signed-off-by: Shradha Todi > --- > drivers/clk/clk-devres.c | 40 ++++++++++++++++++++++++++++++++++++++++ > include/linux/clk.h | 24 ++++++++++++++++++++++++ > 2 files changed, 64 insertions(+) > > diff --git a/drivers/clk/clk-devres.c b/drivers/clk/clk-devres.c > index 4fb4fd4b06bd..cbbd2cc339c3 100644 > --- a/drivers/clk/clk-devres.c > +++ b/drivers/clk/clk-devres.c > @@ -182,6 +182,46 @@ int __must_check devm_clk_bulk_get_all(struct device *dev, > } > EXPORT_SYMBOL_GPL(devm_clk_bulk_get_all); > > +static void devm_clk_bulk_release_all_enable(struct device *dev, void *res) > +{ > + struct clk_bulk_devres *devres = res; > + > + clk_bulk_disable_unprepare(devres->num_clks, devres->clks); > + clk_bulk_put_all(devres->num_clks, devres->clks); > +} > + > +int __must_check devm_clk_bulk_get_all_enable(struct device *dev, > + struct clk_bulk_data **clks) > +{ > + struct clk_bulk_devres *devres; > + int ret; > + > + devres = devres_alloc(devm_clk_bulk_release_all_enable, > + sizeof(*devres), GFP_KERNEL); > + if (!devres) > + return -ENOMEM; > + > + ret = clk_bulk_get_all(dev, &devres->clks); > + if (ret > 0) { > + *clks = devres->clks; > + devres->num_clks = ret; > + } else { > + devres_free(devres); > + return ret; > + } How about: ret = clk_bulk_get_all(dev, &devres->clks); if (ret <= 0) { devres_free(devres); return ret; } *clks = devres->clks; devres->num_clks = ret; Even though this patch follows the pattern used by the rest of the APIs in the driver, IMO above makes it more readable. > + > + ret = clk_bulk_prepare_enable(devres->num_clks, *clks); > + if (!ret) { > + devres_add(dev, devres); > + } else { > + clk_bulk_put_all(devres->num_clks, devres->clks); > + devres_free(devres); > + } > + Same as above: ret = clk_bulk_prepare_enable(devres->num_clks, *clks); if (ret) { clk_bulk_put_all(devres->num_clks, devres->clks); devres_free(devres); return ret; } devres_add(dev, devres); > + return ret; return 0; > +} > +EXPORT_SYMBOL_GPL(devm_clk_bulk_get_all_enable); > + > static int devm_clk_match(struct device *dev, void *res, void *data) > { > struct clk **c = res; > diff --git a/include/linux/clk.h b/include/linux/clk.h > index 1ef013324237..a005e709b7bd 100644 > --- a/include/linux/clk.h > +++ b/include/linux/clk.h > @@ -438,6 +438,23 @@ int __must_check devm_clk_bulk_get_optional(struct device *dev, int num_clks, > int __must_check devm_clk_bulk_get_all(struct device *dev, > struct clk_bulk_data **clks); > > +/** > + * devm_clk_bulk_get_all_enable - managed get multiple clk consumers and > + * enable all clks "Get and enable all clocks of the consumer (managed)" > + * @dev: device for clock "consumer" > + * @clks: pointer to the clk_bulk_data table of consumer > + * > + * Returns success (0) or negative errno. > + * > + * This helper function allows drivers to get several clk "This helper function allows drivers to get all clocks of the consumer and enables them..." - Mani > + * consumers and enable all of them in one operation with management. > + * The clks will automatically be disabled and freed when the device > + * is unbound. > + */ > + > +int __must_check devm_clk_bulk_get_all_enable(struct device *dev, > + struct clk_bulk_data **clks); > + > /** > * devm_clk_get - lookup and obtain a managed reference to a clock producer. > * @dev: device for clock "consumer" > @@ -960,6 +977,13 @@ static inline int __must_check devm_clk_bulk_get_all(struct device *dev, > return 0; > } > > +static inline int __must_check devm_clk_bulk_get_all_enable(struct device *dev, > + struct clk_bulk_data **clks) > +{ > + > + return 0; > +} > + > static inline struct clk *devm_get_clk_from_child(struct device *dev, > struct device_node *np, const char *con_id) > { > -- > 2.17.1 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EE7CC47422 for ; Mon, 29 Jan 2024 06:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=51vCUEeAXoHQjrg5rhwmg6EcdWKiK8ukx8rYxwPRojE=; b=hd7Vh19NC8dVjV RQCdegXVY5NBzztbRgnRTl0BOALIaeejNBYIGqrmiy4iXa6SZ7bx/ToRpBCxj74WQCv/RlpyPppA9 N+NjXy+ZYi7QmWfMRoYrAG3tkt1QSInVCgSKBs+gYnDi4me6uDI1XOUroIOCIp8s0T76tJKjtG6ja vxbZ1I7uLkcDW/akBD7XTtTHOVS2NoSOxwYnggVcd+PF3oviH25xf3tKiAfXz+4gFq45iTE8AUKes hJAPmQeToCcPML9mf/Adql+G9DaWL8FZ5gEwaR2EQp0uTwZeaCXj1YOBMYwURpenR86TrsOBJdhHz 7X2dgyNDXSy4FovWQk1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rULXt-0000000BYf9-337v; Mon, 29 Jan 2024 06:55:05 +0000 Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rULXq-0000000BYe6-1Ua9 for linux-arm-kernel@lists.infradead.org; Mon, 29 Jan 2024 06:55:03 +0000 Received: by mail-qt1-x82d.google.com with SMTP id d75a77b69052e-429dd92b842so30636711cf.3 for ; Sun, 28 Jan 2024 22:55:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706511300; x=1707116100; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=s1hxnPoh6daX0WjU31FuHTB7nYnSeoBVwHLBpFGzZZE=; b=ZdDcdCsSoNxEU08CkrllzzEFVOJr5PQ9ScNHAP4FUkO7vPoAq6ie7BRQTBxJQEABfW yJe46lOsC1oTtuLnDe/xDj1YQNXNpFcReb3Pcj5w2jTvGHSUNEJ069nBZdjYKM94igKg V+cZ3cnYj9dRWqCT7LDivdNp4nw4YRtH56tdj35169Me+v88KbVxDaDF2ldfaSbiy3Ia 1A8jsoTbtxPBEUClNSvBj59/AVu7VyGqvCDvQu6cB/ty7HlpIdljtgcNcjRHWkwZVSYr 7xeB9eqh+OBgbYIWVC8Ha5yrHdvy3iIDTsozZqWW9ZMhRLSTXdhmB3qnB3iAI4WRXTDB NMMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706511300; x=1707116100; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s1hxnPoh6daX0WjU31FuHTB7nYnSeoBVwHLBpFGzZZE=; b=T3oEq8EYcf341n5H4voT24mSVT/NPmSTXPTXe0u/lL4WhpF57YyEZorRR1uddjVfWT opOV1+ZPliBUIoqrcgNCAv4eUJaZwCZbeqrXcL295HdhQ2+VaVj6n2zMuZffzXKrxT21 7CbPwQeO+YNjw+jTKh6EsXqJRokzhMMqweHGlkNWrPwVID4/huq8lkqFzOGzzvacKgSH 5djkhIalZZovhBV9APxWhuu30jayKU/zuz8UUFig9LyPDY8+dVDexR7GHr74BWvjbFw4 g1Geotzkmf0tDWNPuahDaDjGu8AKi21maaYFUxB88oo2uTfsdnaBe/mRVyZUgNPkVa5c /Ndg== X-Gm-Message-State: AOJu0YxQxDXqIhOAWrgZw1HmdaQxK8lF6YyGxp4e7UZfCSFy+wTXKOhv bL3IAPzwNZIIINvz4NaBjy/T2gQogLKHT1jpg4jgpg6vEIH8IHWg87IPsM+JrQ== X-Google-Smtp-Source: AGHT+IHwfQa7OVYQ7eqwRmxrB+cXFuJ+tQWWagggVHZdoSqnHID39moNiRd92Sd4lXHtYQce6W0czA== X-Received: by 2002:ac8:7f4c:0:b0:42a:9b63:7828 with SMTP id g12-20020ac87f4c000000b0042a9b637828mr2844845qtk.68.1706511299804; Sun, 28 Jan 2024 22:54:59 -0800 (PST) Received: from thinkpad ([117.193.214.109]) by smtp.gmail.com with ESMTPSA id cb27-20020a05622a1f9b00b004283695a39bsm1356146qtb.94.2024.01.28.22.54.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 22:54:59 -0800 (PST) Date: Mon, 29 Jan 2024 12:24:48 +0530 From: Manivannan Sadhasivam To: Shradha Todi Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, jingoohan1@gmail.com, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux@armlinux.org.uk, m.szyprowski@samsung.com, pankaj.dubey@samsung.com Subject: Re: [PATCH v4 1/2] clk: Provide managed helper to get and enable bulk clocks Message-ID: <20240129065448.GC2971@thinkpad> References: <20240124103838.32478-1-shradha.t@samsung.com> <20240124103838.32478-2-shradha.t@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240124103838.32478-2-shradha.t@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240128_225502_478270_1EAF21F9 X-CRM114-Status: GOOD ( 24.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKYW4gMjQsIDIwMjQgYXQgMDQ6MDg6MzdQTSArMDUzMCwgU2hyYWRoYSBUb2RpIHdy b3RlOgo+IFByb3ZpZGUgYSBtYW5hZ2VkIGRldm1fY2xrX2J1bGsqIHdyYXBwZXIgdG8gZ2V0IGFu ZCBlbmFibGUgYWxsCj4gYnVsayBjbG9ja3MgaW4gb3JkZXIgdG8gc2ltcGxpZnkgZHJpdmVycyB0 aGF0IGtlZXBzIGFsbCBjbG9ja3MKPiBlbmFibGVkIGZvciB0aGUgdGltZSBvZiBkcml2ZXIgb3Bl cmF0aW9uLgo+IAo+IFN1Z2dlc3RlZC1ieTogTWFyZWsgU3p5cHJvd3NraSA8bS5zenlwcm93c2tp QHNhbXN1bmcuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFNocmFkaGEgVG9kaSA8c2hyYWRoYS50QHNh bXN1bmcuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2Nsay9jbGstZGV2cmVzLmMgfCA0MCArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIGluY2x1ZGUvbGludXgvY2xrLmgg ICAgICB8IDI0ICsrKysrKysrKysrKysrKysrKysrKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDY0 IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9jbGsvY2xrLWRldnJlcy5j IGIvZHJpdmVycy9jbGsvY2xrLWRldnJlcy5jCj4gaW5kZXggNGZiNGZkNGIwNmJkLi5jYmJkMmNj MzM5YzMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9jbGsvY2xrLWRldnJlcy5jCj4gKysrIGIvZHJp dmVycy9jbGsvY2xrLWRldnJlcy5jCj4gQEAgLTE4Miw2ICsxODIsNDYgQEAgaW50IF9fbXVzdF9j aGVjayBkZXZtX2Nsa19idWxrX2dldF9hbGwoc3RydWN0IGRldmljZSAqZGV2LAo+ICB9Cj4gIEVY UE9SVF9TWU1CT0xfR1BMKGRldm1fY2xrX2J1bGtfZ2V0X2FsbCk7Cj4gIAo+ICtzdGF0aWMgdm9p ZCBkZXZtX2Nsa19idWxrX3JlbGVhc2VfYWxsX2VuYWJsZShzdHJ1Y3QgZGV2aWNlICpkZXYsIHZv aWQgKnJlcykKPiArewo+ICsJc3RydWN0IGNsa19idWxrX2RldnJlcyAqZGV2cmVzID0gcmVzOwo+ ICsKPiArCWNsa19idWxrX2Rpc2FibGVfdW5wcmVwYXJlKGRldnJlcy0+bnVtX2Nsa3MsIGRldnJl cy0+Y2xrcyk7Cj4gKwljbGtfYnVsa19wdXRfYWxsKGRldnJlcy0+bnVtX2Nsa3MsIGRldnJlcy0+ Y2xrcyk7Cj4gK30KPiArCj4gK2ludCBfX211c3RfY2hlY2sgZGV2bV9jbGtfYnVsa19nZXRfYWxs X2VuYWJsZShzdHJ1Y3QgZGV2aWNlICpkZXYsCj4gKwkJCQkJICAgICAgc3RydWN0IGNsa19idWxr X2RhdGEgKipjbGtzKQo+ICt7Cj4gKwlzdHJ1Y3QgY2xrX2J1bGtfZGV2cmVzICpkZXZyZXM7Cj4g KwlpbnQgcmV0Owo+ICsKPiArCWRldnJlcyA9IGRldnJlc19hbGxvYyhkZXZtX2Nsa19idWxrX3Jl bGVhc2VfYWxsX2VuYWJsZSwKPiArCQkJICAgICAgc2l6ZW9mKCpkZXZyZXMpLCBHRlBfS0VSTkVM KTsKPiArCWlmICghZGV2cmVzKQo+ICsJCXJldHVybiAtRU5PTUVNOwo+ICsKPiArCXJldCA9IGNs a19idWxrX2dldF9hbGwoZGV2LCAmZGV2cmVzLT5jbGtzKTsKPiArCWlmIChyZXQgPiAwKSB7Cj4g KwkJKmNsa3MgPSBkZXZyZXMtPmNsa3M7Cj4gKwkJZGV2cmVzLT5udW1fY2xrcyA9IHJldDsKPiAr CX0gZWxzZSB7Cj4gKwkJZGV2cmVzX2ZyZWUoZGV2cmVzKTsKPiArCQlyZXR1cm4gcmV0Owo+ICsJ fQoKSG93IGFib3V0OgoKCXJldCA9IGNsa19idWxrX2dldF9hbGwoZGV2LCAmZGV2cmVzLT5jbGtz KTsKCWlmIChyZXQgPD0gMCkgewoJCWRldnJlc19mcmVlKGRldnJlcyk7CgkJcmV0dXJuIHJldDsK CX0KCgkqY2xrcyA9IGRldnJlcy0+Y2xrczsKCWRldnJlcy0+bnVtX2Nsa3MgPSByZXQ7CgpFdmVu IHRob3VnaCB0aGlzIHBhdGNoIGZvbGxvd3MgdGhlIHBhdHRlcm4gdXNlZCBieSB0aGUgcmVzdCBv ZiB0aGUgQVBJcyBpbiB0aGUKZHJpdmVyLCBJTU8gYWJvdmUgbWFrZXMgaXQgbW9yZSByZWFkYWJs ZS4KCj4gKwo+ICsJcmV0ID0gY2xrX2J1bGtfcHJlcGFyZV9lbmFibGUoZGV2cmVzLT5udW1fY2xr cywgKmNsa3MpOwo+ICsJaWYgKCFyZXQpIHsKPiArCQlkZXZyZXNfYWRkKGRldiwgZGV2cmVzKTsK PiArCX0gZWxzZSB7Cj4gKwkJY2xrX2J1bGtfcHV0X2FsbChkZXZyZXMtPm51bV9jbGtzLCBkZXZy ZXMtPmNsa3MpOwo+ICsJCWRldnJlc19mcmVlKGRldnJlcyk7Cj4gKwl9Cj4gKwoKU2FtZSBhcyBh Ym92ZToKCglyZXQgPSBjbGtfYnVsa19wcmVwYXJlX2VuYWJsZShkZXZyZXMtPm51bV9jbGtzLCAq Y2xrcyk7CglpZiAocmV0KSB7CgkJY2xrX2J1bGtfcHV0X2FsbChkZXZyZXMtPm51bV9jbGtzLCBk ZXZyZXMtPmNsa3MpOwoJCWRldnJlc19mcmVlKGRldnJlcyk7CgkJcmV0dXJuIHJldDsKCX0KCglk ZXZyZXNfYWRkKGRldiwgZGV2cmVzKTsKCj4gKwlyZXR1cm4gcmV0OwoKCXJldHVybiAwOwoKPiAr fQo+ICtFWFBPUlRfU1lNQk9MX0dQTChkZXZtX2Nsa19idWxrX2dldF9hbGxfZW5hYmxlKTsKPiAr Cj4gIHN0YXRpYyBpbnQgZGV2bV9jbGtfbWF0Y2goc3RydWN0IGRldmljZSAqZGV2LCB2b2lkICpy ZXMsIHZvaWQgKmRhdGEpCj4gIHsKPiAgCXN0cnVjdCBjbGsgKipjID0gcmVzOwo+IGRpZmYgLS1n aXQgYS9pbmNsdWRlL2xpbnV4L2Nsay5oIGIvaW5jbHVkZS9saW51eC9jbGsuaAo+IGluZGV4IDFl ZjAxMzMyNDIzNy4uYTAwNWU3MDliN2JkIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvbGludXgvY2xr LmgKPiArKysgYi9pbmNsdWRlL2xpbnV4L2Nsay5oCj4gQEAgLTQzOCw2ICs0MzgsMjMgQEAgaW50 IF9fbXVzdF9jaGVjayBkZXZtX2Nsa19idWxrX2dldF9vcHRpb25hbChzdHJ1Y3QgZGV2aWNlICpk ZXYsIGludCBudW1fY2xrcywKPiAgaW50IF9fbXVzdF9jaGVjayBkZXZtX2Nsa19idWxrX2dldF9h bGwoc3RydWN0IGRldmljZSAqZGV2LAo+ICAJCQkJICAgICAgIHN0cnVjdCBjbGtfYnVsa19kYXRh ICoqY2xrcyk7Cj4gIAo+ICsvKioKPiArICogZGV2bV9jbGtfYnVsa19nZXRfYWxsX2VuYWJsZSAt IG1hbmFnZWQgZ2V0IG11bHRpcGxlIGNsayBjb25zdW1lcnMgYW5kCj4gKyAqCQkJCSAgZW5hYmxl IGFsbCBjbGtzCgoiR2V0IGFuZCBlbmFibGUgYWxsIGNsb2NrcyBvZiB0aGUgY29uc3VtZXIgKG1h bmFnZWQpIgoKPiArICogQGRldjogZGV2aWNlIGZvciBjbG9jayAiY29uc3VtZXIiCj4gKyAqIEBj bGtzOiBwb2ludGVyIHRvIHRoZSBjbGtfYnVsa19kYXRhIHRhYmxlIG9mIGNvbnN1bWVyCj4gKyAq Cj4gKyAqIFJldHVybnMgc3VjY2VzcyAoMCkgb3IgbmVnYXRpdmUgZXJybm8uCj4gKyAqCj4gKyAq IFRoaXMgaGVscGVyIGZ1bmN0aW9uIGFsbG93cyBkcml2ZXJzIHRvIGdldCBzZXZlcmFsIGNsawoK IlRoaXMgaGVscGVyIGZ1bmN0aW9uIGFsbG93cyBkcml2ZXJzIHRvIGdldCBhbGwgY2xvY2tzIG9m IHRoZSBjb25zdW1lciBhbmQKZW5hYmxlcyB0aGVtLi4uIgoKLSBNYW5pCgo+ICsgKiBjb25zdW1l cnMgYW5kIGVuYWJsZSBhbGwgb2YgdGhlbSBpbiBvbmUgb3BlcmF0aW9uIHdpdGggbWFuYWdlbWVu dC4KPiArICogVGhlIGNsa3Mgd2lsbCBhdXRvbWF0aWNhbGx5IGJlIGRpc2FibGVkIGFuZCBmcmVl ZCB3aGVuIHRoZSBkZXZpY2UKPiArICogaXMgdW5ib3VuZC4KPiArICovCj4gKwo+ICtpbnQgX19t dXN0X2NoZWNrIGRldm1fY2xrX2J1bGtfZ2V0X2FsbF9lbmFibGUoc3RydWN0IGRldmljZSAqZGV2 LAo+ICsJCQkJCSAgICAgIHN0cnVjdCBjbGtfYnVsa19kYXRhICoqY2xrcyk7Cj4gKwo+ICAvKioK PiAgICogZGV2bV9jbGtfZ2V0IC0gbG9va3VwIGFuZCBvYnRhaW4gYSBtYW5hZ2VkIHJlZmVyZW5j ZSB0byBhIGNsb2NrIHByb2R1Y2VyLgo+ICAgKiBAZGV2OiBkZXZpY2UgZm9yIGNsb2NrICJjb25z dW1lciIKPiBAQCAtOTYwLDYgKzk3NywxMyBAQCBzdGF0aWMgaW5saW5lIGludCBfX211c3RfY2hl Y2sgZGV2bV9jbGtfYnVsa19nZXRfYWxsKHN0cnVjdCBkZXZpY2UgKmRldiwKPiAgCXJldHVybiAw Owo+ICB9Cj4gIAo+ICtzdGF0aWMgaW5saW5lIGludCBfX211c3RfY2hlY2sgZGV2bV9jbGtfYnVs a19nZXRfYWxsX2VuYWJsZShzdHJ1Y3QgZGV2aWNlICpkZXYsCj4gKwkJCQkJCXN0cnVjdCBjbGtf YnVsa19kYXRhICoqY2xrcykKPiArewo+ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICBzdGF0 aWMgaW5saW5lIHN0cnVjdCBjbGsgKmRldm1fZ2V0X2Nsa19mcm9tX2NoaWxkKHN0cnVjdCBkZXZp Y2UgKmRldiwKPiAgCQkJCXN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAsIGNvbnN0IGNoYXIgKmNvbl9p ZCkKPiAgewo+IC0tIAo+IDIuMTcuMQo+IAoKLS0gCuCuruCuo+Cuv+CuteCuo+CvjeCuo+CuqeCv jSDgrprgrqTgrr7grprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK