From: Christoph Hellwig <hch@lst.de>
To: "Petr Tesařík" <petr@tesarici.cz>
Cc: Christoph Hellwig <hch@lst.de>, Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org, kernel-team@android.com,
iommu@lists.linux.dev,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Petr Tesarik <petr.tesarik1@huawei-partners.com>,
Dexuan Cui <decui@microsoft.com>
Subject: Re: [PATCH 2/2] swiotlb: Enforce page alignment in swiotlb_alloc()
Date: Mon, 29 Jan 2024 08:50:43 +0100 [thread overview]
Message-ID: <20240129075043.GA22019@lst.de> (raw)
In-Reply-To: <20240129084326.4667af6a@meshulam.tesarici.cz>
On Mon, Jan 29, 2024 at 08:43:26AM +0100, Petr Tesařík wrote:
> > So PFN_DOWN aligns the address and thus per se converting the unaligned
> > address isn't a problem. That being said swiotlb obviously should never
> > allocate unaligned addresses, but the placement of this check feels
> > odd to me. Also because it only catches swiotlb_alloc and not the
> > map side.
>
> We may have to rethink how alignment constraints are interpreted. See
> also my reply to PATCH 1/2.
>
> > Maybe just throw a WARN_ON_ONCE into slot_addr() ?
>
> Yes.
>
> Or, what if I write a KUnit test suite for swiotlb to combat this
> constant stream of various regressions?
Both sounds good to me.
next prev parent reply other threads:[~2024-01-29 7:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 15:19 [PATCH 0/2] Fix double allocation in swiotlb_alloc() Will Deacon
2024-01-26 15:19 ` [PATCH 1/2] swiotlb: Fix allocation alignment requirement when searching slots Will Deacon
2024-01-26 17:01 ` Petr Tesařík
2024-01-29 19:32 ` Will Deacon
2024-01-29 20:40 ` Petr Tesařík
2024-01-29 22:05 ` Will Deacon
2024-01-26 15:19 ` [PATCH 2/2] swiotlb: Enforce page alignment in swiotlb_alloc() Will Deacon
2024-01-26 16:23 ` Petr Tesařík
2024-01-29 19:35 ` Will Deacon
2024-01-29 6:08 ` Christoph Hellwig
2024-01-29 7:43 ` Petr Tesařík
2024-01-29 7:50 ` Christoph Hellwig [this message]
2024-01-29 19:49 ` Will Deacon
2024-01-30 14:34 ` Christoph Hellwig
2024-01-26 16:20 ` [PATCH 0/2] Fix double allocation " Petr Tesařík
2024-01-29 18:42 ` Will Deacon
2024-01-29 19:26 ` Petr Tesařík
2024-01-29 19:33 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240129075043.GA22019@lst.de \
--to=hch@lst.de \
--cc=decui@microsoft.com \
--cc=iommu@lists.linux.dev \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=petr.tesarik1@huawei-partners.com \
--cc=petr@tesarici.cz \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.