All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [frederic-dynticks:timers/hotplug 14/15] kernel/time/tick-sched.c:1575:6: error: redefinition of 'tick_sched_timer_dying'
Date: Mon, 29 Jan 2024 16:09:00 +0800	[thread overview]
Message-ID: <202401291549.QU9vTGce-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git timers/hotplug
head:   378e195ce2fd96d90ed7c1cde9033cb7079a7274
commit: 9cd2efa0d41453db9d7e6bc813bde58daa3f0449 [14/15] tick: Shut down low-res tick from dying CPU
config: arm-randconfig-r052-20240128 (https://download.01.org/0day-ci/archive/20240129/202401291549.QU9vTGce-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240129/202401291549.QU9vTGce-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401291549.QU9vTGce-lkp@intel.com/

All errors (new ones prefixed by >>):

>> kernel/time/tick-sched.c:1575:6: error: redefinition of 'tick_sched_timer_dying'
    1575 | void tick_sched_timer_dying(int cpu)
         |      ^~~~~~~~~~~~~~~~~~~~~~
   In file included from kernel/time/tick-internal.h:9,
                    from kernel/time/tick-sched.c:32:
   kernel/time/tick-sched.h:111:20: note: previous definition of 'tick_sched_timer_dying' with type 'void(int)'
     111 | static inline void tick_sched_timer_dying(int cpu) { }
         |                    ^~~~~~~~~~~~~~~~~~~~~~


vim +/tick_sched_timer_dying +1575 kernel/time/tick-sched.c

  1570	
  1571	/*
  1572	 * Shut down the tick and make sure the CPU won't try to retake the timekeeping
  1573	 * duty before disabling IRQs in idle for the last time.
  1574	 */
> 1575	void tick_sched_timer_dying(int cpu)
  1576	{
  1577		struct tick_device *td = &per_cpu(tick_cpu_device, cpu);
  1578		struct tick_sched *ts = &per_cpu(tick_cpu_sched, cpu);
  1579		struct clock_event_device *dev = td->evtdev;
  1580		ktime_t idle_sleeptime, iowait_sleeptime;
  1581	
  1582		/* This must happen before hrtimers are migrated! */
  1583		tick_sched_timer_cancel(ts);
  1584	
  1585		/*
  1586		 * If the clockevents doesn't support CLOCK_EVT_STATE_ONESHOT_STOPPED,
  1587		 * make sure not to call low-res tick handler.
  1588		 */
  1589		if (tick_sched_flag_test(ts, TS_FLAG_NOHZ))
  1590			dev->event_handler = clockevents_handle_noop;
  1591	
  1592		idle_sleeptime = ts->idle_sleeptime;
  1593		iowait_sleeptime = ts->iowait_sleeptime;
  1594		memset(ts, 0, sizeof(*ts));
  1595		ts->idle_sleeptime = idle_sleeptime;
  1596		ts->iowait_sleeptime = iowait_sleeptime;
  1597	}
  1598	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-01-29  8:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202401291549.QU9vTGce-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=frederic@kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.