From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F23F1586C5; Mon, 29 Jan 2024 17:12:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706548372; cv=none; b=adFxYp1DwMuH/QR/ksiSwEy2Qq2Kx4IQhCqXsghkbDjda5ko5NtMeRP07HoCEih4NGS58SfiAnhGF8VZR2wGC3v/NanfY9JDKN7NmD3Ud5G3MYWCBoWZkx6/lVDKZBzmh/2uMmvwh6DmOwy4umE3XNOuE9f/fuSdq//rXjhVics= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706548372; c=relaxed/simple; bh=QxD2dubYuhKOayhcLO9bhuJASSEwi02nQ9ZMg5fFrnU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JlmZiCzIrRJVqMXvwG3eJ5dsuc5+sg62zIvTKTHLMeOTSSg0mZEgyWWaatlZdo/Rexl3SZhSDNzd9bX3oXeQfUqxtloHNVsIx3W6gtibh7DDzqNSL+ZQttU2IAf3jSkjN74sszG8kHAGJotfMsN5WgXG8BQRRPnSAI2DtMuGUkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XA++uq/A; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XA++uq/A" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37D11C43390; Mon, 29 Jan 2024 17:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706548372; bh=QxD2dubYuhKOayhcLO9bhuJASSEwi02nQ9ZMg5fFrnU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XA++uq/ArcQ8pmy0FOQWxr9KruVzo3cXDUqZAjNayrN0B9xUcY/3KOATZdohL7Rs5 va1PEMa4g6h2EfXwN0JGUI1z1BT/eaHUsUdwlv8uviQ8bmAmCj1uzL6LYgc1BQCHrl 9UDNnzJ4hOiBVFvne/4eq15ZF0g54oAzerVMzQdM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shenwei Wang , Paolo Abeni , Sasha Levin Subject: [PATCH 6.1 113/185] net: fec: fix the unhandled context fault from smmu Date: Mon, 29 Jan 2024 09:05:13 -0800 Message-ID: <20240129170002.221730368@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240129165958.589924174@linuxfoundation.org> References: <20240129165958.589924174@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shenwei Wang [ Upstream commit 5e344807735023cd3a67c37a1852b849caa42620 ] When repeatedly changing the interface link speed using the command below: ethtool -s eth0 speed 100 duplex full ethtool -s eth0 speed 1000 duplex full The following errors may sometimes be reported by the ARM SMMU driver: [ 5395.035364] fec 5b040000.ethernet eth0: Link is Down [ 5395.039255] arm-smmu 51400000.iommu: Unhandled context fault: fsr=0x402, iova=0x00000000, fsynr=0x100001, cbfrsynra=0x852, cb=2 [ 5398.108460] fec 5b040000.ethernet eth0: Link is Up - 100Mbps/Full - flow control off It is identified that the FEC driver does not properly stop the TX queue during the link speed transitions, and this results in the invalid virtual I/O address translations from the SMMU and causes the context faults. Fixes: dbc64a8ea231 ("net: fec: move calls to quiesce/resume packet processing out of fec_restart()") Signed-off-by: Shenwei Wang Link: https://lore.kernel.org/r/20240123165141.2008104-1-shenwei.wang@nxp.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/fec_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 6d1b76002282..97d12c7eea77 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1917,6 +1917,7 @@ static void fec_enet_adjust_link(struct net_device *ndev) /* if any of the above changed restart the FEC */ if (status_change) { + netif_stop_queue(ndev); napi_disable(&fep->napi); netif_tx_lock_bh(ndev); fec_restart(ndev); @@ -1926,6 +1927,7 @@ static void fec_enet_adjust_link(struct net_device *ndev) } } else { if (fep->link) { + netif_stop_queue(ndev); napi_disable(&fep->napi); netif_tx_lock_bh(ndev); fec_stop(ndev); -- 2.43.0