From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC28F158D7F; Mon, 29 Jan 2024 17:07:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706548066; cv=none; b=VOpuQzmLPFJxxhn6cUiftv4izW4R/xWbqIE1hOFbbhsYSPlHpBY8DHDbJ092IGbpu5F/X6psqqzG/dPJ70wH0n4oby3oY45Z2LwIzzthMzAelb5HVMmgOWd61k5jqsV0BxAZE7UzUmBWxwgSy+jZM+OtEL4xhMF1QnVO6AYLPGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706548066; c=relaxed/simple; bh=r/TCOozsLdyYyLKp0KjDDtweDB8vje0UqZja1xk04Ys=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a5U+OabTslTPp5UP1CQcQf4VEK7l04I+21xBLjXz9IoIytvPwcCmW6XsATqYwq8Std85CGoVGgmCH/J8vENqlF9qtBq/mCYcTsBEB3K/NVyMUblyFaXtnweUUbARw4BBL32PwQS3DFozb+aKzCSwDXExJSxlHuTltwNG1J3kqug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=vKh6jgA6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="vKh6jgA6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80F78C433C7; Mon, 29 Jan 2024 17:07:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706548066; bh=r/TCOozsLdyYyLKp0KjDDtweDB8vje0UqZja1xk04Ys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vKh6jgA63KJS4w1/jD8cEI13OdeMlLWUoHBCnJWgGX3mWnZ5k+b3hhc6lo1cHeej/ uXLMGVCQvAQyt7HpnOdQQ7HNUDs0gmd8xzkuT2zaOHQyB/U8I0dBcDfSywuC12RT2/ TU/pct+H2L2VDYKBE3XXYcIYLhFcaLHsQmLKlCik= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Stephan Gerhold , Bryan ODonoghue , Bjorn Andersson Subject: [PATCH 6.7 074/346] arm64: dts: qcom: msm8939: Make blsp_dma controlled-remotely Date: Mon, 29 Jan 2024 09:01:45 -0800 Message-ID: <20240129170018.565867626@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240129170016.356158639@linuxfoundation.org> References: <20240129170016.356158639@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.7-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stephan Gerhold commit 4bbda9421f316efdaef5dbf642e24925ef7de130 upstream. The blsp_dma controller is shared between the different subsystems, which is why it is already initialized by the firmware. We should not reinitialize it from Linux to avoid potential other users of the DMA engine to misbehave. In mainline this can be described using the "qcom,controlled-remotely" property. In the downstream/vendor kernel from Qualcomm there is an opposite "qcom,managed-locally" property. This property is *not* set for the qcom,sps-dma@7884000 [1] so adding "qcom,controlled-remotely" upstream matches the behavior of the downstream/vendor kernel. Adding this seems to fix some weird issues with UART where both input/output becomes garbled with certain obscure firmware versions on some devices. [1]: https://git.codelinaro.org/clo/la/kernel/msm-3.10/-/blob/LA.BR.1.2.9.1-02310-8x16.0/arch/arm/boot/dts/qcom/msm8939-common.dtsi#L866-872 Cc: stable@vger.kernel.org # 6.5 Fixes: 61550c6c156c ("arm64: dts: qcom: Add msm8939 SoC") Signed-off-by: Stephan Gerhold Reviewed-by: Bryan O'Donoghue Link: https://lore.kernel.org/r/20231204-msm8916-blsp-dma-remote-v1-2-3e49c8838c8d@gerhold.net Signed-off-by: Bjorn Andersson Signed-off-by: Greg Kroah-Hartman --- arch/arm64/boot/dts/qcom/msm8939.dtsi | 1 + 1 file changed, 1 insertion(+) --- a/arch/arm64/boot/dts/qcom/msm8939.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi @@ -1682,6 +1682,7 @@ clock-names = "bam_clk"; #dma-cells = <1>; qcom,ee = <0>; + qcom,controlled-remotely; }; blsp_uart1: serial@78af000 {