From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 256C315AABD; Mon, 29 Jan 2024 17:09:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706548173; cv=none; b=bwNlDgEAojaorv0PK48keMpCmqHojuCYl53X8sch7XmBHVJ9+gfqQw0onNmUFOACM8bpG0h+gtEvpxnF9Kce+75ap5iFmj/SdzSy9g4nIKnyq/400rwF2RTd+79aGl/kjrnj3FRI/nfybC7/tf3cKP26IEILAxaLbdnnGpH5fws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706548173; c=relaxed/simple; bh=R0bfVzJ9DDHV+x0EtenezfwUfh9Hbsbv/dQxVQ48bOY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B0UaGgfMGhvIXY1qOQyiqVU+UgdhWc7Z4ZbhCtamBnsRV7o9cpnbdkqo4w/zJsI96e2dFqgi+GNHW4+HP7AUKmBXM4At4ajD/g8b3qWIsDJaAhC3IDIBFVpYu6dNyNvw9yRe4XjW3KR9oVjISaqcd36F7TKqTM9jGR6ftuSGExs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SfrjRrNG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SfrjRrNG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3DA1C433F1; Mon, 29 Jan 2024 17:09:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706548173; bh=R0bfVzJ9DDHV+x0EtenezfwUfh9Hbsbv/dQxVQ48bOY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SfrjRrNGGXjufF9QuHJ2KhQUiRA9ZhGwvH+RqiQVi0iX5BOZ4P2Cte7tVR0ESyHa5 CdWFdkLBBswd7QfqTI4P+8bQK9mjChd1YSD9Tsb74SIZX6jC4zIbgwPGtgGH9LS1vL FnOpgy1dBDMtzT4xUhGp57bqpc+VN2JMagrn9QDw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jay Vosburgh , Hangbin Liu , Paolo Abeni , Sasha Levin Subject: [PATCH 6.7 218/346] selftests: bonding: do not test arp/ns target with mode balance-alb/tlb Date: Mon, 29 Jan 2024 09:04:09 -0800 Message-ID: <20240129170022.805094413@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240129170016.356158639@linuxfoundation.org> References: <20240129170016.356158639@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.7-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hangbin Liu [ Upstream commit a2933a8759a62269754e54733d993b19de870e84 ] The prio_arp/ns tests hard code the mode to active-backup. At the same time, The balance-alb/tlb modes do not support arp/ns target. So remove the prio_arp/ns tests from the loop and only test active-backup mode. Fixes: 481b56e0391e ("selftests: bonding: re-format bond option tests") Reported-by: Jay Vosburgh Closes: https://lore.kernel.org/netdev/17415.1705965957@famine/ Signed-off-by: Hangbin Liu Acked-by: Jay Vosburgh Link: https://lore.kernel.org/r/20240123075917.1576360-1-liuhangbin@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- .../testing/selftests/drivers/net/bonding/bond_options.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/drivers/net/bonding/bond_options.sh b/tools/testing/selftests/drivers/net/bonding/bond_options.sh index c54d1697f439..d508486cc0bd 100755 --- a/tools/testing/selftests/drivers/net/bonding/bond_options.sh +++ b/tools/testing/selftests/drivers/net/bonding/bond_options.sh @@ -162,7 +162,7 @@ prio_arp() local mode=$1 for primary_reselect in 0 1 2; do - prio_test "mode active-backup arp_interval 100 arp_ip_target ${g_ip4} primary eth1 primary_reselect $primary_reselect" + prio_test "mode $mode arp_interval 100 arp_ip_target ${g_ip4} primary eth1 primary_reselect $primary_reselect" log_test "prio" "$mode arp_ip_target primary_reselect $primary_reselect" done } @@ -178,7 +178,7 @@ prio_ns() fi for primary_reselect in 0 1 2; do - prio_test "mode active-backup arp_interval 100 ns_ip6_target ${g_ip6} primary eth1 primary_reselect $primary_reselect" + prio_test "mode $mode arp_interval 100 ns_ip6_target ${g_ip6} primary eth1 primary_reselect $primary_reselect" log_test "prio" "$mode ns_ip6_target primary_reselect $primary_reselect" done } @@ -194,9 +194,9 @@ prio() for mode in $modes; do prio_miimon $mode - prio_arp $mode - prio_ns $mode done + prio_arp "active-backup" + prio_ns "active-backup" } arp_validate_test() -- 2.43.0