From: Simon Horman <horms@kernel.org>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Ido Schimmel <idosch@nvidia.com>,
Amit Cohen <amcohen@nvidia.com>,
mlxsw@nvidia.com
Subject: Re: [PATCH net-next 4/6] mlxsw: spectrum: Search for free LAD ID once
Date: Mon, 29 Jan 2024 19:53:33 +0000 [thread overview]
Message-ID: <20240129195333.GO401354@kernel.org> (raw)
In-Reply-To: <903f25dbfc84fe1f384d92ea7f8902a2051bb7bc.1706293430.git.petrm@nvidia.com>
On Fri, Jan 26, 2024 at 07:58:29PM +0100, Petr Machata wrote:
> From: Amit Cohen <amcohen@nvidia.com>
>
> Currently, the function mlxsw_sp_lag_index_get() is called twice - first
> as part of NETDEV_PRECHANGEUPPER event and later as part of
> NETDEV_CHANGEUPPER. This function will be changed in the next patch. To
> simplify the code, call it only once as part of NETDEV_CHANGEUPPER
> event and set an error message using 'extack' in case of failure.
>
> Signed-off-by: Amit Cohen <amcohen@nvidia.com>
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-01-29 19:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 18:58 [PATCH net-next 0/6] mlxsw: Refactor reference counting code Petr Machata
2024-01-26 18:58 ` [PATCH net-next 1/6] mlxsw: spectrum: Change mlxsw_sp_upper to LAG structure Petr Machata
2024-01-29 19:52 ` Simon Horman
2024-01-26 18:58 ` [PATCH net-next 2/6] mlxsw: spectrum: Remove mlxsw_sp_lag_get() Petr Machata
2024-01-29 19:52 ` Simon Horman
2024-01-26 18:58 ` [PATCH net-next 3/6] mlxsw: spectrum: Query max_lag once Petr Machata
2024-01-29 19:53 ` Simon Horman
2024-01-26 18:58 ` [PATCH net-next 4/6] mlxsw: spectrum: Search for free LAD ID once Petr Machata
2024-01-29 19:53 ` Simon Horman [this message]
2024-01-26 18:58 ` [PATCH net-next 5/6] mlxsw: spectrum: Refactor LAG create and destroy code Petr Machata
2024-01-29 19:53 ` Simon Horman
2024-01-26 18:58 ` [PATCH net-next 6/6] mlxsw: Use refcount_t for reference counting Petr Machata
2024-01-29 19:54 ` Simon Horman
2024-01-30 14:50 ` [PATCH net-next 0/6] mlxsw: Refactor reference counting code patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240129195333.GO401354@kernel.org \
--to=horms@kernel.org \
--cc=amcohen@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.