From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6547DC47DDF for ; Tue, 30 Jan 2024 13:13:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 180CE81948; Tue, 30 Jan 2024 13:13:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 180CE81948 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1706620428; bh=bzxo/lDZ3dkRGuml3CrorRLN1KbJUvXLlh0xbZvfwvI=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=p49Esjro6ZT1X+WcoFe1p43DB1a3p6Nh3bAad6Zx+4fkpvKEwZTDKGFFPwqNBQExs oK6WKDfnQRnGN+0y75lnexPE76rCPMYOghsQXbkFp+WiXCWvowRllCUR1xMoEpi+++ 1vlOKgXVWdakMIHcopjLg94OsK9PocOXmEBS930xbDD/oi6+Z3suiBfrDuyMDmd8A8 AjwyF1OtkKNTbkcGGjd+Z3we1oYUDiwk6P2SDGwHw/c7KNzY1XQeyEgI1qKs9ucDXt JEBuWWAq7StIxN5qU3W8NDOugF/2/DVoPa1pBmbd9wdrW5WnbZAPB2aT4oeB8Adcx2 TJkkJSXv9xsyQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T6k94VK0JesJ; Tue, 30 Jan 2024 13:13:47 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 4EF9C8194A; Tue, 30 Jan 2024 13:13:47 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4EF9C8194A Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 61EC71BF2A5 for ; Tue, 30 Jan 2024 13:13:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 47C3A60BCC for ; Tue, 30 Jan 2024 13:13:46 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 47C3A60BCC X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PaMaGCDwl7WM for ; Tue, 30 Jan 2024 13:13:45 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by smtp3.osuosl.org (Postfix) with ESMTPS id 9A09F60586 for ; Tue, 30 Jan 2024 13:13:45 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9A09F60586 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6DC93CE182E; Tue, 30 Jan 2024 13:13:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94848C433C7; Tue, 30 Jan 2024 13:13:40 +0000 (UTC) Date: Tue, 30 Jan 2024 13:13:34 +0000 From: Simon Horman To: Jedrzej Jagielski Message-ID: <20240130131334.GJ351311@kernel.org> References: <20240126130503.14197-1-jedrzej.jagielski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240126130503.14197-1-jedrzej.jagielski@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706620422; bh=t1VWMZfJ75RGQ7+F+W1zBcnuaV/kXgLyDNxdFeyW1cs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eIoZ9wM3Ddnh/7gh2UHyCgNu09jL9SkYngIvWVs9wXWTwRoXn6rfRG4aaoy8viXdt ZQlgsiQ0Iy1x9dsN5WWUIbQVNCfM5LR3IRyb2MRxEeE3HXdvp/cevBJkaGr1yVv6id NRlF71KGCx6PyZ+R7tU2GoNumrDt4e0NlHy4FKnd13vy+tWOySi+Wb05k/4BOgVO4h dgIJmX+rHkLEIRGKQdud9EU/5bChMLflxeswrDxFFYK4ilZWZYl6i+aGlwQPBKX5lr Gg57+WUjwvLj7pnIuCc2Xesx2rEAvQziJ5NjIKVFVSXLBE5owmMTs2rwF64mWcJzZ5 XrwAmtnj0Zxjw== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=eIoZ9wM3 Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 1/3] ixgbe: Convert ret val type from s32 to int X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jacob Keller , anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Jan 26, 2024 at 02:05:01PM +0100, Jedrzej Jagielski wrote: > Currently big amount of the functions returning standard error codes > are of type s32. Convert them to regular ints as typdefs here are not > necessary to return standard error codes. > > Fix incorrect args alignment in touched functions. > > Suggested-by: Jacob Keller > Reviewed-by: Jacob Keller > Signed-off-by: Jedrzej Jagielski Thanks Jedrzej, this looks good to me. With the nit below resolved, please feel free to add: Reviewed-by: Simon Horman ... > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82598.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82598.c ... > @@ -115,7 +110,7 @@ s32 ixgbe_dcb_config_tx_desc_arbiter_82598(struct ixgbe_hw *hw, > } > > /** > - * ixgbe_dcb_config_tx_data_arbiter_82598 - Config Tx data arbiter > + * xgbe_dcb_config_tx_data_arbiter_82598 - Config Tx data arbiter nit: ixgbe_dcb_config_tx_data_arbiter_82598 > * @hw: pointer to hardware structure > * @refill: refill credits index by traffic class > * @max: max credits index by traffic class > @@ -124,11 +119,8 @@ s32 ixgbe_dcb_config_tx_desc_arbiter_82598(struct ixgbe_hw *hw, > * > * Configure Tx Data Arbiter and credits for each traffic class. > */ > -s32 ixgbe_dcb_config_tx_data_arbiter_82598(struct ixgbe_hw *hw, > - u16 *refill, > - u16 *max, > - u8 *bwg_id, > - u8 *prio_type) > +int ixgbe_dcb_config_tx_data_arbiter_82598(struct ixgbe_hw *hw, u16 *refill, > + u16 *max, u8 *bwg_id, u8 *prio_type) > { > u32 reg; > u8 i; ... From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39DBB6A348 for ; Tue, 30 Jan 2024 13:13:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706620423; cv=none; b=umen5TofU7LJg74hUYar1BT7A389s0NVNtSOfsGqG8mm5XTSe8C0G4NLuf4p6O/QcZD12wt3Y8UBBLyBpkGGiX4VS0jmRIAUTsOi/ZtIin6PcNXpl4/OaLOHyW/VbXyFFE6zQgzsKXF9fNIGA6lBTKgTX/Q8KnpdXbM+jLQG1hE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706620423; c=relaxed/simple; bh=t1VWMZfJ75RGQ7+F+W1zBcnuaV/kXgLyDNxdFeyW1cs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PYSv534XPe0PK97ghcj4VB4aSOKquTRKiVTeB4uTdC6JAJIatW+3Z7ZlfdxXLA0c53+vxiElTyPmZ1i5K8bqwaxbUE/blAXMNa4NbM9S77o+aL1Ta2kp139LEyyjHw9M/9moDfDDJVNpA0mK/WCLsIZGC2gsVNZLsEvdJ0ETBqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eIoZ9wM3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eIoZ9wM3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94848C433C7; Tue, 30 Jan 2024 13:13:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706620422; bh=t1VWMZfJ75RGQ7+F+W1zBcnuaV/kXgLyDNxdFeyW1cs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eIoZ9wM3Ddnh/7gh2UHyCgNu09jL9SkYngIvWVs9wXWTwRoXn6rfRG4aaoy8viXdt ZQlgsiQ0Iy1x9dsN5WWUIbQVNCfM5LR3IRyb2MRxEeE3HXdvp/cevBJkaGr1yVv6id NRlF71KGCx6PyZ+R7tU2GoNumrDt4e0NlHy4FKnd13vy+tWOySi+Wb05k/4BOgVO4h dgIJmX+rHkLEIRGKQdud9EU/5bChMLflxeswrDxFFYK4ilZWZYl6i+aGlwQPBKX5lr Gg57+WUjwvLj7pnIuCc2Xesx2rEAvQziJ5NjIKVFVSXLBE5owmMTs2rwF64mWcJzZ5 XrwAmtnj0Zxjw== Date: Tue, 30 Jan 2024 13:13:34 +0000 From: Simon Horman To: Jedrzej Jagielski Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, Jacob Keller Subject: Re: [PATCH iwl-next v4 1/3] ixgbe: Convert ret val type from s32 to int Message-ID: <20240130131334.GJ351311@kernel.org> References: <20240126130503.14197-1-jedrzej.jagielski@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240126130503.14197-1-jedrzej.jagielski@intel.com> On Fri, Jan 26, 2024 at 02:05:01PM +0100, Jedrzej Jagielski wrote: > Currently big amount of the functions returning standard error codes > are of type s32. Convert them to regular ints as typdefs here are not > necessary to return standard error codes. > > Fix incorrect args alignment in touched functions. > > Suggested-by: Jacob Keller > Reviewed-by: Jacob Keller > Signed-off-by: Jedrzej Jagielski Thanks Jedrzej, this looks good to me. With the nit below resolved, please feel free to add: Reviewed-by: Simon Horman ... > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82598.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82598.c ... > @@ -115,7 +110,7 @@ s32 ixgbe_dcb_config_tx_desc_arbiter_82598(struct ixgbe_hw *hw, > } > > /** > - * ixgbe_dcb_config_tx_data_arbiter_82598 - Config Tx data arbiter > + * xgbe_dcb_config_tx_data_arbiter_82598 - Config Tx data arbiter nit: ixgbe_dcb_config_tx_data_arbiter_82598 > * @hw: pointer to hardware structure > * @refill: refill credits index by traffic class > * @max: max credits index by traffic class > @@ -124,11 +119,8 @@ s32 ixgbe_dcb_config_tx_desc_arbiter_82598(struct ixgbe_hw *hw, > * > * Configure Tx Data Arbiter and credits for each traffic class. > */ > -s32 ixgbe_dcb_config_tx_data_arbiter_82598(struct ixgbe_hw *hw, > - u16 *refill, > - u16 *max, > - u8 *bwg_id, > - u8 *prio_type) > +int ixgbe_dcb_config_tx_data_arbiter_82598(struct ixgbe_hw *hw, u16 *refill, > + u16 *max, u8 *bwg_id, u8 *prio_type) > { > u32 reg; > u8 i; ...