From: Christoph Hellwig <hch@lst.de>
To: Jeremy Allison <jra@samba.org>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Jeremy Allison <jallison@ciq.com>,
tansuresh@google.com, hch@lst.de, gregkh@linuxfoundation.org,
rafael@kernel.org, bhelgaas@google.com,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 4/5] nvme: Add a new exported function nvme_request_shutdown().
Date: Wed, 31 Jan 2024 07:20:17 +0100 [thread overview]
Message-ID: <20240131062017.GB16030@lst.de> (raw)
In-Reply-To: <ZbkyfB03maJLX4aD@jeremy-HP-Z840-Workstation>
On Tue, Jan 30, 2024 at 09:31:40AM -0800, Jeremy Allison wrote:
> I think the idea of adding _ctrl_ in the name is a good
> one as it makes explicit the level it's operating on.
>
> I think nvme_ctrl_shutdown_start() is the better name,
> so I'll use that for the next version.
Sounds good to me.
next prev parent reply other threads:[~2024-01-31 6:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 18:19 Make NVME shutdown two-pass - Version 5 Jeremy Allison
2024-01-29 18:19 ` [PATCH 1/5] driver core: Support two-pass driver shutdown Jeremy Allison
2024-01-30 10:00 ` Sagi Grimberg
2024-02-14 3:36 ` Saravana Kannan
2024-02-14 8:10 ` Christoph Hellwig
2024-02-14 21:36 ` Saravana Kannan
2024-02-14 22:10 ` Bjorn Helgaas
2024-01-29 18:19 ` [PATCH 2/5] PCI: Support two-pass shutdown Jeremy Allison
2024-01-30 10:00 ` Sagi Grimberg
2024-01-30 17:54 ` Bjorn Helgaas
2024-01-29 18:19 ` [PATCH 3/5] nvme: Change 'bool shutdown' into an enum shutdown_type for nvme_dev_disable() Jeremy Allison
2024-01-30 11:00 ` Sagi Grimberg
2024-01-31 6:19 ` Christoph Hellwig
2024-01-29 18:19 ` [PATCH 4/5] nvme: Add a new exported function nvme_request_shutdown() Jeremy Allison
2024-01-30 10:58 ` Sagi Grimberg
2024-01-30 17:31 ` Jeremy Allison
2024-01-31 6:20 ` Christoph Hellwig [this message]
2024-01-29 18:19 ` [PATCH 5/5] nvme: Add two-pass shutdown support Jeremy Allison
2024-01-30 11:15 ` Sagi Grimberg
2024-01-30 18:54 ` Jeremy Allison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131062017.GB16030@lst.de \
--to=hch@lst.de \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jallison@ciq.com \
--cc=jra@samba.org \
--cc=linux-nvme@lists.infradead.org \
--cc=rafael@kernel.org \
--cc=sagi@grimberg.me \
--cc=tansuresh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.