From: thinker.li@gmail.com
To: netdev@vger.kernel.org, ast@kernel.org, martin.lau@linux.dev,
kernel-team@meta.com, davem@davemloft.net, dsahern@kernel.org,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
liuhangbin@gmail.com
Cc: sinquersw@gmail.com, kuifeng@meta.com,
Kui-Feng Lee <thinker.li@gmail.com>
Subject: [PATCH net-next 2/5] net/ipv6: Remove unnecessary clean.
Date: Tue, 30 Jan 2024 22:40:38 -0800 [thread overview]
Message-ID: <20240131064041.3445212-3-thinker.li@gmail.com> (raw)
In-Reply-To: <20240131064041.3445212-1-thinker.li@gmail.com>
From: Kui-Feng Lee <thinker.li@gmail.com>
The route here is newly created. It is unnecessary to call
fib6_clean_expires() on it.
Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
---
net/ipv6/route.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 98abba8f15cd..dd6ff5b20918 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -3765,8 +3765,6 @@ static struct fib6_info *ip6_route_info_create(struct fib6_config *cfg,
if (cfg->fc_flags & RTF_EXPIRES)
fib6_set_expires(rt, jiffies +
clock_t_to_jiffies(cfg->fc_expires));
- else
- fib6_clean_expires(rt);
if (cfg->fc_protocol == RTPROT_UNSPEC)
cfg->fc_protocol = RTPROT_BOOT;
--
2.34.1
next prev parent reply other threads:[~2024-01-31 6:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 6:40 [PATCH net-next 0/5] Remove expired routes with a separated list of routes thinker.li
2024-01-31 6:40 ` [PATCH net-next 1/5] net/ipv6: set expires in rt6_add_dflt_router() thinker.li
2024-01-31 6:40 ` thinker.li [this message]
2024-01-31 8:29 ` [PATCH net-next 2/5] net/ipv6: Remove unnecessary clean Hangbin Liu
2024-01-31 6:40 ` [PATCH net-next 3/5] net/ipv6: Remove expired routes with a separated list of routes thinker.li
2024-01-31 6:40 ` [PATCH net-next 4/5] net/ipv6: set expires in modify_prefix_route() if RTF_EXPIRES is set thinker.li
2024-01-31 6:40 ` [PATCH net-next 5/5] selftests/net: Adding test cases of replacing routes and route advertisements thinker.li
2024-01-31 19:20 ` Jakub Kicinski
2024-01-31 21:14 ` Kui-Feng Lee
2024-02-01 8:46 ` Hangbin Liu
2024-02-01 17:14 ` Kui-Feng Lee
2024-02-02 2:25 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131064041.3445212-3-thinker.li@gmail.com \
--to=thinker.li@gmail.com \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=kuifeng@meta.com \
--cc=liuhangbin@gmail.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sinquersw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.