Re: [PATCH 1/3] riscv: optimized memcpy

[kernel test robot <lkp@intel.com>]

Hi Jisheng,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.8-rc2 next-20240130]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jisheng-Zhang/riscv-optimized-memcpy/20240128-232523
base:   linus/master
patch link:    https://lore.kernel.org/r/20240128111013.2450-2-jszhang%40kernel.org
patch subject: [PATCH 1/3] riscv: optimized memcpy
config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20240131/202401310644.bffdWJJb-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240131/202401310644.bffdWJJb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401310644.bffdWJJb-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/string.h:292,
                    from include/linux/bitmap.h:12,
                    from include/linux/cpumask.h:12,
                    from include/linux/smp.h:13,
                    from include/linux/lockdep.h:14,
                    from include/linux/spinlock.h:63,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:7,
                    from include/linux/umh.h:4,
                    from include/linux/kmod.h:9,
                    from include/linux/module.h:17,
                    from arch/riscv/lib/string.c:10:
>> include/linux/fortify-string.h:580:63: error: expected identifier or '(' before '{' token
     580 |                              p_size_field, q_size_field, op) ({         \
         |                                                               ^
   include/linux/fortify-string.h:638:26: note: in expansion of macro '__fortify_memcpy_chk'
     638 | #define memcpy(p, q, s)  __fortify_memcpy_chk(p, q, s,                  \
         |                          ^~~~~~~~~~~~~~~~~~~~
   arch/riscv/lib/string.c:118:7: note: in expansion of macro 'memcpy'
     118 | void *memcpy(void *dest, const void *src, size_t count) __weak __alias(__memcpy);
         |       ^~~~~~


vim +580 include/linux/fortify-string.h

a28a6e860c6cf2 Francis Laniel  2021-02-25  578  
f68f2ff91512c1 Kees Cook       2021-04-20  579  #define __fortify_memcpy_chk(p, q, size, p_size, q_size,		\
f68f2ff91512c1 Kees Cook       2021-04-20 @580  			     p_size_field, q_size_field, op) ({		\
6f7630b1b5bc67 Kees Cook       2022-10-28  581  	const size_t __fortify_size = (size_t)(size);			\
6f7630b1b5bc67 Kees Cook       2022-10-28  582  	const size_t __p_size = (p_size);				\
6f7630b1b5bc67 Kees Cook       2022-10-28  583  	const size_t __q_size = (q_size);				\
6f7630b1b5bc67 Kees Cook       2022-10-28  584  	const size_t __p_size_field = (p_size_field);			\
6f7630b1b5bc67 Kees Cook       2022-10-28  585  	const size_t __q_size_field = (q_size_field);			\
6f7630b1b5bc67 Kees Cook       2022-10-28  586  	WARN_ONCE(fortify_memcpy_chk(__fortify_size, __p_size,		\
6f7630b1b5bc67 Kees Cook       2022-10-28  587  				     __q_size, __p_size_field,		\
6f7630b1b5bc67 Kees Cook       2022-10-28  588  				     __q_size_field, #op),		\
54d9469bc515dc Kees Cook       2021-06-24  589  		  #op ": detected field-spanning write (size %zu) of single %s (size %zu)\n", \
54d9469bc515dc Kees Cook       2021-06-24  590  		  __fortify_size,					\
5097a69d676f7e Alexey Dobriyan 2023-09-16  591  		  "field \"" #p "\" at " FILE_LINE,			\
6f7630b1b5bc67 Kees Cook       2022-10-28  592  		  __p_size_field);					\
f68f2ff91512c1 Kees Cook       2021-04-20  593  	__underlying_##op(p, q, __fortify_size);			\
f68f2ff91512c1 Kees Cook       2021-04-20  594  })
f68f2ff91512c1 Kees Cook       2021-04-20  595  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki