From: Stephen Hemminger <stephen@networkplumber.org>
To: Denis Kirjanov <kirjanov@gmail.com>
Cc: netdev@vger.kernel.org, Denis Kirjanov <dkirjanov@suse.de>
Subject: Re: [PATCH iproute2] ifstat: convert sprintf to snprintf
Date: Wed, 31 Jan 2024 08:14:18 -0800 [thread overview]
Message-ID: <20240131081418.72770d85@hermes.local> (raw)
In-Reply-To: <20240131124107.1428-1-dkirjanov@suse.de>
On Wed, 31 Jan 2024 07:41:07 -0500
Denis Kirjanov <kirjanov@gmail.com> wrote:
> @@ -893,7 +893,7 @@ int main(int argc, char *argv[])
>
> sun.sun_family = AF_UNIX;
> sun.sun_path[0] = 0;
> - sprintf(sun.sun_path+1, "ifstat%d", getuid());
> + snprintf(sun.sun_path+1, sizeof(sun.sun_path), "ifstat%d", getuid());
If you are changing the line, please add spaces around plus sign
p
next prev parent reply other threads:[~2024-01-31 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 12:41 [PATCH iproute2] ifstat: convert sprintf to snprintf Denis Kirjanov
2024-01-31 16:14 ` Stephen Hemminger [this message]
2024-02-02 11:32 ` David Laight
2024-02-02 12:23 ` Denis Kirjanov
2024-02-02 13:02 ` David Laight
2024-02-02 13:28 ` Denis Kirjanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131081418.72770d85@hermes.local \
--to=stephen@networkplumber.org \
--cc=dkirjanov@suse.de \
--cc=kirjanov@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.