From: Jakub Kicinski <kuba@kernel.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Yunsheng Lin <linyunsheng@huawei.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, bpf@vger.kernel.org,
willemdebruijn.kernel@gmail.com, jasowang@redhat.com,
sdf@google.com, ilias.apalodimas@linaro.org
Subject: Re: [PATCH v6 net-next 4/5] net: page_pool: make stats available just for global pools
Date: Wed, 31 Jan 2024 15:52:51 -0800 [thread overview]
Message-ID: <20240131155251.5d22477f@kernel.org> (raw)
In-Reply-To: <877cjpzfgv.fsf@toke.dk>
On Wed, 31 Jan 2024 16:32:00 +0100 Toke Høiland-Jørgensen wrote:
> > ack from my side if you have some use-cases in mind.
> > Some questions below:
> > - can we assume ethtool will be used to report stats just for 'global'
> > page_pool (not per-cpu page_pool)?
> > - can we assume netlink/yaml will be used to report per-cpu page_pool stats?
> >
> > I think in the current series we can fix the accounting part (in particular
> > avoiding memory wasting) and then we will figure out how to report percpu
> > page_pool stats through netlink/yaml. Agree?
>
> Deferring the export API to a separate series after this is merged is
> fine with me.
+1
> In which case the *gathering* of statistics could also be
> deferred (it's not really useful if it can't be exported).
What do you mean by "gather" here? If we plan to expose them later on
I reckon there's no point having this patch which actively optimizes
them away, no? IOW we should just drop this patch from v7?
next prev parent reply other threads:[~2024-01-31 23:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 14:20 [PATCH v6 net-next 0/5] add multi-buff support for xdp running in generic mode Lorenzo Bianconi
2024-01-28 14:20 ` [PATCH v6 net-next 1/5] net: add generic per-cpu page_pool allocator Lorenzo Bianconi
2024-01-29 6:37 ` kernel test robot
2024-01-29 12:05 ` Yunsheng Lin
2024-01-29 13:04 ` Lorenzo Bianconi
2024-01-30 11:02 ` Yunsheng Lin
2024-01-30 14:26 ` Lorenzo Bianconi
2024-02-01 11:49 ` Lorenzo Bianconi
2024-02-01 12:14 ` Yunsheng Lin
2024-01-29 12:45 ` Toke Høiland-Jørgensen
2024-01-29 12:52 ` Lorenzo Bianconi
2024-01-29 15:44 ` Toke Høiland-Jørgensen
2024-01-31 12:51 ` Jesper Dangaard Brouer
2024-01-31 12:28 ` Jesper Dangaard Brouer
2024-01-31 13:36 ` Lorenzo Bianconi
2024-01-28 14:20 ` [PATCH v6 net-next 2/5] xdp: rely on skb pointer reference in do_xdp_generic and netif_receive_generic_xdp Lorenzo Bianconi
2024-01-29 8:05 ` Ilias Apalodimas
2024-01-29 9:58 ` Lorenzo Bianconi
2024-01-28 14:20 ` [PATCH v6 net-next 3/5] xdp: add multi-buff support for xdp running in generic mode Lorenzo Bianconi
2024-01-31 23:47 ` Jakub Kicinski
2024-02-01 11:34 ` Lorenzo Bianconi
2024-02-01 15:15 ` Jakub Kicinski
2024-02-01 16:41 ` Lorenzo Bianconi
2024-01-28 14:20 ` [PATCH v6 net-next 4/5] net: page_pool: make stats available just for global pools Lorenzo Bianconi
2024-01-29 12:06 ` Yunsheng Lin
2024-01-29 13:07 ` Lorenzo Bianconi
2024-01-30 11:23 ` Yunsheng Lin
2024-01-30 13:52 ` Lorenzo Bianconi
2024-01-30 15:11 ` Jesper Dangaard Brouer
2024-01-30 16:01 ` Lorenzo Bianconi
2024-01-31 15:32 ` Toke Høiland-Jørgensen
2024-01-31 23:52 ` Jakub Kicinski [this message]
2024-02-01 10:54 ` Lorenzo Bianconi
2024-01-28 14:20 ` [PATCH v6 net-next 5/5] veth: rely on netif_skb_segment_for_xdp utility routine Lorenzo Bianconi
2024-01-29 12:43 ` [PATCH v6 net-next 0/5] add multi-buff support for xdp running in generic mode Toke Høiland-Jørgensen
2024-01-29 13:05 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131155251.5d22477f@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jasowang@redhat.com \
--cc=linyunsheng@huawei.com \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=toke@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.