From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [Patch v6 6/8] libswap: customize swapfile size
Date: Wed, 31 Jan 2024 19:01:30 +0100 [thread overview]
Message-ID: <20240131180130.GB18869@pevik> (raw)
In-Reply-To: <20240131102514.2739270-7-liwang@redhat.com>
Hi Li,
> The key change is the modification of the make_swapfile function to
> accept an additional parameter blocks, specifying the number of
> blocks to allocate for the swap file. This change allows for more
> granular control over the size of swap files created during tests.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
...
> diff --git a/include/libswap.h b/include/libswap.h
> index d4b5301a5..e67d65756 100644
> --- a/include/libswap.h
> +++ b/include/libswap.h
> @@ -14,7 +14,7 @@
> /*
> * Make a swap file
> */
nit: it'd be nice to have a parameter description (feel free to add before
merge).
> -int make_swapfile(const char *swapfile, int safe);
> +int make_swapfile(const char *swapfile, int blocks, int safe);
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-01-31 18:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 10:25 [LTP] [Patch v6 0/8] improvement work on libswap library Li Wang
2024-01-31 10:25 ` [LTP] [Patch v6 1/8] libswap: add known swap supported fs check Li Wang
2024-01-31 10:25 ` [LTP] [Patch v6 2/8] swapon01: Test on all filesystems Li Wang
2024-01-31 10:25 ` [LTP] [Patch v6 3/8] swapon01: Improving test with memory limits and swap reporting Li Wang
2024-01-31 10:25 ` [LTP] [Patch v6 4/8] libswap: add function to prealloc contiguous file Li Wang
2024-01-31 10:25 ` [LTP] [Patch v6 5/8] libswap: Introduce file contiguity check Li Wang
2024-01-31 10:25 ` [LTP] [Patch v6 6/8] libswap: customize swapfile size Li Wang
2024-01-31 18:01 ` Petr Vorel [this message]
2024-01-31 10:25 ` [LTP] [Patch v6 7/8] swapon/off: enable all_filesystem in swap test Li Wang
2024-01-31 17:38 ` Petr Vorel
2024-01-31 18:53 ` Petr Vorel
2024-01-31 19:01 ` Petr Vorel
2024-02-01 6:57 ` Li Wang
2024-02-01 7:46 ` Petr Vorel
2024-02-01 8:05 ` Li Wang
2024-02-01 4:00 ` Li Wang
2024-01-31 10:25 ` [LTP] [Patch v6 8/8] libswap: Refactor is_swap_supported function to return status Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131180130.GB18869@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.