From: Jakub Kicinski <kuba@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: Simon Horman <horms@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"bcreeley@amd.com" <bcreeley@amd.com>,
Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
Geethasowjanya Akula <gakula@marvell.com>,
Hariprasad Kelam <hkelam@marvell.com>,
Suman Ghosh <sumang@marvell.com>
Subject: Re: [EXT] Re: [PATCH net v3] octeontx2-af: Initialize maps.
Date: Thu, 1 Feb 2024 08:27:17 -0800 [thread overview]
Message-ID: <20240201082717.7b946987@kernel.org> (raw)
In-Reply-To: <MWHPR1801MB1918CFDBEC70A298A3781945D3432@MWHPR1801MB1918.namprd18.prod.outlook.com>
On Thu, 1 Feb 2024 09:35:15 +0000 Ratheesh Kannoth wrote:
> > The use of bitmap_zalloc()/bitmap_free() looks good to me.
> > But for the kmalloc_array(..., GFP_KERNEL | __GFP_ZERO) cases I think
> > kcalloc() is the way to go.
> Kcalloc() is a wrapper around kmalloc_array(). Why do you think kcalloc()
> Is better ?
AFAICT this is not the first time you're questioning Simon's obviously
correct feedback. Are you genuinely asking for an explanation why
kcalloc() is better than kmalloc_array()? It's an equivalent to
the standard C function, calloc().
The reviewers are the most valuable part of this community, we will
not take frustrating them lightly :|
next prev parent reply other threads:[~2024-02-01 16:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 2:41 [PATCH net v3] octeontx2-af: Initialize maps Ratheesh Kannoth
2024-01-31 17:30 ` Brett Creeley
2024-02-01 9:31 ` Simon Horman
2024-02-01 9:35 ` [EXT] " Ratheesh Kannoth
2024-02-01 16:27 ` Jakub Kicinski [this message]
2024-02-02 7:32 ` Ratheesh Kannoth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201082717.7b946987@kernel.org \
--to=kuba@kernel.org \
--cc=bcreeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.