From: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
To: Weizhao Ouyang <o451686892@gmail.com>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
Tom Rini <trini@konsulko.com>,
Etienne Carriere <etienne.carriere@foss.st.com>,
Weizhao Ouyang <o451686892@gmail.com>,
Simon Glass <sjg@chromium.org>, Peng Fan <peng.fan@nxp.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jens Wiklander <jens.wiklander@linaro.org>,
Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH v3 1/3] firmware: psci: Fix bind_smccc_features psci check
Date: Thu, 1 Feb 2024 11:40:30 +0000 [thread overview]
Message-ID: <20240201114030.GA112745@e130802.arm.com> (raw)
In-Reply-To: <20240131141426.34926-2-o451686892@gmail.com>
Hi Weizhao,
> - if (request_psci_features(ARM_SMCCC_ARCH_FEATURES) ==
> + if (request_psci_features(ARM_SMCCC_VERSION) ==
> PSCI_RET_NOT_SUPPORTED)
> return 0;
>
> + if (invoke_psci_fn(ARM_SMCCC_VERSION, 0, 0, 0) < ARM_SMCCC_VERSION_1_1)
> + return 0;
It makes sense to me, thanks.
> diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h
> index f44e9e8f93..da3d29aabe 100644
> --- a/include/linux/arm-smccc.h
> +++ b/include/linux/arm-smccc.h
> @@ -55,8 +55,14 @@
> #define ARM_SMCCC_QUIRK_NONE 0
> #define ARM_SMCCC_QUIRK_QCOM_A6 1 /* Save/restore register a6 */
>
> +#define ARM_SMCCC_VERSION 0x80000000
> #define ARM_SMCCC_ARCH_FEATURES 0x80000001
>
> +#define ARM_SMCCC_VERSION_1_0 0x10000
> +#define ARM_SMCCC_VERSION_1_1 0x10001
> +#define ARM_SMCCC_VERSION_1_2 0x10002
> +#define ARM_SMCCC_VERSION_1_3 0x10003
Apart from ARM_SMCCC_VERSION_1_1, are the other ARM_SMCCC_VERSION_1_x defines needed ?
Cheers,
Abdellatif
next prev parent reply other threads:[~2024-02-01 11:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 14:14 [PATCH v3 0/3] Random Number Generator fixes Weizhao Ouyang
2024-01-31 14:14 ` [PATCH v3 1/3] firmware: psci: Fix bind_smccc_features psci check Weizhao Ouyang
2024-02-01 11:40 ` Abdellatif El Khlifi [this message]
2024-02-02 3:40 ` Weizhao Ouyang
2024-02-01 14:36 ` Igor Opaniuk
2024-02-02 3:42 ` Weizhao Ouyang
2024-02-02 21:18 ` Igor Opaniuk
2024-01-31 14:14 ` [PATCH v3 2/3] driver: rng: Fix SMCCC TRNG crash Weizhao Ouyang
2024-01-31 17:04 ` Matthias Brugger
2024-01-31 14:14 ` [PATCH v3 3/3] cmd: rng: Add rng list command Weizhao Ouyang
2024-01-31 17:06 ` Matthias Brugger
2024-02-01 14:32 ` Igor Opaniuk
2024-02-05 18:14 ` Tom Rini
2024-02-06 8:24 ` Weizhao Ouyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201114030.GA112745@e130802.arm.com \
--to=abdellatif.elkhlifi@arm.com \
--cc=etienne.carriere@foss.st.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jens.wiklander@linaro.org \
--cc=o451686892@gmail.com \
--cc=peng.fan@nxp.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.