From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzbot <syzkaller@googlegroups.com>, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net] netdevsim: avoid potential loop in nsim_dev_trap_report_work()
Date: Thu, 1 Feb 2024 13:41:08 -0800 [thread overview]
Message-ID: <20240201134108.195cf302@kernel.org> (raw)
In-Reply-To: <CANn89i+MLtYa9kxc4r_etSrz87hoMF8L_HHbJXtaNEU7C22-Ng@mail.gmail.com>
On Thu, 1 Feb 2024 21:10:46 +0100 Eric Dumazet wrote:
> > And possibly adding 1ms delay there could be problematic?
>
> A conversion to schedule_delayed_work() would be needed I think.
>
> I looked at all syzbot reports and did not find
> devlink_rel_nested_in_notify_work() in them,
> I guess we were lucky all this time :)
FWIW the devlink_rel_* stuff is for linecards and SIOV sub function
instances, netdevsim can't fake those so syzbot probably never
exercises that code :(
Jiri is on CC, so we can consider him notified about the problem
and leave it to him? :)
next prev parent reply other threads:[~2024-02-01 21:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 17:53 [PATCH net] netdevsim: avoid potential loop in nsim_dev_trap_report_work() Eric Dumazet
2024-02-01 18:49 ` Paolo Abeni
2024-02-01 20:10 ` Eric Dumazet
2024-02-01 21:41 ` Jakub Kicinski [this message]
2024-02-02 8:39 ` Jiri Pirko
2024-02-02 9:08 ` Jiri Pirko
2024-02-02 12:04 ` Jiri Pirko
2024-02-02 12:39 ` Eric Dumazet
2024-02-02 12:56 ` Jiri Pirko
2024-02-02 19:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201134108.195cf302@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jiri@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.