From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90DF8C48291 for ; Fri, 2 Feb 2024 16:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=whkswebeDW3DJogfOV4IknPghhxeRFbymEyXg9Yl8Wk=; b=uyZppX3nydwrPl dqSKP0CQ9nh6UgTlsR6DPvLAeC1Qew3ZubOkw4e8/6ck1zkNP0UBMyDIYCfPIsbJReOSpZZaBWCHl 7jWP4ls2dN687Y4Hx53Tl0c2zbBVWCE7DUqE0Bu+2+YFgHZ5MfP3l5jG5eOpANreBZ2vH3hJGiP0n aivBuckvV2nkBOevrYKUJwcs+GZ5MkfTiNjh3PKQMW9qEeBA2mjN1X7QQ54PUDoYdjmKvwwOAIWFb hhkIponRZ7Lk+ArbPIVCa05DSKlQJ/ITV9ldVIICPGxB20rhT3DozN3hhih0zxrCIpSNoosJJXBqB JXSvUKZMCLgrUfHx61cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVwk0-0000000CQAf-3r4T; Fri, 02 Feb 2024 16:50:12 +0000 Received: from zeniv.linux.org.uk ([62.89.141.173]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVwjy-0000000CQ9d-1dk1 for linux-arm-kernel@lists.infradead.org; Fri, 02 Feb 2024 16:50:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=s9JPuMGns8g3lIGXW/Eg6QZhxZ7uPg73+hdVmq5mOgM=; b=DVkgZZfi2r2C6r6Wp9n1fbDZkc DDthIagMB72CZNj3c6Nd+qnHEjDJhCtk+e7YNlPIhSqbXDIlapav868Tf9f0/nGKw/U7L571XMIo/ 5Eae+fjojVYAmCBw2LZrYx1fVhXpXagV6YrjFm31MBr9ITLM++fJ32peBWHWA/YkQKCYl0OHDrwfr Zo6hElXlTyGl43i2hChpfarFNlP0vWwH0XO6sSiqypqKfPoqU8FWG0fOULIEZ6sfvBQCwB6nr3glw R6Cs4T7oJSHCS1ujs+1XRpag4wm5e76zFGg+MKHKGHA1W+YALv8TKXFVZ+RVTsApAkdeSQt7lm75k BJ9uapJg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1rVwjb-0047ud-1N; Fri, 02 Feb 2024 16:49:47 +0000 Date: Fri, 2 Feb 2024 16:49:47 +0000 From: Al Viro To: Doug Anderson Cc: Christian Brauner , Eric Biederman , Jan Kara , Kees Cook , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Oleg Nesterov , Catalin Marinas , Will Deacon , Linux ARM Subject: Re: [PATCH] regset: use vmalloc() for regset_get_alloc() Message-ID: <20240202164947.GC2087318@ZenIV> References: <20240201171159.1.Id9ad163b60d21c9e56c2d686b0cc9083a8ba7924@changeid> <20240202012249.GU2087318@ZenIV> <20240202030438.GV2087318@ZenIV> <20240202034925.GW2087318@ZenIV> <20240202040503.GX2087318@ZenIV> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240202_085010_452881_2CCE1161 X-CRM114-Status: GOOD ( 27.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBGZWIgMDIsIDIwMjQgYXQgMDg6MjQ6MTdBTSAtMDgwMCwgRG91ZyBBbmRlcnNvbiB3 cm90ZToKPiBIaSwKPiAKPiBPbiBUaHUsIEZlYiAxLCAyMDI0IGF0IDg6MDXigK9QTSBBbCBWaXJv IDx2aXJvQHplbml2LmxpbnV4Lm9yZy51az4gd3JvdGU6Cj4gPgo+ID4gT24gRnJpLCBGZWIgMDIs IDIwMjQgYXQgMDM6NDk6MjVBTSArMDAwMCwgQWwgVmlybyB3cm90ZToKPiA+ID4gT24gVGh1LCBG ZWIgMDEsIDIwMjQgYXQgMDc6MTU6NDhQTSAtMDgwMCwgRG91ZyBBbmRlcnNvbiB3cm90ZToKPiA+ ID4gPiA+Cj4gPiA+ID4gPiBXZWxsLCB0aGUgbmV4dCBzdGVwIHdvdWxkIGJlIHRvIHNlZSB3aGlj aCByZWdzZXQgaXQgaXMgLSBpZiB5b3UKPiA+ID4gPiA+IHNlZSB0aGF0IGtpbmQgb2YgYWxsb2Nh dGlvbiwgcHJpbnQgcmVnc2V0LT5uLCByZWdzZXQtPnNpemUgYW5kCj4gPiA+ID4gPiByZWdzZXQt PmNvcmVfbm90ZV90eXBlLgo+ID4gPiA+Cj4gPiA+ID4gT2YgY291cnNlISBIZXJlIGFyZSB0aGUg YmlnIG9uZXM6Cj4gPiA+ID4KPiA+ID4gPiBbICAgNDUuODc1NTc0XSBET1VHOiBBbGxvY2F0aW5n IDI3OTU4NCBieXRlcywgbj0xNzQ3NCwgc2l6ZT0xNiwKPiA+ID4gPiBjb3JlX25vdGVfdHlwZT0x MDI5Cj4gPiA+Cj4gPiA+IDB4NDA1LCBOVF9BUk1fU1ZFCj4gPiA+ICAgICAgICAgW1JFR1NFVF9T VkVdID0geyAvKiBTY2FsYWJsZSBWZWN0b3IgRXh0ZW5zaW9uICovCj4gPiA+ICAgICAgICAgICAg ICAgICAuY29yZV9ub3RlX3R5cGUgPSBOVF9BUk1fU1ZFLAo+ID4gPiAgICAgICAgICAgICAgICAg Lm4gPSBESVZfUk9VTkRfVVAoU1ZFX1BUX1NJWkUoU1ZFX1ZRX01BWCwgU1ZFX1BUX1JFR1NfU1ZF KSwKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNWRV9WUV9CWVRFUyks Cj4gPiA+ICAgICAgICAgICAgICAgICAuc2l6ZSA9IFNWRV9WUV9CWVRFUywKPiA+ID4KPiA+ID4g SURHSS4gIFdhc24ndCBTVkUgdXAgdG8gMzIgKiAyS2JpdCwgaS5lLiA4S2J5dGUgbWF4PyAgQW55 IEFSTSBmb2xrcyBhcm91bmQ/Cj4gPiA+IFN1cmUsIEkgdW5kZXJzdGFuZCB0aGF0IGl0J3MgdmFy aWFibGUtc2l6ZWQgYW5kIHdlIHdhbnQgdG8gYWxsb2NhdGUgZW5vdWdoCj4gPiA+IGZvciB0aGUg d29yc3QgY2FzZSwgYnV0IGNhbiB3ZSByZWFsbHkgZ2V0IGFib3V0IDI4MEtiIHRoZXJlPyAgQ29u dGV4dCBzd2l0Y2hlcwo+ID4gPiB3b3VsZCBiZSByZWFsbHkgdW5wbGVhc2FudCBvbiBzdWNoIGJv eGVuLi4uCj4gPgo+ID4gRldJVywgdGhpcyBhcHBhcmVudGx5IGludGVuZHMgdG8gYmUgInZhcmlh YmxlLCB1cCB0byBTVkVfUFRfU0laRSguLi4pIGJ5dGVzIjsKPiA+IG5vIGlkZWEgaWYgU1ZFX1BU X1NJWkUgaXMgdGhlIHJpZ2h0IHRoaW5nIHRvIHVzZSBoZXJlLgo+IAo+ICtmb2xrcyBmcm9tIGAu L3NjcmlwdHMvZ2V0X21haW50YWluZXIucGwgLWYgYXJjaC9hcm02NC9rZXJuZWwvcHRyYWNlLmNg Cj4gCj4gVHJ5aW5nIHRvIGZvbGxvdyB0aGUgbWFjcm9zIHRvIHNlZSB3aGVyZSAibiIgY29tZXMg ZnJvbSBpcyBhIG1hemUgb2YKPiB0d2lzdHkgbGl0dGxlIHBhc3NhZ2VzLCBhbGwgYWxpa2UuIEhv cGVmdWxseSBzb21lb25lIGZyb20gdGhlIEFSTQo+IHdvcmxkIGNhbiBoZWxwIHRlbGwgaWYgdGhl IHZhbHVlIG9mIDE3NDc0IGZvciBuIGhlcmUgaXMgY29ycmVjdCBvciBpZgo+IHNvbWV0aGluZyBp cyB3b25reS4KCkl0IG1pZ2h0IGJlIGludGVyZXN0aW5nIHRvIGhhdmUgaXQgcHJpbnQgdGhlIHJl dHVybiB2YWx1ZSBvZiBfX3JlZ3NldF9nZXQoKQppbiB0aG9zZSBjYXNlczsgaWYgKnRoYXQqIGlz IGh1Z2UsIHdlIHJlYWxseSBoYXZlIGEgcHJvYmxlbS4gIElmIGl0IGVuZHMgdXAKc21hbGwgZW5v dWdoIHRvIGZpdCBpbnRvIGZldyBwYWdlcywgT1RPSC4uLgoKU1ZFX1ZRX01BWCBpcyBkZWZpbmVk IGFzIDI1NTsgaXMgdGhhdCByZWFsbHkgaW4gdW5pdHMgb2YgMTI4IGJpdHM/ICBJT1csCmRvIHdl IHJlYWxseSBleHBlY3QgdG8gc3VwcG9ydCAzMktiaXQgcmVnaXN0ZXJzPyAgVGhhdCB3b3VsZCBk cml2ZSB0aGUKc2l6ZSBpbnRvIHRoYXQgcmFuZ2UsIGFsbCByaWdodCwgYnV0IGl0IHdvdWxkIHJl YWxseSBzdWNrIG9uIGNvbnRleHQKc3dpdGNoZXMuCgpJIGNvdWxkIGJlIG1pc3JlYWRpbmcgaXQs IHRob3VnaCAtIHRoZSBtYWNyb3MgaW4gdGhlcmUgYXJlIG5vdCBlYXN5IHRvCmZvbGxvdyBhbmQg SSd2ZSBuZXZlciBkZWFsdCB3aXRoIFNWRSBiZWZvcmUsIHNvIHRha2UgdGhlIGFib3ZlIHdpdGgK YSBjYXJ0bG9hZCBvZiBzYWx0LgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74B701487C1; Fri, 2 Feb 2024 16:49:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706892599; cv=none; b=nzctPdyB2boCj3TFGe8aisqH3kkcZwQfu9+wjQzJAZ/02PaIDpBBgCIcjiAdUAoA+qYZIeJcfdTneo1wYNzFy7Jtsjy4ooTCBCSKb0+AlXeUfsuWLCmGBH1EcHG82CZmIYlxrLw0zmVBaV9jX7IO1Dfi82AlIU7GbziwCZRHf1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706892599; c=relaxed/simple; bh=gnFe0Frak2hFCx8RZtBOH/vB3WQDtpNqAaGgzrVnBdM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k4W7dCPnF/0wt8v1cyJvWAlDo0+xBRmyfzKqL9amQPnteIzYmy1m4dej2IvjY6HP+mTTasKV/4TMKkh4WiovCqQXg9f2KCGr5XI2W2PwULDCLaOznzMPPXCys3tIcYuDlSSQhscqPvH8r9i/DWnqw/5sCHbnz5w8GE0gc0QCBZg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=DVkgZZfi; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="DVkgZZfi" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=s9JPuMGns8g3lIGXW/Eg6QZhxZ7uPg73+hdVmq5mOgM=; b=DVkgZZfi2r2C6r6Wp9n1fbDZkc DDthIagMB72CZNj3c6Nd+qnHEjDJhCtk+e7YNlPIhSqbXDIlapav868Tf9f0/nGKw/U7L571XMIo/ 5Eae+fjojVYAmCBw2LZrYx1fVhXpXagV6YrjFm31MBr9ITLM++fJ32peBWHWA/YkQKCYl0OHDrwfr Zo6hElXlTyGl43i2hChpfarFNlP0vWwH0XO6sSiqypqKfPoqU8FWG0fOULIEZ6sfvBQCwB6nr3glw R6Cs4T7oJSHCS1ujs+1XRpag4wm5e76zFGg+MKHKGHA1W+YALv8TKXFVZ+RVTsApAkdeSQt7lm75k BJ9uapJg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1rVwjb-0047ud-1N; Fri, 02 Feb 2024 16:49:47 +0000 Date: Fri, 2 Feb 2024 16:49:47 +0000 From: Al Viro To: Doug Anderson Cc: Christian Brauner , Eric Biederman , Jan Kara , Kees Cook , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Oleg Nesterov , Catalin Marinas , Will Deacon , Linux ARM Subject: Re: [PATCH] regset: use vmalloc() for regset_get_alloc() Message-ID: <20240202164947.GC2087318@ZenIV> References: <20240201171159.1.Id9ad163b60d21c9e56c2d686b0cc9083a8ba7924@changeid> <20240202012249.GU2087318@ZenIV> <20240202030438.GV2087318@ZenIV> <20240202034925.GW2087318@ZenIV> <20240202040503.GX2087318@ZenIV> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: Al Viro On Fri, Feb 02, 2024 at 08:24:17AM -0800, Doug Anderson wrote: > Hi, > > On Thu, Feb 1, 2024 at 8:05 PM Al Viro wrote: > > > > On Fri, Feb 02, 2024 at 03:49:25AM +0000, Al Viro wrote: > > > On Thu, Feb 01, 2024 at 07:15:48PM -0800, Doug Anderson wrote: > > > > > > > > > > Well, the next step would be to see which regset it is - if you > > > > > see that kind of allocation, print regset->n, regset->size and > > > > > regset->core_note_type. > > > > > > > > Of course! Here are the big ones: > > > > > > > > [ 45.875574] DOUG: Allocating 279584 bytes, n=17474, size=16, > > > > core_note_type=1029 > > > > > > 0x405, NT_ARM_SVE > > > [REGSET_SVE] = { /* Scalable Vector Extension */ > > > .core_note_type = NT_ARM_SVE, > > > .n = DIV_ROUND_UP(SVE_PT_SIZE(SVE_VQ_MAX, SVE_PT_REGS_SVE), > > > SVE_VQ_BYTES), > > > .size = SVE_VQ_BYTES, > > > > > > IDGI. Wasn't SVE up to 32 * 2Kbit, i.e. 8Kbyte max? Any ARM folks around? > > > Sure, I understand that it's variable-sized and we want to allocate enough > > > for the worst case, but can we really get about 280Kb there? Context switches > > > would be really unpleasant on such boxen... > > > > FWIW, this apparently intends to be "variable, up to SVE_PT_SIZE(...) bytes"; > > no idea if SVE_PT_SIZE is the right thing to use here. > > +folks from `./scripts/get_maintainer.pl -f arch/arm64/kernel/ptrace.c` > > Trying to follow the macros to see where "n" comes from is a maze of > twisty little passages, all alike. Hopefully someone from the ARM > world can help tell if the value of 17474 for n here is correct or if > something is wonky. It might be interesting to have it print the return value of __regset_get() in those cases; if *that* is huge, we really have a problem. If it ends up small enough to fit into few pages, OTOH... SVE_VQ_MAX is defined as 255; is that really in units of 128 bits? IOW, do we really expect to support 32Kbit registers? That would drive the size into that range, all right, but it would really suck on context switches. I could be misreading it, though - the macros in there are not easy to follow and I've never dealt with SVE before, so take the above with a cartload of salt.