From: Dimitri Fedrau <dima.fedrau@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Stefan Eichenberger <eichest@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 net-next 12/13] net: phy: marvell-88q2xxx: cleanup mv88q2xxx_config_init
Date: Fri, 2 Feb 2024 18:19:52 +0100 [thread overview]
Message-ID: <20240202171952.GA14633@debian> (raw)
In-Reply-To: <c2bb9f1b-2003-4c0c-b6c0-1cee6ac6a5b8@lunn.ch>
Am Wed, Jan 31, 2024 at 04:21:44PM +0100 schrieb Andrew Lunn:
> On Mon, Jan 22, 2024 at 10:28:45PM +0100, Dimitri Fedrau wrote:
> > mv88q2xxx_config_init calls genphy_c45_read_pma which is done by
> > mv88q2xxx_read_status, it calls also mv88q2xxx_config_aneg which is
> > also called by the PHY state machine. Let the PHY state machine handle
> > the phydriver ops in their intendend way.
> >
> > Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
Thanks, for reviewing. Is there a chance that you also have a look on
patch 13 of the series ? It relies on this patch.
next prev parent reply other threads:[~2024-02-02 17:19 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 21:28 [PATCH v5 net-next 00/13] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 01/13] net: phy: Add BaseT1 auto-negotiation constants Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 02/13] net: phy: Support 100/1000BT1 linkmode advertisements Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 03/13] net: phy: c45: detect 100/1000BASE-T1 " Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 04/13] net: phy: marvell-88q2xxx: fix typos Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 05/13] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY Dimitri Fedrau
2024-01-31 15:08 ` Andrew Lunn
2024-01-22 21:28 ` [PATCH v5 net-next 06/13] net: phy: marvell-88q2xxx: add interrupt support for link detection Dimitri Fedrau
2024-01-31 15:12 ` Andrew Lunn
2024-01-22 21:28 ` [PATCH v5 net-next 07/13] net: phy: marvell-88q2xxx: add suspend / resume ops Dimitri Fedrau
2024-01-31 15:12 ` Andrew Lunn
2024-01-22 21:28 ` [PATCH v5 net-next 08/13] net: phy: marvell-88q2xxx: add support for temperature sensor Dimitri Fedrau
2024-01-30 9:18 ` Russell King (Oracle)
2024-01-31 11:52 ` Dimitri Fedrau
2024-01-31 15:17 ` Andrew Lunn
2024-02-01 7:11 ` Dimitri Fedrau
2024-02-01 13:23 ` Andrew Lunn
2024-02-01 16:52 ` Dimitri Fedrau
2024-02-01 13:34 ` Guenter Roeck
2024-02-01 16:14 ` Dimitri Fedrau
2024-02-01 18:26 ` Guenter Roeck
2024-02-01 13:18 ` Guenter Roeck
2024-02-01 13:27 ` Andrew Lunn
2024-02-01 13:39 ` Guenter Roeck
2024-02-01 16:23 ` Dimitri Fedrau
2024-02-01 16:47 ` Andrew Lunn
2024-02-01 16:56 ` Dimitri Fedrau
2024-02-01 18:22 ` Guenter Roeck
2024-02-01 16:17 ` Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 09/13] net: phy: marvell-88q2xxx: add cable test support Dimitri Fedrau
2024-01-30 9:19 ` Russell King (Oracle)
2024-01-31 12:03 ` Dimitri Fedrau
2024-01-22 21:28 ` [PATCH v5 net-next 10/13] net: phy: marvell-88q2xxx: make mv88q2xxx_config_aneg generic Dimitri Fedrau
2024-01-31 15:19 ` Andrew Lunn
2024-01-22 21:28 ` [PATCH v5 net-next 11/13] net: phy: marvell-88q2xxx: switch to mv88q2xxx_config_aneg Dimitri Fedrau
2024-01-31 15:20 ` Andrew Lunn
2024-01-22 21:28 ` [PATCH v5 net-next 12/13] net: phy: marvell-88q2xxx: cleanup mv88q2xxx_config_init Dimitri Fedrau
2024-01-31 15:21 ` Andrew Lunn
2024-02-02 17:19 ` Dimitri Fedrau [this message]
2024-01-22 21:28 ` [PATCH v5 net-next 13/13] net: phy: marvell-88q2xxx: remove redundant code Dimitri Fedrau
2024-01-30 2:09 ` [PATCH v5 net-next 00/13] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY Jakub Kicinski
2024-02-02 18:30 ` Dimitri Fedrau
2024-02-03 16:07 ` Andrew Lunn
2024-02-05 9:32 ` Dimitri Fedrau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240202171952.GA14633@debian \
--to=dima.fedrau@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eichest@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.