From: Al Viro <viro@zeniv.linux.org.uk>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: Amir Goldstein <amir73il@gmail.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Christian Brauner <brauner@kernel.org>,
Mimi Zohar <zohar@linux.ibm.com>,
linux-unionfs@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] fs: remove the inode argument to ->d_real() method
Date: Fri, 2 Feb 2024 18:38:41 +0000 [thread overview]
Message-ID: <20240202183841.GF2087318@ZenIV> (raw)
In-Reply-To: <20240202182732.GE2087318@ZenIV>
On Fri, Feb 02, 2024 at 06:27:32PM +0000, Al Viro wrote:
> Think what happens if you fetch ->len in state prior to
> rename and ->name - after. memcpy() from one memory object
> with length that matches another, UAF right there.
s/UAF/fairly easy oops/ - you can end up fetching past the end of
page that hosts kmalloc'ed object, and there's no promise that anything
will be mapped there. I really need more coffee...
next prev parent reply other threads:[~2024-02-02 18:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 11:01 [PATCH 0/2] Decomplicate file_dentry() Amir Goldstein
2024-02-02 11:01 ` [PATCH 1/2] fs: make file_dentry() a simple accessor Amir Goldstein
2024-02-02 15:16 ` Stefan Berger
2024-02-02 11:01 ` [PATCH 2/2] fs: remove the inode argument to ->d_real() method Amir Goldstein
2024-02-02 12:19 ` Miklos Szeredi
2024-02-02 12:41 ` Amir Goldstein
2024-02-02 13:54 ` Christian Brauner
2024-02-06 15:28 ` Amir Goldstein
2024-02-02 15:17 ` Stefan Berger
2024-02-02 16:05 ` Al Viro
2024-02-02 16:16 ` Al Viro
2024-02-02 17:34 ` Stefan Berger
2024-02-02 18:27 ` Al Viro
2024-02-02 18:32 ` Stefan Berger
2024-02-02 18:50 ` Al Viro
2024-02-02 18:38 ` Al Viro [this message]
2024-02-06 16:02 ` [PATCH 0/2] Decomplicate file_dentry() Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240202183841.GF2087318@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=stefanb@linux.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.