From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>, Liang Li <liali@redhat.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCHv3 net-next 4/4] selftests: bonding: use slowwait instead of hard code sleep
Date: Sat, 3 Feb 2024 09:41:51 -0800 [thread overview]
Message-ID: <20240203094151.5347fba8@kernel.org> (raw)
In-Reply-To: <20240202023754.932930-5-liuhangbin@gmail.com>
On Fri, 2 Feb 2024 10:37:54 +0800 Hangbin Liu wrote:
> diff --git a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
> index b609fb6231f4..acd3ebed3e20 100755
> --- a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
> +++ b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
> @@ -58,7 +58,7 @@ macvlan_over_bond()
> ip -n ${m2_ns} addr add ${m2_ip4}/24 dev macv0
> ip -n ${m2_ns} addr add ${m2_ip6}/24 dev macv0
>
> - sleep 2
> + slowwait 2 ip netns exec ${c_ns} ping ${s_ip4} -c 1 -W 0.1 &> /dev/null
>
> check_connection "${c_ns}" "${s_ip4}" "IPv4: client->server"
> check_connection "${c_ns}" "${s_ip6}" "IPv6: client->server"
> @@ -69,8 +69,7 @@ macvlan_over_bond()
> check_connection "${m1_ns}" "${m2_ip4}" "IPv4: macvlan_1->macvlan_2"
> check_connection "${m1_ns}" "${m2_ip6}" "IPv6: macvlan_1->macvlan_2"
>
> -
> - sleep 5
> + slowwait 5 ip netns exec ${s_ns} ping ${c_ip4} -c 1 -W 0.1 &> /dev/null
>
> check_connection "${s_ns}" "${c_ip4}" "IPv4: server->client"
> check_connection "${s_ns}" "${c_ip6}" "IPv6: server->client"
This makes the bond_macvlan.sh test flaky:
https://netdev.bots.linux.dev/contest.html?test=bond-macvlan-sh
I repro'd it and the ping in check_connection() fails - neigh resolution
fails. I guess we need to insert more of the slowwaits?
Reverting this patch from the pending patch tree fixes it. The runner
has no KVM support, and runs a VM with 64 CPUs. If I lower the number
of CPUs to 4 the test passes. I added the note that some flakiness may
be caused by high CPU count:
https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style#tips
--
pw-bot: cr
next prev parent reply other threads:[~2024-02-03 17:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 2:37 [PATCHv3 net-next 0/4] selftests: bonding: use slowwait when waiting Hangbin Liu
2024-02-02 2:37 ` [PATCHv3 net-next 1/4] selftests/net/forwarding: add slowwait functions Hangbin Liu
2024-02-02 2:37 ` [PATCHv3 net-next 2/4] selftests: bonding: use tc filter to check if LACP was sent Hangbin Liu
2024-02-02 2:37 ` [PATCHv3 net-next 3/4] selftests: bonding: reduce garp_test/arp_validate test time Hangbin Liu
2024-02-02 2:37 ` [PATCHv3 net-next 4/4] selftests: bonding: use slowwait instead of hard code sleep Hangbin Liu
2024-02-03 17:41 ` Jakub Kicinski [this message]
2024-02-04 8:31 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240203094151.5347fba8@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=liali@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.